Prozorov\DataVerification\Factories\AbstractFactory

Complexity

Total Complexity

12

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Test Coverage

Coverage

85.19%

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getResolvedFromString()	0	11	3
A	entityExists()	0	3	1
B	make()	0	29	7

<?php

namespace Prozorov\DataVerification\Factories;

use Prozorov\DataVerification\Exceptions\{ConfigurationException, FactoryException};
use Webmozart\Assert\Assert;
use Psr\Container\ContainerInterface;

abstract class AbstractFactory
{
    /**
     * @var string $allowedType
     */
    protected $allowedType;

    /**
     * @var array $config
     */
    protected $config = [];

    /**
     * @var array $resolved
     */
    protected $resolved = [];

    /**
     * @var bool $singletons
     */
    protected $singletons = true;

    /**
     * @var ContainerInterface $container
     */
    protected $container;

    public function __construct(array $config, ContainerInterface $container = null)

The parameter $container is not used and could be removed.

    {
        $this->config = $config;
    }

    /**
     * make.
     *
     * @access	public
     * @param	string	$code	
     * @return	mixed
     */
    public function make(string $code)
    {
        if (! empty($this->resolved[$code])) {
            return $this->resolved[$code];
        }

        if (empty($this->config)) {
            throw new ConfigurationException('Фабрика не инициализирована');
        }

        if (empty($this->config[$code])) {
            throw new FactoryException('Отсутствуют инструкции по созданию объекта ' . $code);
        }

        if (is_callable($this->config[$code])) {
            $resolved = $this->config[$code]();
        } elseif (is_string($code)) {

The condition is_string($code) is always true.

            $resolved = $this->getResolvedFromString($code);
        }

        Assert::isInstanceOf($resolved, $this->allowedType);

The variable $resolved does not seem to be defined for all execution paths leading up to this point.

        if (! $this->singletons) {
            return $resolved;
        }

        $this->resolved[$code] = $resolved;

        return $this->resolved[$code];
    }

    /**
     * entityExists.
     *
     * @access	public
     * @param	string	$code	
     * @return	bool
     */
    public function entityExists(string $code): bool
    {
        return array_key_exists($code, $this->config);
    }

    /**
     * getResolvedFromString.
     *
     * @access	protected
     * @return	mixed
     */
    protected function getResolvedFromString(string $code)
    {
        if (! $this->entityExists($code)) {
            throw new FactoryException('Фабрика не может сделать такую сущность');
        }

        if (empty($this->container)) {
            return new $this->config[$code];
        }

        return $this->container->get($this->config[$code]);
    }
}