Conditions | 10 |
Paths | 14 |
Total Lines | 12 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
9 | public static function onAfterEpilogHandler() |
||
10 | { |
||
11 | global $DB, $USER; |
||
12 | |||
13 | $bExcel = isset($_REQUEST["mode"]) && $_REQUEST["mode"] === 'excel'; |
||
14 | if (!defined("ADMIN_AJAX_MODE") && !defined('PUBLIC_AJAX_MODE') && !$bExcel) { |
||
15 | $bShowStat = ($DB->ShowSqlStat && ($USER->CanDoOperation('edit_php') || $_SESSION["SHOW_SQL_STAT"]=="Y")); |
||
16 | if ($bShowStat && class_exists(Manager::class) && Manager::logging()) { |
||
17 | require_once(__DIR__.'/debug_info.php'); |
||
18 | } |
||
19 | } |
||
20 | } |
||
21 | |||
35 |