Action::editIBlockSection() - Code Metrics - Inspection of "more flexible params" - arrilot/bitrix-hermitage - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 194a6e...a14113 )

by Nekrasov

created 2017-11-13 21:58 UTC

Action::editIBlockSection() B

↳ Parent: Action

Complexity

Conditions	5
Paths	5

Size

Total Lines	19
Code Lines	10

Duplication

Lines	19
Ratio	100 %

Importance

Changes

Metric	Value
dl	19
loc	19
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	5
nop	2

<?php

namespace Arrilot\BitrixHermitage;

use Bitrix\Main\Application;
use CBitrixComponent;
use CBitrixComponentTemplate;
use CIBlock;
use InvalidArgumentException;

class Action
{
    protected static $panelButtons = [];
    
    protected static $iblockElementArray = [];
    
    protected static $iblockSectionArray = [];
    
    /**
     * Get edit area id for specific type
     *
     * @param CBitrixComponentTemplate $template
     * @param $type
     * @param $element
     * @return string
     */
    public static function getEditArea($template, $type, $element)
    {
        $id = is_numeric($element) ? $element : $element['ID'];
        return $template->GetEditAreaId("{$type}_{$id}");
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $element
     */
    public static function editIBlockElement($template, $element)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }

        if (is_numeric($element)) {
            $element = static::prepareIBlockElementArrayById($element);
        }

        if (!$element["IBLOCK_ID"] || !$element['ID']) {
            throw new InvalidArgumentException('Element must include ID and IBLOCK_ID');
        }

        $buttons = static::getIBlockElementPanelButtons($element);
        $link = $buttons["edit"]["edit_element"]["ACTION_URL"];

        $template->AddEditAction('iblock_element_' . $element['ID'], $link, CIBlock::GetArrayByID($element["IBLOCK_ID"], "ELEMENT_EDIT"));
    }
    
    /**
     * @param CBitrixComponentTemplate $template
     * @param $element
     * @param string $confirm
     */
    public static function deleteIBlockElement($template, $element, $confirm = 'Вы уверены, что хотите удалить элемент?')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }

        if (is_numeric($element)) {
            $element = static::prepareIBlockElementArrayById($element);
        }

        if (!$element["IBLOCK_ID"] || !$element['ID']) {
            throw new InvalidArgumentException('Element must include ID and IBLOCK_ID');
        }
    
        $buttons = static::getIBlockElementPanelButtons($element);
        $link = $buttons["edit"]["delete_element"]["ACTION_URL"];

        $template->AddDeleteAction('iblock_element_' . $element['ID'], $link, CIBlock::GetArrayByID($element["IBLOCK_ID"], "ELEMENT_DELETE"), array("CONFIRM" => $confirm));
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $element
     * @return string
     */
    public static function areaForIBlockElement($template, $element)
    {
        return static::getEditArea($template, 'iblock_element', $element);
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $section
     */
    public static function editIBlockSection($template, $section)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }

        if (is_numeric($section)) {
            $section = static::prepareIBlockSectionArrayById($section);
        }

        if (!$section["IBLOCK_ID"] || !$section['ID']) {
            throw new InvalidArgumentException('Section must include ID and IBLOCK_ID');
        }
    
        $buttons = static::getIBlockSectionPanelButtons($section);
        $link = $buttons["edit"]["edit_section"]["ACTION_URL"];

        $template->AddEditAction('iblock_section_' . $section['ID'], $link, CIBlock::GetArrayByID($section["IBLOCK_ID"], "SECTION_EDIT"));
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $section
     * @param string $confirm
     */
    public static function deleteIBlockSection($template, $section, $confirm = 'Вы уверены, что хотите удалить раздел?')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }

        if (is_numeric($section)) {
            $section = static::prepareIBlockSectionArrayById($section);
        }

        if (!$section["IBLOCK_ID"] || !$section['ID']) {
            throw new InvalidArgumentException('Section must include ID and IBLOCK_ID');
        }
    
        $buttons = static::getIBlockSectionPanelButtons($section);
        $link = $buttons["edit"]["delete_section"]["ACTION_URL"];

        $template->AddDeleteAction('iblock_section_' . $section['ID'], $link, CIBlock::GetArrayByID($section["IBLOCK_ID"], "SECTION_DELETE"), array("CONFIRM" => $confirm));
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $section
     * @return string
     */
    public static function areaForIBlockSection($template, $section)
    {
        return static::getEditArea($template, 'iblock_section', $section);
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $element
     * @param string $label
     */
    public static function editHLBlockElement($template, $element, $label = 'Изменить элемент')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }

        if (!$element["HLBLOCK_ID"] || !$element['ID']) {
            throw new InvalidArgumentException('Element must include ID and HLBLOCK_ID');
        }

        $linkTemplate = '/bitrix/admin/highloadblock_row_edit.php?ENTITY_ID=%s&ID=%s&lang=ru&bxpublic=Y';
        $link = sprintf($linkTemplate, (int) $element["HLBLOCK_ID"], (int) $element["ID"]);

        $template->AddEditAction('hlblock_element_' . $element['ID'], $link, $label);
    }
    
    /**
     * @param CBitrixComponentTemplate $template
     * @param $element
     * @param string $label
     * @param string $confirm
     */
    public static function deleteHLBlockElement($template, $element, $label = 'Удалить элемент', $confirm = 'Вы уверены, что хотите удалить элемент?')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }
        
        if (!$element["HLBLOCK_ID"] || !$element['ID']) {
            throw new InvalidArgumentException('Element must include ID and HLBLOCK_ID');
        }

        $linkTemplate = '/bitrix/admin/highloadblock_row_edit.php?action=delete&ENTITY_ID=%s&ID=%s&lang=ru';
        $link = sprintf($linkTemplate, (int) $element["HLBLOCK_ID"], (int) $element["ID"]);
    
        $template->AddDeleteAction('hlblock_element_' . $element['ID'], $link, $label, array("CONFIRM" => $confirm));
    }

    /**
     * @param CBitrixComponentTemplate $template
     * @param $element
     * @return string
     */
    public static function areaForHLBlockElement($template, $element)
    {
        return static::getEditArea($template, 'hlblock_element', $element);
    }
    
    /**
     * @param CBitrixComponent|CBitrixComponentTemplate $componentOrTemplate
     * @param $iblockId
     * @param array $options
     */
    public static function addForIBlock($componentOrTemplate, $iblockId, $options = [])
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {
            return;
        }

        if ($componentOrTemplate instanceof CBitrixComponentTemplate) {

            $componentOrTemplate = $componentOrTemplate->__component;
        }

        $buttons = CIBlock::GetPanelButtons($iblockId, 0, 0, $options);
        $menu = CIBlock::GetComponentMenu($GLOBALS['APPLICATION']->GetPublicShowMode(), $buttons);

        $componentOrTemplate->addIncludeAreaIcons($menu);
    }

    /**
     * @param $element
     * @return array
     */
    protected static function getIBlockElementPanelButtons($element)

    {
        if (!isset(static::$panelButtons['iblock_element'][$element['ID']])) {
            static::$panelButtons['iblock_element'][$element['ID']] = CIBlock::GetPanelButtons(
                $element["IBLOCK_ID"],
                $element['ID'],
                0,
                ['SECTION_BUTTONS' => false, 'SESSID' => false]
            );
        }

        return static::$panelButtons['iblock_element'][$element['ID']];
    }

    /**
     * @param $section
     * @return array
     */
    protected static function getIBlockSectionPanelButtons($section)

    {
        if (!isset(static::$panelButtons['iblock_section'][$section['ID']])) {
            static::$panelButtons['iblock_section'][$section['ID']] = CIBlock::GetPanelButtons(
                $section["IBLOCK_ID"],
                0,
                $section['ID'],
                ['SESSID' => false]
            );
        }

        return static::$panelButtons['iblock_section'][$section['ID']];
    }
    
    /**
     * @param int $id
     * @return array
     */
    protected static function prepareIBlockElementArrayById($id)

    {
        $id = (int) $id;
        if (!$id) {
            return [];
        }

        if (empty(static::$iblockElementArray[$id])) {
            $connection = Application::getConnection();
            $el = $connection->query("SELECT ID, IBLOCK_ID FROM b_iblock_element WHERE ID = {$id}")->fetch();
            static::$iblockElementArray[$id] = $el ? $el : [];
        }

        return static::$iblockElementArray[$id];
    }

    /**
     * @param int $id
     * @return array
     */
    protected static function prepareIBlockSectionArrayById($id)

    {
        $id = (int) $id;
        if (!$id) {
            return [];
        }

        if (empty(static::$iblockSectionArray[$id])) {
            $connection = Application::getConnection();
            $el = $connection->query("SELECT ID, IBLOCK_ID FROM b_iblock_section WHERE ID = {$id}")->fetch();
            static::$iblockSectionArray[$id] = $el ? $el : [];
        }

        return static::$iblockSectionArray[$id];
    }
}


1		<?php
2
3		namespace Arrilot\BitrixHermitage;
4
5		use Bitrix\Main\Application;
6		use CBitrixComponent;
7		use CBitrixComponentTemplate;
8		use CIBlock;
9		use InvalidArgumentException;
10
11		class Action
12		{
13		protected static $panelButtons = [];
14
15		protected static $iblockElementArray = [];
16
17		protected static $iblockSectionArray = [];
18
19		/**
20		* Get edit area id for specific type
21		*
22		* @param CBitrixComponentTemplate $template
23		* @param $type
24		* @param $element
25		* @return string
26		*/
27		public static function getEditArea($template, $type, $element)
28		{
29		$id = is_numeric($element) ? $element : $element['ID'];
30		return $template->GetEditAreaId("{$type}_{$id}");
31		}
32
33		/**
34		* @param CBitrixComponentTemplate $template
35		* @param $element
36		*/
37	View Code Duplication	public static function editIBlockElement($template, $element)
		0 ignored issues – show Duplication introduced 2017-11-12 18:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-11-12 22:02 UTC by Report Bug Copy Issue Report `editIBlockElement` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
38		{
39		if (!$GLOBALS['APPLICATION']->GetShowIncludeAreas()) {

arrilot / bitrix-hermitage

Push — master ( 194a6e...a14113 )

Action::editIBlockSection() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like