| Conditions | 28 |
| Total Lines | 46 |
| Code Lines | 46 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 812 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like com.strider.datadefender.database.metadata.SqlTypeToClass.getTypeFrom(int) often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | /* |
||
| 33 | public Class getTypeFrom(int type) { |
||
| 34 | switch (type) { |
||
| 35 | case Types.CHAR: |
||
| 36 | case Types.VARCHAR: |
||
| 37 | case Types.LONGVARCHAR: |
||
| 38 | case Types.NCHAR: |
||
| 39 | case Types.NVARCHAR: |
||
| 40 | case Types.LONGNVARCHAR: |
||
| 41 | return String.class; |
||
| 42 | case Types.BINARY: |
||
| 43 | case Types.VARBINARY: |
||
| 44 | case Types.LONGVARBINARY: |
||
| 45 | return Byte[].class; |
||
| 46 | case Types.NUMERIC: |
||
| 47 | case Types.DECIMAL: |
||
| 48 | return BigDecimal.class; |
||
| 49 | case Types.BIT: |
||
| 50 | return Boolean.class; |
||
| 51 | case Types.TINYINT: |
||
| 52 | case Types.SMALLINT: |
||
| 53 | return Short.class; |
||
| 54 | case Types.INTEGER: |
||
| 55 | return Integer.class; |
||
| 56 | case Types.BIGINT: |
||
| 57 | return Long.class; |
||
| 58 | case Types.REAL: |
||
| 59 | return Float.class; |
||
| 60 | case Types.FLOAT: |
||
| 61 | case Types.DOUBLE: |
||
| 62 | return Double.class; |
||
| 63 | case Types.DATE: |
||
| 64 | return Date.class; |
||
| 65 | case Types.TIME: |
||
| 66 | return Time.class; |
||
| 67 | case Types.TIMESTAMP: |
||
| 68 | return Timestamp.class; |
||
| 69 | case Types.BLOB: |
||
| 70 | return Blob.class; |
||
| 71 | case Types.CLOB: |
||
| 72 | return Clob.class; |
||
| 73 | case Types.ARRAY: |
||
| 74 | return Array.class; |
||
| 75 | case Types.NULL: |
||
| 76 | return null; |
||
| 77 | default: |
||
| 78 | throw new IllegalArgumentException("Unsupported or unknown type"); |
||
| 79 | } |
||
| 82 |