Arki\RequestId\Integrations\Symfony\Providers\ExtractsRequestIdFromHeader

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	9	1
A	getRequestId()	8	8	2

<?php

/*
 * This file is part of the Arki\RequestId library.
 *
 * (c) Alexandru Furculita <alex@furculita.net>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.md.
 */

namespace Arki\RequestId\Integrations\Symfony\Providers;

use Arki\RequestId\Providers\RequestIdProvider;
use Arki\RequestId\RequestId;
use Symfony\Component\HttpFoundation\Request;

final class ExtractsRequestIdFromHeader implements RequestIdProvider

This class seems to be duplicated in your project.

{
    /**
     * @var string
     */
    private $headerName;
    /**
     * @var RequestIdProvider
     */
    private $fallback;
    /**
     * @var Request
     */
    private $request;

    /**
     * @param Request           $request
     * @param string            $headerName
     * @param RequestIdProvider $fallback
     */
    public function __construct(
        Request $request,

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

        RequestIdProvider $fallback,
        $headerName = RequestId::HEADER_NAME
    ) {
        $this->headerName = $headerName;
        $this->fallback = $fallback;
        $this->request = $request;
    }

    /**
     * @return string
     */
    public function getRequestId()
    {
        if ($this->request->headers->has($this->headerName)) {
            return $this->request->headers->get($this->headerName);

The expression $this->request->headers->get($this->headerName); of type string|array adds the type array to the return on line 54 which is incompatible with the return type declared by the interface Arki\RequestId\Providers\RequestIdProvider::getRequestId of type string|null.

        }

        return $this->fallback->getRequestId();
    }
}