aristath / kirki

modules/css/field/class-kirki-output-field-image.php

<?php
/**
 * Handles CSS output for image fields.
 *
 * @package     Kirki
 * @subpackage  Controls
 * @copyright   Copyright (c) 2017, Aristeides Stathopoulos
 * @license    https://opensource.org/licenses/MIT
 * @since       3.0.10
 */

/**
 * Output overrides.
 */
class Kirki_Output_Field_Image extends Kirki_Output {

	/**
	 * Processes a single item from the `output` array.
	 *
	 * @access protected
	 * @param array $output The `output` item.
	 * @param array $value  The field's value.
	 */
	protected function process_output( $output, $value ) {
		if ( ! isset( $output['element'] ) || ! isset( $output['property'] ) ) {
			return;
		}
		$output = wp_parse_args(
			$output, array(

For multi-line function calls, each argument should be on a separate line.

				'media_query' => 'global',
				'prefix'      => '',
				'units'       => '',
				'suffix'      => '',
			)
		);
		if ( is_array( $value ) ) {

The condition is_array($value) is always true.

			if ( isset( $output['choice'] ) && $output['choice'] ) {
				$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = $output['prefix'] . $this->process_property_value( $output['property'], $value[ $output['choice'] ] ) . $output['units'] . $output['suffix'];

Are you sure $this->process_property_value($output['property'], $value[$output['choice']]) of type array can be used in concatenation?

				return;
			}
			if ( isset( $value['url'] ) ) {
				$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = $output['prefix'] . $this->process_property_value( $output['property'], $value['url'] ) . $output['units'] . $output['suffix'];

Are you sure $this->process_property_value($output['property'], $value['url']) of type array can be used in concatenation?

				return;
			}
			return;
		}
		$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = $output['prefix'] . $this->process_property_value( $output['property'], $value ) . $output['units'] . $output['suffix'];
	}
}