Completed
Pull Request — develop (#1433)
by
unknown
02:52
created
modules/customizer-styling/class-kirki-modules-customizer-styling.php 1 patch
Spacing   +11 added lines, -22 removed lines patch added patch discarded remove patch
@@ -75,43 +75,32 @@
 block discarded – undo
75 75
 		$back_obj = ( $back ) ? ariColor::newColor( $back ) : false;
76 76
 		if ( $back ) {
77 77
 			$text_on_back = ( 60 > $back_obj->lightness ) ?
78
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 60 )->toCSS( $back_obj->mode ) :
79
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 60 )->toCSS( $back_obj->mode );
78
+				$back_obj->getNew( 'lightness', $back_obj->lightness + 60 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness - 60 )->toCSS( $back_obj->mode );
80 79
 			$border_on_back = ( 80 < $back_obj->lightness ) ?
81
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 13 )->toCSS( $back_obj->mode ) :
82
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 13 )->toCSS( $back_obj->mode );
80
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 13 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 13 )->toCSS( $back_obj->mode );
83 81
 			$back_on_back = ( 90 < $back_obj->lightness ) ?
84
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 6 )->toCSS( $back_obj->mode ) :
85
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 11 )->toCSS( $back_obj->mode );
82
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 6 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 11 )->toCSS( $back_obj->mode );
86 83
 			$hover_on_back = ( 90 < $back_obj->lightness ) ?
87
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 3 )->toCSS( $back_obj->mode ) :
88
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 3 )->toCSS( $back_obj->mode );
84
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 3 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 3 )->toCSS( $back_obj->mode );
89 85
 			$arrows_on_back = ( 50 > $back_obj->lightness ) ?
90
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 30 )->toCSS( $back_obj->mode ) :
91
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 30 )->toCSS( $back_obj->mode );
86
+				$back_obj->getNew( 'lightness', $back_obj->lightness + 30 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness - 30 )->toCSS( $back_obj->mode );
92 87
 			$back_disabled_obj = ( 35 < $back_obj->lightness ) ?
93
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 30 ) :
94
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 30 );
88
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 30 ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 30 );
95 89
 		}
96 90
 		$accent     = ( isset( $config['color_accent'] ) ) ? $config['color_accent'] : false;
97 91
 		$accent_obj = ( $accent ) ? ariColor::newColor( $accent ) : false;
98 92
 		if ( $accent ) {
99 93
 			$text_on_accent = ( 60 > $accent_obj->lightness ) ?
100
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 60 )->toCSS( $accent_obj->mode ) :
101
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 60 )->toCSS( $accent_obj->mode );
94
+				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 60 )->toCSS( $accent_obj->mode ) : $accent_obj->getNew( 'lightness', $accent_obj->lightness - 60 )->toCSS( $accent_obj->mode );
102 95
 			$border_on_accent = ( 50 < $accent_obj->lightness ) ?
103
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 4 )->toCSS( $accent_obj->mode ) :
104
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 4 )->toCSS( $accent_obj->mode );
96
+				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 4 )->toCSS( $accent_obj->mode ) : $accent_obj->getNew( 'lightness', $accent_obj->lightness + 4 )->toCSS( $accent_obj->mode );
105 97
 			$accent_disabled_obj = ( 35 < $accent_obj->lightness ) ?
106
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 30 ) :
107
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 30 );
98
+				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 30 ) : $accent_obj->getNew( 'lightness', $accent_obj->lightness + 30 );
108 99
 			$accent_disabled = $accent_disabled_obj->toCSS( $accent_disabled_obj->mode );
109 100
 			$text_on_accent_disabled = ( 60 > $accent_disabled_obj->lightness ) ?
110
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 60 )->toCSS( $accent_disabled_obj->mode ) :
111
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 60 )->toCSS( $accent_disabled_obj->mode );
101
+				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 60 )->toCSS( $accent_disabled_obj->mode ) : $accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 60 )->toCSS( $accent_disabled_obj->mode );
112 102
 			$border_on_accent_disabled = ( 50 < $accent_disabled_obj->lightness ) ?
113
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 4 )->toCSS( $accent_disabled_obj->mode ) :
114
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 4 )->toCSS( $accent_disabled_obj->mode );
103
+				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 4 )->toCSS( $accent_disabled_obj->mode ) : $accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 4 )->toCSS( $accent_disabled_obj->mode );
115 104
 		}
116 105
 
117 106
 		if ( $back ) {
Please login to merge, or discard this patch.
modules/css/field/class-kirki-output-field-typography.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
44 44
 		);
45 45
 
46 46
 		foreach ( $properties as $property ) {
47
-			if ( ! isset( $value[ $property ] ) || ! $value[ $property ] ) {
47
+			if ( ! isset( $value[$property] ) || ! $value[$property] ) {
48 48
 				continue;
49 49
 			}
50 50
 			if ( isset( $output['choice'] ) && $output['choice'] !== $property ) {
51 51
 				continue;
52 52
 			}
53 53
 
54
-			$property_value = $this->process_property_value( $property, $value[ $property ] );
54
+			$property_value = $this->process_property_value( $property, $value[$property] );
55 55
 			if ( 'font-family' === $property ) {
56 56
 				$value['font-backup'] = ( isset( $value['font-backup'] ) ) ? $value['font-backup'] : '';
57 57
 				$property_value = $this->process_property_value( $property, array(
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 				) );
61 61
 			}
62 62
 			$property_value = ( is_array( $property_value ) && isset( $property_value[0] ) ) ? $property_value[0] : $property_value;
63
-			$this->styles[ $output['media_query'] ][ $output['element'] ][ $property ] = $output['prefix'] . $property_value . $output['suffix'];
63
+			$this->styles[$output['media_query']][$output['element']][$property] = $output['prefix'] . $property_value . $output['suffix'];
64 64
 		}
65 65
 	}
66 66
 }
Please login to merge, or discard this patch.
modules/webfonts/class-kirki-fonts-google.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -141,11 +141,11 @@  discard block
 block discarded – undo
141 141
 			}
142 142
 
143 143
 			// Add the requested google-font.
144
-			if ( ! isset( $this->fonts[ $value['font-family'] ] ) ) {
145
-				$this->fonts[ $value['font-family'] ] = array();
144
+			if ( ! isset( $this->fonts[$value['font-family']] ) ) {
145
+				$this->fonts[$value['font-family']] = array();
146 146
 			}
147
-			if ( ! in_array( $value['variant'], $this->fonts[ $value['font-family'] ], true ) ) {
148
-				$this->fonts[ $value['font-family'] ][] = $value['variant'];
147
+			if ( ! in_array( $value['variant'], $this->fonts[$value['font-family']], true ) ) {
148
+				$this->fonts[$value['font-family']][] = $value['variant'];
149 149
 			}
150 150
 			// Are we force-loading all variants?
151 151
 			if ( true === self::$force_load_all_variants ) {
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 
156 156
 			if ( ! empty( $args['choices']['variant'] ) ) {
157 157
 				foreach ( $args['choices']['variant'] as $extra_variant ) {
158
-					$this->fonts[ $value['font-family'] ][] = $extra_variant;
158
+					$this->fonts[$value['font-family']][] = $extra_variant;
159 159
 				}
160 160
 			}
161 161
 		} else {
@@ -175,12 +175,12 @@  discard block
 block discarded – undo
175 175
 					if ( is_string( $value ) ) {
176 176
 						if ( 'font-family' === $output['property'] ) {
177 177
 							if ( ! array_key_exists( $value, $this->fonts ) ) {
178
-								$this->fonts[ $value ] = array();
178
+								$this->fonts[$value] = array();
179 179
 							}
180 180
 						} elseif ( 'font-weight' === $output['property'] ) {
181 181
 							foreach ( $this->fonts as $font => $variants ) {
182 182
 								if ( ! in_array( $value, $variants, true ) ) {
183
-									$this->fonts[ $font ][] = $value;
183
+									$this->fonts[$font][] = $value;
184 184
 								}
185 185
 							}
186 186
 						} elseif ( 'font-subset' === $output['property'] || 'subset' === $output['property'] || 'subsets' === $output['property'] ) {
@@ -220,31 +220,31 @@  discard block
 block discarded – undo
220 220
 			// Determine if this is indeed a google font or not.
221 221
 			// If it's not, then just remove it from the array.
222 222
 			if ( ! array_key_exists( $font, $this->google_fonts ) ) {
223
-				unset( $this->fonts[ $font ] );
223
+				unset( $this->fonts[$font] );
224 224
 				continue;
225 225
 			}
226 226
 
227 227
 			// Get all valid font variants for this font.
228 228
 			$font_variants = array();
229
-			if ( isset( $this->google_fonts[ $font ]['variants'] ) ) {
230
-				$font_variants = $this->google_fonts[ $font ]['variants'];
229
+			if ( isset( $this->google_fonts[$font]['variants'] ) ) {
230
+				$font_variants = $this->google_fonts[$font]['variants'];
231 231
 			}
232 232
 			foreach ( $variants as $variant ) {
233 233
 
234 234
 				// If this is not a valid variant for this font-family
235 235
 				// then unset it and move on to the next one.
236 236
 				if ( ! in_array( $variant, $font_variants, true ) ) {
237
-					$variant_key = array_search( $variant, $this->fonts[ $font ], true );
238
-					unset( $this->fonts[ $font ][ $variant_key ] );
237
+					$variant_key = array_search( $variant, $this->fonts[$font], true );
238
+					unset( $this->fonts[$font][$variant_key] );
239 239
 					continue;
240 240
 				}
241 241
 			}
242 242
 
243 243
 			// Check if the selected subsets exist, even in one of the selected fonts.
244 244
 			// If they don't, then they have to be removed otherwise the link will fail.
245
-			if ( isset( $this->google_fonts[ $font ]['subsets'] ) ) {
245
+			if ( isset( $this->google_fonts[$font]['subsets'] ) ) {
246 246
 				foreach ( $this->subsets as $subset ) {
247
-					if ( in_array( $subset, $this->google_fonts[ $font ]['subsets'], true ) ) {
247
+					if ( in_array( $subset, $this->google_fonts[$font]['subsets'], true ) ) {
248 248
 						$valid_subsets[] = $subset;
249 249
 					}
250 250
 				}
Please login to merge, or discard this patch.
modules/webfonts/class-kirki-modules-webfonts-link.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,8 +122,8 @@
 block discarded – undo
122 122
 		// Are we force-loading all subsets?
123 123
 		if ( true === Kirki_Fonts_Google::$force_load_all_subsets ) {
124 124
 
125
-			if ( isset( $this->google_fonts[ $font ]['subsets'] ) ) {
126
-				foreach ( $this->google_fonts[ $font ]['subsets'] as $subset ) {
125
+			if ( isset( $this->google_fonts[$font]['subsets'] ) ) {
126
+				foreach ( $this->google_fonts[$font]['subsets'] as $subset ) {
127 127
 					$this->subsets[] = $subset;
128 128
 				}
129 129
 			}
Please login to merge, or discard this patch.
controls/typography/class-kirki-control-typography.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -176,8 +176,8 @@  discard block
 block discarded – undo
176 176
 
177 177
 		// Fix for https://github.com/aristath/kirki/issues/1405.
178 178
 		foreach ( $this->json['value'] as $key => $val ) {
179
-			if ( isset( $this->json['default'][ $key ] ) && false === $this->json['default'][ $key ] ) {
180
-				unset( $this->json['value'][ $key ] );
179
+			if ( isset( $this->json['default'][$key] ) && false === $this->json['default'][$key] ) {
180
+				unset( $this->json['value'][$key] );
181 181
 			}
182 182
 		}
183 183
 		$this->json['show_variants'] = ( true === Kirki_Fonts_Google::$force_load_all_variants ) ? false : true;
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 			if ( is_string( $variant ) ) {
362 362
 				$final_variants[] = array(
363 363
 					'id'    => $variant,
364
-					'label' => isset( $all_variants[ $variant ] ) ? $all_variants[ $variant ] : $variant,
364
+					'label' => isset( $all_variants[$variant] ) ? $all_variants[$variant] : $variant,
365 365
 				);
366 366
 			} elseif ( is_array( $variant ) && isset( $variant['id'] ) && isset( $variant['label'] ) ) {
367 367
 				$final_variants[] = $variant;
@@ -436,7 +436,7 @@  discard block
 block discarded – undo
436 436
 					if ( array_key_exists( $variant, $all_variants ) ) {
437 437
 						$available_variants[] = array(
438 438
 							'id' => $variant,
439
-							'label' => $all_variants[ $variant ],
439
+							'label' => $all_variants[$variant],
440 440
 						);
441 441
 					}
442 442
 				}
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
 					if ( array_key_exists( $subset, $all_subsets ) ) {
449 449
 						$available_subsets[] = array(
450 450
 							'id' => $subset,
451
-							'label' => $all_subsets[ $subset ],
451
+							'label' => $all_subsets[$subset],
452 452
 						);
453 453
 					}
454 454
 				}
Please login to merge, or discard this patch.
core/class-kirki-modules.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 			if ( class_exists( $module_class ) ) {
88 88
 				// Use this syntax instead of $module_class::get_instance()
89 89
 				// for PHP 5.2 compatibility.
90
-				self::$active_modules[ $key ] = call_user_func( array( $module_class, 'get_instance' ) );
90
+				self::$active_modules[$key] = call_user_func( array( $module_class, 'get_instance' ) );
91 91
 			}
92 92
 		}
93 93
 	}
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
 		$key = array_search( $module, self::$modules, true );
122 122
 		if ( false !== $key ) {
123
-			unset( self::$modules[ $key ] );
123
+			unset( self::$modules[$key] );
124 124
 		}
125 125
 	}
126 126
 
Please login to merge, or discard this patch.
core/class-kirki-field.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -331,14 +331,14 @@  discard block
 block discarded – undo
331 331
 
332 332
 		// Get the config arguments, and merge them with the defaults.
333 333
 		$config_defaults = ( isset( Kirki::$config['global'] ) ) ? Kirki::$config['global'] : array();
334
-		if ( 'global' !== $this->kirki_config && isset( Kirki::$config[ $this->kirki_config ] ) ) {
335
-			$config_defaults = Kirki::$config[ $this->kirki_config ];
334
+		if ( 'global' !== $this->kirki_config && isset( Kirki::$config[$this->kirki_config] ) ) {
335
+			$config_defaults = Kirki::$config[$this->kirki_config];
336 336
 		}
337 337
 		$config_defaults = ( is_array( $config_defaults ) ) ? $config_defaults : array();
338 338
 		foreach ( $config_defaults as $key => $value ) {
339
-			if ( isset( $defaults[ $key ] ) ) {
340
-				if ( ! empty( $value ) && $value != $defaults[ $key ] ) {
341
-					$defaults[ $key ] = $value;
339
+			if ( isset( $defaults[$key] ) ) {
340
+				if ( ! empty( $value ) && $value != $defaults[$key] ) {
341
+					$defaults[$key] = $value;
342 342
 				}
343 343
 			}
344 344
 		}
@@ -376,8 +376,8 @@  discard block
 block discarded – undo
376 376
 		// Remove any whitelisted properties from above.
377 377
 		// These will get a free pass, completely unfiltered.
378 378
 		foreach ( $whitelisted_properties as $key => $default_value ) {
379
-			if ( isset( $properties[ $key ] ) ) {
380
-				unset( $properties[ $key ] );
379
+			if ( isset( $properties[$key] ) ) {
380
+				unset( $properties[$key] );
381 381
 			}
382 382
 		}
383 383
 
@@ -409,7 +409,7 @@  discard block
 block discarded – undo
409 409
 		// Get all arguments with their values.
410 410
 		$args = get_object_vars( $this );
411 411
 		foreach ( $args as $key => $default_value ) {
412
-			$args[ $key ] = $this->$key;
412
+			$args[$key] = $this->$key;
413 413
 		}
414 414
 
415 415
 		// Add the whitelisted properties through the back door.
@@ -417,11 +417,11 @@  discard block
 block discarded – undo
417 417
 			if ( ! isset( $this->$key ) ) {
418 418
 				$this->$key = $default_value;
419 419
 			}
420
-			$args[ $key ] = $this->$key;
420
+			$args[$key] = $this->$key;
421 421
 		}
422 422
 
423 423
 		// Add the field to the static $fields variable properly indexed.
424
-		Kirki::$fields[ $this->settings ] = $args;
424
+		Kirki::$fields[$this->settings] = $args;
425 425
 
426 426
 	}
427 427
 
@@ -524,7 +524,7 @@  discard block
 block discarded – undo
524 524
 		}
525 525
 		foreach ( $this->partial_refresh as $id => $args ) {
526 526
 			if ( ! is_array( $args ) || ! isset( $args['selector'] ) || ! isset( $args['render_callback'] ) || ! is_callable( $args['render_callback'] ) ) {
527
-				unset( $this->partial_refresh[ $id ] );
527
+				unset( $this->partial_refresh[$id] );
528 528
 				continue;
529 529
 			}
530 530
 		}
@@ -552,10 +552,10 @@  discard block
 block discarded – undo
552 552
 		}
553 553
 		$settings = array();
554 554
 		foreach ( $this->settings as $setting_key => $setting_value ) {
555
-			$settings[ sanitize_key( $setting_key ) ] = esc_attr( $setting_value );
555
+			$settings[sanitize_key( $setting_key )] = esc_attr( $setting_value );
556 556
 			// If we're using serialized options then we need to spice this up.
557 557
 			if ( 'option' === $this->option_type && '' !== $this->option_name && ( false === strpos( $setting_key, '[' ) ) ) {
558
-				$settings[ sanitize_key( $setting_key ) ] = esc_attr( $this->option_name ) . '[' . esc_attr( $setting_value ) . ']';
558
+				$settings[sanitize_key( $setting_key )] = esc_attr( $this->option_name ) . '[' . esc_attr( $setting_value ) . ']';
559 559
 			}
560 560
 		}
561 561
 		$this->settings = $settings;
@@ -652,7 +652,7 @@  discard block
 block discarded – undo
652 652
 		);
653 653
 
654 654
 		if ( array_key_exists( $this->type, $default_callbacks ) ) {
655
-			$this->sanitize_callback = $default_callbacks[ $this->type ];
655
+			$this->sanitize_callback = $default_callbacks[$this->type];
656 656
 		}
657 657
 
658 658
 	}
Please login to merge, or discard this patch.