aristath /
kirki
| Conditions | 28 |
| Paths | 17 |
| Total Lines | 65 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 5 | ||
| Bugs | 4 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like kirkiDependencies.evaluate often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | var kirkiDependencies = { |
||
| 141 | evaluate: function( value1, value2, operator ) { |
||
| 142 | var found = false; |
||
| 143 | |||
| 144 | if ( '===' === operator ) { |
||
| 145 | return value1 === value2; |
||
| 146 | } |
||
| 147 | if ( '==' === operator || '=' === operator || 'equals' === operator || 'equal' === operator ) { |
||
| 148 | return value1 == value2; |
||
| 149 | } |
||
| 150 | if ( '!==' === operator ) { |
||
| 151 | return value1 !== value2; |
||
| 152 | } |
||
| 153 | if ( '!=' === operator || 'not equal' === operator ) { |
||
| 154 | return value1 != value2; |
||
| 155 | } |
||
| 156 | if ( '>=' === operator || 'greater or equal' === operator || 'equal or greater' === operator ) { |
||
| 157 | return value2 >= value1; |
||
| 158 | } |
||
| 159 | if ( '<=' === operator || 'smaller or equal' === operator || 'equal or smaller' === operator ) { |
||
| 160 | return value2 <= value1; |
||
| 161 | } |
||
| 162 | if ( '>' === operator || 'greater' === operator ) { |
||
| 163 | return value2 > value1; |
||
| 164 | } |
||
| 165 | if ( '<' === operator || 'smaller' === operator ) { |
||
| 166 | return value2 < value1; |
||
| 167 | } |
||
| 168 | if ( 'contains' === operator || 'in' === operator ) { |
||
| 169 | if ( _.isArray( value1 ) && _.isArray( value2 ) ) { |
||
| 170 | _.each( value2, function( value ) { |
||
| 171 | if ( value1.includes( value ) ) { |
||
| 172 | found = true; |
||
| 173 | return false; |
||
| 174 | } |
||
| 175 | } ); |
||
| 176 | return found; |
||
| 177 | } |
||
| 178 | if ( _.isArray( value2 ) ) { |
||
| 179 | _.each( value2, function( value ) { |
||
| 180 | if ( value == value1 ) { // jshint ignore:line |
||
| 181 | found = true; |
||
| 182 | } |
||
| 183 | } ); |
||
| 184 | return found; |
||
| 185 | } |
||
| 186 | if ( _.isObject( value2 ) ) { |
||
| 187 | if ( ! _.isUndefined( value2[ value1 ] ) ) { |
||
| 188 | found = true; |
||
| 189 | } |
||
| 190 | _.each( value2, function( subValue ) { |
||
| 191 | if ( value1 === subValue ) { |
||
| 192 | found = true; |
||
| 193 | } |
||
| 194 | } ); |
||
| 195 | return found; |
||
| 196 | } |
||
| 197 | if ( _.isString( value2 ) ) { |
||
| 198 | if ( _.isString( value1 ) ) { |
||
| 199 | return ( -1 < value1.indexOf( value2 ) && -1 < value2.indexOf( value1 ) ); |
||
| 200 | } |
||
| 201 | return -1 < value1.indexOf( value2 ); |
||
| 202 | } |
||
| 203 | } |
||
| 204 | return value1 == value2; |
||
| 205 | } |
||
| 206 | }; |
||
| 211 |
Loading history...
Since ECMAScript 6, you can create block-scoped vars or constants with the keywords
letorconst. These variables/constants are only valid in the code block where they have been declared.Consider the following two pieces of code:
and
The variable is not defined otuside of its block. This limits bleeding of variables into other contexts.
To know more about this ECMA6 feature, look at the MDN pages on let and const.