modules/field-dependencies/field-dependencies.js - Code Metrics - Inspection of "Merge pull request #1655 from rinkuyadav999/master" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Retried Inspection

Pull Request — master (#1653)

by Aristeides

created 2017-12-05 18:39 UTC

modules/field-dependencies/field-dependencies.js B

↳ Parent: Project

Complexity

Total Complexity	48
Complexity/F	3.43

Size

Lines of Code	139
Function Count	14

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	0
c	1
b	1
f	0
nc	1
dl	0
loc	139
rs	8.4864
wmc	48
mnd	12
bc	35
fnc	14
bpm	2.5
cpm	3.4285
noi	9

4 Functions

Rating	Name	Size	Complexity
B	kirkiDependencies.init	30	1
B	kirkiDependencies.showKirkiControl	32	5
C	kirkiDependencies.evaluate	50	26
A	$(document).ready	3	1

How to fix Complexity

var kirkiDependencies = {
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

	listenTo: {},

	init: function() {
		var self = this;
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

		wp.customize.control.each( function( control ) {
			self.showKirkiControl( control );
		} );

		_.each( self.listenTo, function( slaves, master ) {
			_.each( slaves, function( slave ) {
				wp.customize( master, function( setting ) {
				    var setupControl = function( control ) {
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
				        var setActiveState,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
						    isDisplayed;

						isDisplayed = function() {
							return self.showKirkiControl( wp.customize.control( slave ) );
						};
						setActiveState = function() {
							control.active.set( isDisplayed() );
						};

						setActiveState();
						setting.bind( setActiveState );
						control.active.validate = isDisplayed;
				    };
				    wp.customize.control( slave, setupControl );
				} );
			});
		});
	},

	/**
	 * Should we show the control?
	 *
	 * @since 3.0.17
	 * @param {string|object} control - The control-id or the control object.
	 * @returns {bool}
	 */
	showKirkiControl: function( control ) {
		var self = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
		    show = true;

		if ( _.isString( control ) ) {
			control = wp.customize.control( control );

		}

		// Exit early if control not found or if "required" argument is not defined.
		if ( 'undefined' === typeof control || ( control.params && _.isEmpty( control.params.required ) ) ) {
			return true;
		}

		// Loop control requirements.
		_.each( control.params.required, function( requirement ) {
			if ( 'undefined' === typeof wp.customize.control( requirement.setting ) ) {
				show = true;
				return;
			}
			var requirementShow = self.evaluate( requirement.value, wp.customize.control( requirement.setting ).setting._value, requirement.operator );
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

			self.listenTo[ requirement.setting ] = self.listenTo[ requirement.setting ] || [];
			if ( -1 === self.listenTo[ requirement.setting ].indexOf( control.id ) ) {
				self.listenTo[ requirement.setting ].push( control.id );
			}

			if ( ! requirementShow ) {
				show = false;
			}
		} );
		return show;
	},

	/**
	 * Figure out if the 2 values have the relation we want.
	 *
	 * @since 3.0.17
	 * @param {mixed} value1 - The 1st value.
	 * @param {mixed} value2 - The 2nd value.
	 * @param {string} operator - The comparison to use.
	 * @returns {bool}
	 */
	evaluate: function( value1, value2, operator ) {
		var found = false,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
		    result = null;

		if ( '===' === operator ) {
			result = value1 === value2;
		} else if ( '==' === operator || '=' === operator || 'equals' === operator || 'equal' === operator ) {
			result = value1 == value2; // jshint ignore:line
		} else if ( '!==' === operator ) {
			result = value1 !== value2;
		} else if ( '!=' === operator || 'not equal' === operator ) {
			result = value1 != value2; // jshint ignore:line
		} else if ( '>=' === operator || 'greater or equal' === operator || 'equal or greater' === operator ) {
			result = value2 >= value1;
		} else if ( '<=' === operator || 'smaller or equal' === operator || 'equal or smaller' === operator ) {
			result = value2 <= value1;
		} else if ( '>' === operator || 'greater' === operator ) {
			result = value2 > value1;
		} else if ( '<' === operator || 'smaller' === operator ) {
			result = value2 < value1;
		} else if ( 'contains' === operator || 'in' === operator ) {
			if ( _.isArray( value2 ) ) {
				found = false;
				_.each( value2, function( value ) {
					if ( value == value1 ) { // jshint ignore:line
						found = true;
					}
				} );
				return found;
			} else if ( _.isObject( value2 ) ) {
				found = false;
				if ( ! _.isUndefined( value2[ value1 ] ) ) {
					found = true;
				}

				_.each( value2, function( subValue ) {
					if ( value1 === subValue ) {
						found = true;
					}
				} );
				return found;
			} else if ( _.isString( value2 ) ) {
				return value1.indexOf( value2 ) > -1;
			}
		}
		if ( null === result ) {
			return true;
		}
		return result;
	}
};

jQuery( document ).ready( function() {
	kirkiDependencies.init();
} );


1			var kirkiDependencies = {
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
2
3			listenTo: {},
4
5			init: function() {
6			var self = this;
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
7
8			wp.customize.control.each( function( control ) {
9			self.showKirkiControl( control );
10			} );
11
12			_.each( self.listenTo, function( slaves, master ) {
13			_.each( slaves, function( slave ) {
14			wp.customize( master, function( setting ) {
15			var setupControl = function( control ) {
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
16			var setActiveState,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
17			isDisplayed;
18
19			isDisplayed = function() {
20			return self.showKirkiControl( wp.customize.control( slave ) );
21			};
22			setActiveState = function() {
23			control.active.set( isDisplayed() );
24			};
25
26			setActiveState();
27			setting.bind( setActiveState );
28			control.active.validate = isDisplayed;
29			};
30			wp.customize.control( slave, setupControl );
31			} );
32			});
33			});
34			},
35
36			/**
37			* Should we show the control?
38			*
39			* @since 3.0.17
40			* @param {string\|object} control - The control-id or the control object.
41			* @returns {bool}
42			*/
43			showKirkiControl: function( control ) {
44			var self = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
45			show = true;
46
47			if ( _.isString( control ) ) {
48			control = wp.customize.control( control );
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report This re-assigns to the parameter `control`. Re-assigning to parameters often makes code less readable, consider introducing a new variable instead. Loading history...
49			}
50
51			// Exit early if control not found or if "required" argument is not defined.
52			if ( 'undefined' === typeof control \|\| ( control.params && _.isEmpty( control.params.required ) ) ) {
53			return true;
54			}
55
56			// Loop control requirements.
57			_.each( control.params.required, function( requirement ) {
58			if ( 'undefined' === typeof wp.customize.control( requirement.setting ) ) {
59			show = true;
60			return;
61			}
62			var requirementShow = self.evaluate( requirement.value, wp.customize.control( requirement.setting ).setting._value, requirement.operator );
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
63
64			self.listenTo[ requirement.setting ] = self.listenTo[ requirement.setting ] \|\| [];
65			if ( -1 === self.listenTo[ requirement.setting ].indexOf( control.id ) ) {
66			self.listenTo[ requirement.setting ].push( control.id );
67			}
68
69			if ( ! requirementShow ) {
70			show = false;
71			}
72			} );
73			return show;
74			},
75
76			/**
77			* Figure out if the 2 values have the relation we want.
78			*
79			* @since 3.0.17
80			* @param {mixed} value1 - The 1st value.
81			* @param {mixed} value2 - The 2nd value.
82			* @param {string} operator - The comparison to use.
83			* @returns {bool}
84			*/
85			evaluate: function( value1, value2, operator ) {
86			var found = false,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history... Unused Code introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report The assignment to variable `found` seems to be never used. Consider removing it. Loading history...
87			result = null;
88
89			if ( '===' === operator ) {
90			result = value1 === value2;
91			} else if ( '==' === operator \|\| '=' === operator \|\| 'equals' === operator \|\| 'equal' === operator ) {
92			result = value1 == value2; // jshint ignore:line
93			} else if ( '!==' === operator ) {
94			result = value1 !== value2;
95			} else if ( '!=' === operator \|\| 'not equal' === operator ) {
96			result = value1 != value2; // jshint ignore:line
97			} else if ( '>=' === operator \|\| 'greater or equal' === operator \|\| 'equal or greater' === operator ) {
98			result = value2 >= value1;
99			} else if ( '<=' === operator \|\| 'smaller or equal' === operator \|\| 'equal or smaller' === operator ) {
100			result = value2 <= value1;
101			} else if ( '>' === operator \|\| 'greater' === operator ) {
102			result = value2 > value1;
103			} else if ( '<' === operator \|\| 'smaller' === operator ) {
104			result = value2 < value1;
105			} else if ( 'contains' === operator \|\| 'in' === operator ) {
106			if ( _.isArray( value2 ) ) {
107			found = false;
108			_.each( value2, function( value ) {
109			if ( value == value1 ) { // jshint ignore:line
110			found = true;
111			}
112			} );
113			return found;
114			} else if ( _.isObject( value2 ) ) {
115			found = false;
116			if ( ! _.isUndefined( value2[ value1 ] ) ) {
117			found = true;
118			}
119
120			_.each( value2, function( subValue ) {
121			if ( value1 === subValue ) {
122			found = true;
123			}
124			} );
125			return found;
126			} else if ( _.isString( value2 ) ) {
127			return value1.indexOf( value2 ) > -1;
128			}
129			}
130			if ( null === result ) {
131			return true;
132			}
133			return result;
134			}
135			};
136
137			jQuery( document ).ready( function() {
138			kirkiDependencies.init();
139			} );
140

aristath / kirki

Pull Request — master (#1653)

modules/field-dependencies/field-dependencies.js B

Complexity

Size

Duplication

Importance

4 Functions

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like