Kirki_Field_Number - Code Metrics - Inspection of "fixes #1240" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 9f3e22...fba03d )

by Aristeides

created 2017-04-01 10:17 UTC

Kirki_Field_Number A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	70
rs	10
c	0
b	0
f	0
wmc	16
lcom	3
cbo	1

3 Methods

Rating	Name	Size	Complexity
A	set_type()	5	1
A	set_sanitize_callback()	5	1
F	sanitize()	36	14

<?php
/**
 * Override field methods
 *
 * @package     Kirki
 * @subpackage  Controls
 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
 * @license     http://opensource.org/licenses/https://opensource.org/licenses/MIT
 * @since       2.2.7
 */

/**
 * Field overrides.
 */
class Kirki_Field_Number extends Kirki_Field {

	/**
	 * Sets the control type.
	 *
	 * @access protected
	 */
	protected function set_type() {

		$this->type = 'kirki-number';

	}

	/**
	 * Sets the $sanitize_callback
	 *
	 * @access protected
	 */
	protected function set_sanitize_callback() {

		$this->sanitize_callback = array( $this, 'sanitize' );

	}

	/**
	 * Sanitizes checkbox values.
	 *
	 * @static
	 * @access public
	 * @param boolean|integer|string|null $value The checkbox value.
	 * @return bool
	 */
	public static function sanitize( $value = null ) {

		$value = ( is_numeric( $value ) ) ? $value : intval( $value );

		// Minimum value limit.
		if ( isset( $this->choices['min'] ) ) {
			$min = ( is_numeric( $this->choices['min'] ) ) ? $this->choices['min'] : intval( $this->choices['min'] );

			if ( $value < $min ) {
				$value = $min;
			}
		}

		// Maximum value limit.
		if ( isset( $this->choices['max'] ) ) {
			$max = ( is_numeric( $this->choices['max'] ) ) ? $this->choices['max'] : intval( $this->choices['max'] );
			if ( $value > $max ) {
				$value = $max;
			}
		}

		// Step divider.
		if ( isset( $this->choices['min'] ) && isset( $this->choices['step'] ) ) {
			$min   = ( is_numeric( $this->choices['min'] ) ) ? $this->choices['min'] : intval( $this->choices['min'] );
			$max   = ( is_numeric( $this->choices['max'] ) ) ? $this->choices['max'] : intval( $this->choices['max'] );
			$step  = ( is_numeric( $this->choices['step'] ) ) ? $this->choices['step'] : intval( $this->choices['step'] );
			$valid = range( $min, $max, $step );
			foreach ( $valid as $possible_value ) {
				$smallest[ $possible_value ] = abs( $possible_value - $value );
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			}
			asort( $smallest );
			$value = key( $smallest );
		}

		return $value;

	}

}


1			<?php
2			/**
3			* Override field methods
4			*
5			* @package Kirki
6			* @subpackage Controls
7			* @copyright Copyright (c) 2016, Aristeides Stathopoulos
8			* @license http://opensource.org/licenses/https://opensource.org/licenses/MIT
9			* @since 2.2.7
10			*/
11
12			/**
13			* Field overrides.
14			*/
15			class Kirki_Field_Number extends Kirki_Field {
16
17			/**
18			* Sets the control type.
19			*
20			* @access protected
21			*/
22			protected function set_type() {
23
24			$this->type = 'kirki-number';
25
26			}
27
28			/**
29			* Sets the $sanitize_callback
30			*
31			* @access protected
32			*/
33			protected function set_sanitize_callback() {
34
35			$this->sanitize_callback = array( $this, 'sanitize' );
36
37			}
38
39			/**
40			* Sanitizes checkbox values.
41			*
42			* @static
43			* @access public
44			* @param boolean\|integer\|string\|null $value The checkbox value.
45			* @return bool
46			*/
47			public static function sanitize( $value = null ) {
48
49			$value = ( is_numeric( $value ) ) ? $value : intval( $value );
50
51			// Minimum value limit.
52			if ( isset( $this->choices['min'] ) ) {
53			$min = ( is_numeric( $this->choices['min'] ) ) ? $this->choices['min'] : intval( $this->choices['min'] );
			0 ignored issues – show Bug introduced 2017-04-01 10:19 UTC by Report Bug Copy Issue Report The variable `$this` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
54			if ( $value < $min ) {
55			$value = $min;
56			}
57			}
58
59			// Maximum value limit.
60			if ( isset( $this->choices['max'] ) ) {
61			$max = ( is_numeric( $this->choices['max'] ) ) ? $this->choices['max'] : intval( $this->choices['max'] );
62			if ( $value > $max ) {
63			$value = $max;
64			}
65			}
66
67			// Step divider.
68			if ( isset( $this->choices['min'] ) && isset( $this->choices['step'] ) ) {
69			$min = ( is_numeric( $this->choices['min'] ) ) ? $this->choices['min'] : intval( $this->choices['min'] );
70			$max = ( is_numeric( $this->choices['max'] ) ) ? $this->choices['max'] : intval( $this->choices['max'] );
71			$step = ( is_numeric( $this->choices['step'] ) ) ? $this->choices['step'] : intval( $this->choices['step'] );
72			$valid = range( $min, $max, $step );
73			foreach ( $valid as $possible_value ) {
74			$smallest[ $possible_value ] = abs( $possible_value - $value );
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-04-01 10:19 UTC by Report Bug Copy Issue Report `$smallest` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$smallest = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
75			}
76			asort( $smallest );
77			$value = key( $smallest );
78			}
79
80			return $value;
81
82			}
83
84			}
85

aristath / kirki

Push — develop ( 9f3e22...fba03d )

Kirki_Field_Number A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like