controls/js/src/dimensions.js - Code Metrics - Inspection of "3.0.17" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#1653)

by Aristeides

created 2017-12-03 15:26 UTC

controls/js/src/dimensions.js A

↳ Parent: Project

Complexity

Total Complexity	14
Complexity/F	1.4

Size

Lines of Code	91
Function Count	10

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	0
nc	1
dl	0
loc	91
rs	10
c	0
b	0
f	0
wmc	14
mnd	1
bc	15
fnc	10
bpm	1.5
cpm	1.4
noi	5

4 Functions

Rating	Name	Size	Complexity
A	wp.customize.kirkiDynamicControl.extend.saveValue	11	1
B	wp.customize.kirkiDynamicControl.extend.kirkiNotifications	32	1
A	wp.customize.kirkiDynamicControl.extend.initKirkiControl	19	2
A	wp.customize.kirkiDynamicControl.extend.updateDimensionsValue	14	1

/* global dimensionskirkiL10n */
wp.customize.controlConstructor['kirki-dimensions'] = wp.customize.kirkiDynamicControl.extend({

	initKirkiControl: function() {

		var control     = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
		    subControls = control.params.choices.controls,
		    value       = {},
		    subsArray   = [],
		    i;

		_.each( subControls, function( v, i ) {
			if ( true === v ) {
				subsArray.push( i );
			}
		} );

		for ( i = 0; i < subsArray.length; i++ ) {
			value[ subsArray[ i ] ] = control.setting._value[ subsArray[ i ] ];
			control.updateDimensionsValue( subsArray[ i ], value );
		}
	},

	/**
	 * Updates the value.
	 */
	updateDimensionsValue: function( context, value ) {

		var control = this;
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

		control.container.on( 'change keyup paste', '.' + context + ' input', function() {
			value[ context ] = jQuery( this ).val();

			// Notifications.
			control.kirkiNotifications();

			// Save the value
			control.saveValue( value );
		});
	},

	/**
	 * Saves the value.
	 */
	saveValue: function( value ) {

		var control  = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
		    newValue = {};

		_.each( value, function( newSubValue, i ) {
			newValue[ i ] = newSubValue;
		});

		control.setting.set( newValue );
	},

	/**
	 * Handles notifications.
	 */
	kirkiNotifications: function() {

		var control = this;
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

		wp.customize( control.id, function( setting ) {
			setting.bind( function( value ) {
				var code = 'long_title',
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
				    subs = {},
				    message;

				setting.notifications.remove( code );

				_.each( value, function( val, direction ) {
					if ( false === control.kirkiValidateCSSValue( val ) ) {
						subs[ direction ] = val;
					} else {
						delete subs[ direction ];
					}
				} );

				if ( ! _.isEmpty( subs ) ) {
					message = dimensionskirkiL10n['invalid-value'] + ' (' + _.values( subs ).toString() + ') ';
					setting.notifications.add( code, new wp.customize.Notification( code, {
						type: 'warning',
						message: message
					} ) );
					return;
				}
				setting.notifications.remove( code );
			} );
		} );
	}
});


1			/* global dimensionskirkiL10n */
2			wp.customize.controlConstructor['kirki-dimensions'] = wp.customize.kirkiDynamicControl.extend({
3
4			initKirkiControl: function() {
5
6			var control = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
7			subControls = control.params.choices.controls,
8			value = {},
9			subsArray = [],
10			i;
11
12			_.each( subControls, function( v, i ) {
13			if ( true === v ) {
14			subsArray.push( i );
15			}
16			} );
17
18			for ( i = 0; i < subsArray.length; i++ ) {
19			value[ subsArray[ i ] ] = control.setting._value[ subsArray[ i ] ];
20			control.updateDimensionsValue( subsArray[ i ], value );
21			}
22			},
23
24			/**
25			* Updates the value.
26			*/
27			updateDimensionsValue: function( context, value ) {
28
29			var control = this;
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
30
31			control.container.on( 'change keyup paste', '.' + context + ' input', function() {
32			value[ context ] = jQuery( this ).val();
33
34			// Notifications.
35			control.kirkiNotifications();
36
37			// Save the value
38			control.saveValue( value );
39			});
40			},
41
42			/**
43			* Saves the value.
44			*/
45			saveValue: function( value ) {
46
47			var control = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
48			newValue = {};
49
50			_.each( value, function( newSubValue, i ) {
51			newValue[ i ] = newSubValue;
52			});
53
54			control.setting.set( newValue );
55			},
56
57			/**
58			* Handles notifications.
59			*/
60			kirkiNotifications: function() {
61
62			var control = this;
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
63
64			wp.customize( control.id, function( setting ) {
65			setting.bind( function( value ) {
66			var code = 'long_title',
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
67			subs = {},
68			message;
69
70			setting.notifications.remove( code );
71
72			_.each( value, function( val, direction ) {
73			if ( false === control.kirkiValidateCSSValue( val ) ) {
74			subs[ direction ] = val;
75			} else {
76			delete subs[ direction ];
77			}
78			} );
79
80			if ( ! _.isEmpty( subs ) ) {
81			message = dimensionskirkiL10n['invalid-value'] + ' (' + _.values( subs ).toString() + ') ';
82			setting.notifications.add( code, new wp.customize.Notification( code, {
83			type: 'warning',
84			message: message
85			} ) );
86			return;
87			}
88			setting.notifications.remove( code );
89			} );
90			} );
91			}
92			});
93

aristath / kirki

Pull Request — master (#1653)

controls/js/src/dimensions.js A

Complexity

Size

Duplication

Importance

4 Functions

Duplication Side-by-Side

Filter issues like