Passed
Push — develop ( a1ce48...859234 )
by Aristeides
05:21
created
modules/css/class-kirki-modules-css.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
 
120 120
 		$config   = apply_filters( 'kirki_config', array() );
121 121
 		$priority = 999;
122
-		if ( isset( $config['styles_priority'] ) ) {
123
-			$priority = absint( $config['styles_priority'] );
122
+		if ( isset( $config[ 'styles_priority' ] ) ) {
123
+			$priority = absint( $config[ 'styles_priority' ] );
124 124
 		}
125 125
 
126 126
 		// Allow completely disabling Kirki CSS output.
127
-		if ( ( defined( 'KIRKI_NO_OUTPUT' ) && true === KIRKI_NO_OUTPUT ) || ( isset( $config['disable_output'] ) && true === $config['disable_output'] ) ) {
127
+		if ( ( defined( 'KIRKI_NO_OUTPUT' ) && true === KIRKI_NO_OUTPUT ) || ( isset( $config[ 'disable_output' ] ) && true === $config[ 'disable_output' ] ) ) {
128 128
 			return;
129 129
 		}
130 130
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 
156 156
 		// If we are in the customizer, load CSS using inline-styles.
157 157
 		// If we are in the frontend AND self::$ajax is true, then load dynamic CSS using AJAX.
158
-		if ( ( true === self::$ajax ) || ( isset( $config['inline_css'] ) && false === $config['inline_css'] ) ) {
158
+		if ( ( true === self::$ajax ) || ( isset( $config[ 'inline_css' ] ) && false === $config[ 'inline_css' ] ) ) {
159 159
 			add_action( 'wp_enqueue_scripts', array( $this, 'frontend_styles' ), $priority );
160 160
 			add_action( 'wp_ajax_kirki_dynamic_css', array( $this, 'ajax_dynamic_css' ) );
161 161
 			add_action( 'wp_ajax_nopriv_kirki_dynamic_css', array( $this, 'ajax_dynamic_css' ) );
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 		$configs = Kirki::$config;
187 187
 		if ( ! $this->processed ) {
188 188
 			foreach ( $configs as $config_id => $args ) {
189
-				if ( isset( $args['disable_output'] ) && true === $args['disable_output'] ) {
189
+				if ( isset( $args[ 'disable_output' ] ) && true === $args[ 'disable_output' ] ) {
190 190
 					continue;
191 191
 				}
192 192
 				$styles = self::loop_controls( $config_id );
@@ -243,19 +243,19 @@  discard block
 block discarded – undo
243 243
 		foreach ( $fields as $field ) {
244 244
 
245 245
 			// Only process fields that belong to $config_id.
246
-			if ( $config_id !== $field['kirki_config'] ) {
246
+			if ( $config_id !== $field[ 'kirki_config' ] ) {
247 247
 				continue;
248 248
 			}
249 249
 
250 250
 			if ( true === apply_filters( "kirki_{$config_id}_css_skip_hidden", true ) ) {
251 251
 				// Only continue if field dependencies are met.
252
-				if ( ! empty( $field['required'] ) ) {
252
+				if ( ! empty( $field[ 'required' ] ) ) {
253 253
 					$valid = true;
254 254
 
255
-					foreach ( $field['required'] as $requirement ) {
256
-						if ( isset( $requirement['setting'] ) && isset( $requirement['value'] ) && isset( $requirement['operator'] ) ) {
257
-							$controller_value = Kirki_Values::get_value( $config_id, $requirement['setting'] );
258
-							if ( ! Kirki_Helper::compare_values( $controller_value, $requirement['value'], $requirement['operator'] ) ) {
255
+					foreach ( $field[ 'required' ] as $requirement ) {
256
+						if ( isset( $requirement[ 'setting' ] ) && isset( $requirement[ 'value' ] ) && isset( $requirement[ 'operator' ] ) ) {
257
+							$controller_value = Kirki_Values::get_value( $config_id, $requirement[ 'setting' ] );
258
+							if ( ! Kirki_Helper::compare_values( $controller_value, $requirement[ 'value' ], $requirement[ 'operator' ] ) ) {
259 259
 								$valid = false;
260 260
 							}
261 261
 						}
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
 			}
269 269
 
270 270
 			// Only continue if $field['output'] is set.
271
-			if ( isset( $field['output'] ) && ! empty( $field['output'] ) ) {
271
+			if ( isset( $field[ 'output' ] ) && ! empty( $field[ 'output' ] ) ) {
272 272
 				$css = Kirki_Helper::array_replace_recursive( $css, Kirki_Modules_CSS_Generator::css( $field ) );
273 273
 
274 274
 				// Add the globals.
Please login to merge, or discard this patch.
deprecated/filters.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	$config_ids = Kirki_Config::get_config_ids();
54 54
 	global $kirki_deprecated_filters_iteration;
55 55
 	foreach ( $config_ids as $config_id ) {
56
-		foreach( array(
56
+		foreach ( array(
57 57
 			'/dynamic_css',
58 58
 			'/output/control-classnames',
59 59
 			'/css/skip_hidden',
@@ -64,15 +64,15 @@  discard block
 block discarded – undo
64 64
 			$kirki_deprecated_filters_iteration = array( $config_id, $filter_suffix );
65 65
 			add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
66 66
 				global $kirki_deprecated_filters_iteration;
67
-				$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
68
-				return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
67
+				$kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
68
+				return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[ 0 ]}/{$kirki_deprecated_filters_iteration[ 1 ]}", $args );
69 69
 			}, 99 );
70
-			if ( false !== strpos( $kirki_deprecated_filters_iteration[1], '-' ) ) {
71
-				$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
70
+			if ( false !== strpos( $kirki_deprecated_filters_iteration[ 1 ], '-' ) ) {
71
+				$kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
72 72
 				add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
73 73
 					global $kirki_deprecated_filters_iteration;
74
-					$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
75
-					return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
74
+					$kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
75
+					return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[ 0 ]}/{$kirki_deprecated_filters_iteration[ 1 ]}", $args );
76 76
 				}, 99 );
77 77
 			}
78 78
 		}
Please login to merge, or discard this patch.
field/class-kirki-field-code.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -59,10 +59,10 @@  discard block
 block discarded – undo
59 59
 	 * @access protected
60 60
 	 */
61 61
 	protected function set_choices() {
62
-		if ( ! isset( $this->choices['language'] ) ) {
62
+		if ( ! isset( $this->choices[ 'language' ] ) ) {
63 63
 			return;
64 64
 		}
65
-		$language = $this->choices['language'];
65
+		$language = $this->choices[ 'language' ];
66 66
 		switch ( $language ) {
67 67
 			case 'json':
68 68
 			case 'xml':
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
90 90
 				$language = 'text/x-' . $language;
91 91
 				break;
92 92
 		}
93
-		if ( ! isset( $this->editor_settings['codemirror'] ) ) {
94
-			$this->editor_settings['codemirror'] = array();
93
+		if ( ! isset( $this->editor_settings[ 'codemirror' ] ) ) {
94
+			$this->editor_settings[ 'codemirror' ] = array();
95 95
 		}
96
-		if ( ! isset( $this->editor_settings['codemirror']['mode'] ) ) {
97
-			$this->editor_settings['codemirror']['mode'] = $language;
96
+		if ( ! isset( $this->editor_settings[ 'codemirror' ][ 'mode' ] ) ) {
97
+			$this->editor_settings[ 'codemirror' ][ 'mode' ] = $language;
98 98
 		}
99 99
 	}
100 100
 
Please login to merge, or discard this patch.
field/class-kirki-field-image.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -60,14 +60,14 @@  discard block
 block discarded – undo
60 60
 		if ( ! is_array( $this->choices ) ) {
61 61
 			$this->choices = (array) $this->choices;
62 62
 		}
63
-		if ( ! isset( $this->choices['save_as'] ) ) {
64
-			$this->choices['save_as'] = 'url';
63
+		if ( ! isset( $this->choices[ 'save_as' ] ) ) {
64
+			$this->choices[ 'save_as' ] = 'url';
65 65
 		}
66
-		if ( ! isset( $this->choices['labels'] ) ) {
67
-			$this->choices['labels'] = array();
66
+		if ( ! isset( $this->choices[ 'labels' ] ) ) {
67
+			$this->choices[ 'labels' ] = array();
68 68
 		}
69 69
 		$this->set_button_labels();
70
-		$this->choices['labels'] = wp_parse_args( $this->choices['labels'], $this->button_labels );
70
+		$this->choices[ 'labels' ] = wp_parse_args( $this->choices[ 'labels' ], $this->button_labels );
71 71
 	}
72 72
 
73 73
 	/**
@@ -93,15 +93,15 @@  discard block
 block discarded – undo
93 93
 	 */
94 94
 	public function sanitize( $value ) {
95 95
 
96
-		if ( isset( $this->choices['save_as'] ) && 'array' === $this->choices['save_as'] ) {
96
+		if ( isset( $this->choices[ 'save_as' ] ) && 'array' === $this->choices[ 'save_as' ] ) {
97 97
 			return array(
98
-				'id'     => ( isset( $value['id'] ) && '' !== $value['id'] ) ? (int) $value['id'] : '',
99
-				'url'    => ( isset( $value['url'] ) && '' !== $value['url'] ) ? esc_url_raw( $value['url'] ) : '',
100
-				'width'  => ( isset( $value['width'] ) && '' !== $value['width'] ) ? (int) $value['width'] : '',
101
-				'height' => ( isset( $value['height'] ) && '' !== $value['height'] ) ? (int) $value['height'] : '',
98
+				'id'     => ( isset( $value[ 'id' ] ) && '' !== $value[ 'id' ] ) ? (int) $value[ 'id' ] : '',
99
+				'url'    => ( isset( $value[ 'url' ] ) && '' !== $value[ 'url' ] ) ? esc_url_raw( $value[ 'url' ] ) : '',
100
+				'width'  => ( isset( $value[ 'width' ] ) && '' !== $value[ 'width' ] ) ? (int) $value[ 'width' ] : '',
101
+				'height' => ( isset( $value[ 'height' ] ) && '' !== $value[ 'height' ] ) ? (int) $value[ 'height' ] : '',
102 102
 			);
103 103
 		}
104
-		if ( isset( $this->choices['save_as'] ) && 'id' === $this->choices['save_as'] ) {
104
+		if ( isset( $this->choices[ 'save_as' ] ) && 'id' === $this->choices[ 'save_as' ] ) {
105 105
 			return absint( $value );
106 106
 		}
107 107
 		if ( is_string( $value ) ) {
Please login to merge, or discard this patch.
controls/php/class-kirki-control-upload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,6 +32,6 @@
 block discarded – undo
32 32
 	 */
33 33
 	public function to_json() {
34 34
 		parent::to_json();
35
-		$this->json['required'] = $this->required;
35
+		$this->json[ 'required' ] = $this->required;
36 36
 	}
37 37
 }
Please login to merge, or discard this patch.
controls/php/class-kirki-control-cropped-image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,6 +32,6 @@
 block discarded – undo
32 32
 	 */
33 33
 	public function to_json() {
34 34
 		parent::to_json();
35
-		$this->json['required'] = $this->required;
35
+		$this->json[ 'required' ] = $this->required;
36 36
 	}
37 37
 }
Please login to merge, or discard this patch.
controls/php/class-kirki-control-typography.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -35,23 +35,23 @@  discard block
 block discarded – undo
35 35
 	public function to_json() {
36 36
 		parent::to_json();
37 37
 
38
-		if ( is_array( $this->json['value'] ) ) {
39
-			foreach ( array_keys( $this->json['value'] ) as $key ) {
40
-				if ( ! in_array( $key, array( 'variant', 'font-weight', 'font-style' ), true ) && ! isset( $this->json['default'][ $key ] ) ) {
41
-					unset( $this->json['value'][ $key ] );
38
+		if ( is_array( $this->json[ 'value' ] ) ) {
39
+			foreach ( array_keys( $this->json[ 'value' ] ) as $key ) {
40
+				if ( ! in_array( $key, array( 'variant', 'font-weight', 'font-style' ), true ) && ! isset( $this->json[ 'default' ][ $key ] ) ) {
41
+					unset( $this->json[ 'value' ][ $key ] );
42 42
 				}
43 43
 				// Fix for https://wordpress.org/support/topic/white-font-after-updateing-to-3-0-16.
44
-				if ( ! isset( $this->json['default'][ $key ] ) ) {
45
-					unset( $this->json['value'][ $key ] );
44
+				if ( ! isset( $this->json[ 'default' ][ $key ] ) ) {
45
+					unset( $this->json[ 'value' ][ $key ] );
46 46
 				}
47 47
 				// Fix for https://github.com/aristath/kirki/issues/1405.
48
-				if ( isset( $this->json['default'][ $key ] ) && false === $this->json['default'][ $key ] ) {
49
-					unset( $this->json['value'][ $key ] );
48
+				if ( isset( $this->json[ 'default' ][ $key ] ) && false === $this->json[ 'default' ][ $key ] ) {
49
+					unset( $this->json[ 'value' ][ $key ] );
50 50
 				}
51 51
 			}
52 52
 		}
53 53
 
54
-		$this->json['show_variants'] = ( true === Kirki_Fonts_Google::$force_load_all_variants ) ? false : true;
54
+		$this->json[ 'show_variants' ] = ( true === Kirki_Fonts_Google::$force_load_all_variants ) ? false : true;
55 55
 	}
56 56
 
57 57
 	/**
@@ -238,12 +238,12 @@  discard block
 block discarded – undo
238 238
 		$final_variants = array();
239 239
 		foreach ( $variants as $variant ) {
240 240
 			if ( is_string( $variant ) ) {
241
-				$final_variants[] = array(
241
+				$final_variants[ ] = array(
242 242
 					'id'    => $variant,
243 243
 					'label' => isset( $all_variants[ $variant ] ) ? $all_variants[ $variant ] : $variant,
244 244
 				);
245
-			} elseif ( is_array( $variant ) && isset( $variant['id'] ) && isset( $variant['label'] ) ) {
246
-				$final_variants[] = $variant;
245
+			} elseif ( is_array( $variant ) && isset( $variant[ 'id' ] ) && isset( $variant[ 'label' ] ) ) {
246
+				$final_variants[ ] = $variant;
247 247
 			}
248 248
 		}
249 249
 		return $final_variants;
Please login to merge, or discard this patch.
modules/webfonts/class-kirki-fonts.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -137,11 +137,11 @@
 block discarded – undo
137 137
 
138 138
 		$google_fonts = array();
139 139
 		if ( is_array( $fonts ) ) {
140
-			foreach ( $fonts['items'] as $font ) {
141
-				$google_fonts[ $font['family'] ] = array(
142
-					'label'    => $font['family'],
143
-					'variants' => $font['variants'],
144
-					'category' => $font['category'],
140
+			foreach ( $fonts[ 'items' ] as $font ) {
141
+				$google_fonts[ $font[ 'family' ] ] = array(
142
+					'label'    => $font[ 'family' ],
143
+					'variants' => $font[ 'variants' ],
144
+					'category' => $font[ 'category' ],
145 145
 				);
146 146
 			}
147 147
 		}
Please login to merge, or discard this patch.
modules/postmessage/class-kirki-modules-postmessage.php 1 patch
Spacing   +87 added lines, -87 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
 		wp_enqueue_script( 'kirki_auto_postmessage', trailingslashit( Kirki::$url ) . 'modules/postmessage/postmessage.js', array( 'jquery', 'customize-preview' ), KIRKI_VERSION, true );
75 75
 		$fields = Kirki::$fields;
76 76
 		foreach ( $fields as $field ) {
77
-			if ( isset( $field['transport'] ) && 'postMessage' === $field['transport'] && isset( $field['js_vars'] ) && ! empty( $field['js_vars'] ) && is_array( $field['js_vars'] ) && isset( $field['settings'] ) ) {
77
+			if ( isset( $field[ 'transport' ] ) && 'postMessage' === $field[ 'transport' ] && isset( $field[ 'js_vars' ] ) && ! empty( $field[ 'js_vars' ] ) && is_array( $field[ 'js_vars' ] ) && isset( $field[ 'settings' ] ) ) {
78 78
 				$this->script .= $this->script( $field );
79 79
 			}
80 80
 		}
@@ -92,11 +92,11 @@  discard block
 block discarded – undo
92 92
 	 */
93 93
 	protected function script( $args ) {
94 94
 
95
-		$script = 'wp.customize(\'' . $args['settings'] . '\',function(value){value.bind(function(newval){';
95
+		$script = 'wp.customize(\'' . $args[ 'settings' ] . '\',function(value){value.bind(function(newval){';
96 96
 
97 97
 		$add_css = false;
98
-		foreach ( $args['js_vars'] as $js_var ) {
99
-			if ( ! isset( $js_var['function'] ) || 'html' !== $js_var['function'] ) {
98
+		foreach ( $args[ 'js_vars' ] as $js_var ) {
99
+			if ( ! isset( $js_var[ 'function' ] ) || 'html' !== $js_var[ 'function' ] ) {
100 100
 				$add_css = true;
101 101
 			}
102 102
 		}
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
 			// append unique style tag if not exist
107 107
 			// The style ID.
108
-			$style_id = 'kirki-postmessage-' . str_replace( array( '[', ']' ), '', $args['settings'] );
108
+			$style_id = 'kirki-postmessage-' . str_replace( array( '[', ']' ), '', $args[ 'settings' ] );
109 109
 			$script  .= 'if(null===document.getElementById(\'' . $style_id . '\')||\'undefined\'===typeof document.getElementById(\'' . $style_id . '\')){jQuery(\'head\').append(\'<style id="' . $style_id . '"></style>\');}';
110 110
 		}
111 111
 
@@ -116,46 +116,46 @@  discard block
 block discarded – undo
116 116
 			'scripts' => array(),
117 117
 		);
118 118
 		// Loop through the js_vars and generate the script.
119
-		foreach ( $args['js_vars'] as $key => $js_var ) {
119
+		foreach ( $args[ 'js_vars' ] as $key => $js_var ) {
120 120
 
121 121
 			// Skip styles if "exclude" is defined and value is excluded.
122
-			if ( isset( $js_var['exclude'] ) ) {
123
-				$js_var['exclude'] = (array) $js_var['exclude'];
122
+			if ( isset( $js_var[ 'exclude' ] ) ) {
123
+				$js_var[ 'exclude' ] = (array) $js_var[ 'exclude' ];
124 124
 				$script           .= 'exclude=false;';
125
-				foreach ( $js_var['exclude'] as $exclussion ) {
125
+				foreach ( $js_var[ 'exclude' ] as $exclussion ) {
126 126
 					$script .= "if(newval=='{$exclussion}'||(''==='{$exclussion}'&&_.isObject(newval)&&_.isEmpty(newval))){exclude=true;}";
127 127
 				}
128 128
 			}
129
-			if ( isset( $js_var['element'] ) ) {
129
+			if ( isset( $js_var[ 'element' ] ) ) {
130 130
 				// Array to string.
131
-				if ( is_array( $js_var['element'] ) ) {
132
-					$js_var['element'] = implode( ',', $js_var['element'] );
131
+				if ( is_array( $js_var[ 'element' ] ) ) {
132
+					$js_var[ 'element' ] = implode( ',', $js_var[ 'element' ] );
133 133
 				}
134 134
 				// Replace single quotes with double quotes to avoid issues with the compiled JS.
135
-				$js_var['element'] = str_replace( '\'', '"', $js_var['element'] );
135
+				$js_var[ 'element' ] = str_replace( '\'', '"', $js_var[ 'element' ] );
136 136
 			}
137
-			if ( isset( $js_var['function'] ) && 'html' === $js_var['function'] ) {
137
+			if ( isset( $js_var[ 'function' ] ) && 'html' === $js_var[ 'function' ] ) {
138 138
 				$script .= $this->script_html_var( $js_var );
139 139
 				continue;
140 140
 			}
141
-			$js_var['index_key'] = $key;
141
+			$js_var[ 'index_key' ] = $key;
142 142
 			$callback            = $this->get_callback( $args );
143 143
 			if ( is_callable( $callback ) ) {
144
-				$field['scripts'][ $key ] = call_user_func_array( $callback, array( $js_var, $args ) );
144
+				$field[ 'scripts' ][ $key ] = call_user_func_array( $callback, array( $js_var, $args ) );
145 145
 				continue;
146 146
 			}
147
-			$field['scripts'][ $key ] = $this->script_var( $js_var );
147
+			$field[ 'scripts' ][ $key ] = $this->script_var( $js_var );
148 148
 		}
149 149
 		$combo_extra_script = '';
150 150
 		$combo_css_script   = '';
151
-		foreach ( $field['scripts'] as $script_array ) {
152
-			$combo_extra_script .= $script_array['script'];
153
-			$combo_css_script   .= ( 'css' !== $combo_css_script ) ? $script_array['css'] : '';
151
+		foreach ( $field[ 'scripts' ] as $script_array ) {
152
+			$combo_extra_script .= $script_array[ 'script' ];
153
+			$combo_css_script   .= ( 'css' !== $combo_css_script ) ? $script_array[ 'css' ] : '';
154 154
 		}
155 155
 		$text = ( 'css' === $combo_css_script ) ? 'css' : '\'' . $combo_css_script . '\'';
156 156
 
157 157
 		$script .= $combo_extra_script . "var cssContent={$text};";
158
-		if ( isset( $js_var['exclude'] ) ) {
158
+		if ( isset( $js_var[ 'exclude' ] ) ) {
159 159
 			$script .= 'if(true===exclude){cssContent="";}';
160 160
 		}
161 161
 		if ( $add_css ) {
@@ -174,18 +174,18 @@  discard block
 block discarded – undo
174 174
 	 */
175 175
 	protected function script_html_var( $args ) {
176 176
 
177
-		$script = ( isset( $args['choice'] ) ) ? "newval=newval['{$args['choice']}'];" : '';
177
+		$script = ( isset( $args[ 'choice' ] ) ) ? "newval=newval['{$args[ 'choice' ]}'];" : '';
178 178
 
179 179
 		// Apply the value_pattern.
180
-		if ( isset( $args['value_pattern'] ) && '' !== $args['value_pattern'] ) {
180
+		if ( isset( $args[ 'value_pattern' ] ) && '' !== $args[ 'value_pattern' ] ) {
181 181
 			$script .= $this->value_pattern_replacements( 'newval', $args );
182 182
 		}
183 183
 
184
-		if ( isset( $args['attr'] ) ) {
185
-			$script .= "jQuery('{$args['element']}').attr('{$args['attr']}',newval);";
184
+		if ( isset( $args[ 'attr' ] ) ) {
185
+			$script .= "jQuery('{$args[ 'element' ]}').attr('{$args[ 'attr' ]}',newval);";
186 186
 			return $script;
187 187
 		}
188
-		$script .= "jQuery('{$args['element']}').html(newval);";
188
+		$script .= "jQuery('{$args[ 'element' ]}').html(newval);";
189 189
 		return $script;
190 190
 	}
191 191
 
@@ -200,34 +200,34 @@  discard block
 block discarded – undo
200 200
 		$script          = '';
201 201
 		$property_script = '';
202 202
 
203
-		$value_key        = 'newval' . $args['index_key'];
203
+		$value_key        = 'newval' . $args[ 'index_key' ];
204 204
 		$property_script .= $value_key . '=newval;';
205 205
 
206 206
 		$args = $this->get_args( $args );
207 207
 
208 208
 		// Apply callback to the value if a callback is defined.
209
-		if ( ! empty( $args['js_callback'] ) && is_array( $args['js_callback'] ) && isset( $args['js_callback'][0] ) && ! empty( $args['js_callback'][0] ) ) {
210
-			$script .= $value_key . '=' . $args['js_callback'][0] . '(' . $value_key . ',' . $args['js_callback'][1] . ');';
209
+		if ( ! empty( $args[ 'js_callback' ] ) && is_array( $args[ 'js_callback' ] ) && isset( $args[ 'js_callback' ][ 0 ] ) && ! empty( $args[ 'js_callback' ][ 0 ] ) ) {
210
+			$script .= $value_key . '=' . $args[ 'js_callback' ][ 0 ] . '(' . $value_key . ',' . $args[ 'js_callback' ][ 1 ] . ');';
211 211
 		}
212 212
 
213 213
 		// Apply the value_pattern.
214
-		if ( '' !== $args['value_pattern'] ) {
214
+		if ( '' !== $args[ 'value_pattern' ] ) {
215 215
 			$script .= $this->value_pattern_replacements( $value_key, $args );
216 216
 		}
217 217
 
218 218
 		// Tweak to add url() for background-images.
219
-		if ( 'background-image' === $args['property'] && ( ! isset( $args['value_pattern'] ) || false === strpos( $args['value_pattern'], 'gradient' ) ) ) {
219
+		if ( 'background-image' === $args[ 'property' ] && ( ! isset( $args[ 'value_pattern' ] ) || false === strpos( $args[ 'value_pattern' ], 'gradient' ) ) ) {
220 220
 			$script .= 'if(-1===' . $value_key . '.indexOf(\'url(\')){' . $value_key . '=\'url("\'+' . $value_key . '+\'")\';}';
221 221
 		}
222 222
 
223 223
 		// Apply prefix.
224 224
 		$value = $value_key;
225
-		if ( '' !== $args['prefix'] ) {
226
-			$value = "'" . $args['prefix'] . "'+" . $value_key;
225
+		if ( '' !== $args[ 'prefix' ] ) {
226
+			$value = "'" . $args[ 'prefix' ] . "'+" . $value_key;
227 227
 		}
228
-		$css = $args['element'] . '{' . $args['property'] . ':\'+' . $value . '+\'' . $args['units'] . $args['suffix'] . ';}';
229
-		if ( isset( $args['media_query'] ) ) {
230
-			$css = $args['media_query'] . '{' . $css . '}';
228
+		$css = $args[ 'element' ] . '{' . $args[ 'property' ] . ':\'+' . $value . '+\'' . $args[ 'units' ] . $args[ 'suffix' ] . ';}';
229
+		if ( isset( $args[ 'media_query' ] ) ) {
230
+			$css = $args[ 'media_query' ] . '{' . $css . '}';
231 231
 		}
232 232
 		return array(
233 233
 			'script' => $property_script . $script,
@@ -244,60 +244,60 @@  discard block
 block discarded – undo
244 244
 	 */
245 245
 	protected function script_var_array( $args ) {
246 246
 
247
-		$script          = ( 0 === $args['index_key'] ) ? 'css=\'\';' : '';
247
+		$script          = ( 0 === $args[ 'index_key' ] ) ? 'css=\'\';' : '';
248 248
 		$property_script = '';
249 249
 
250 250
 		// Define choice.
251
-		$choice = ( isset( $args['choice'] ) && '' !== $args['choice'] ) ? $args['choice'] : '';
251
+		$choice = ( isset( $args[ 'choice' ] ) && '' !== $args[ 'choice' ] ) ? $args[ 'choice' ] : '';
252 252
 
253
-		$value_key        = 'newval' . $args['index_key'];
253
+		$value_key        = 'newval' . $args[ 'index_key' ];
254 254
 		$property_script .= $value_key . '=newval;';
255 255
 
256 256
 		$args = $this->get_args( $args );
257 257
 
258 258
 		// Apply callback to the value if a callback is defined.
259
-		if ( ! empty( $args['js_callback'] ) && is_array( $args['js_callback'] ) && isset( $args['js_callback'][0] ) && ! empty( $args['js_callback'][0] ) ) {
260
-			$script .= $value_key . '=' . $args['js_callback'][0] . '(' . $value_key . ',' . $args['js_callback'][1] . ');';
259
+		if ( ! empty( $args[ 'js_callback' ] ) && is_array( $args[ 'js_callback' ] ) && isset( $args[ 'js_callback' ][ 0 ] ) && ! empty( $args[ 'js_callback' ][ 0 ] ) ) {
260
+			$script .= $value_key . '=' . $args[ 'js_callback' ][ 0 ] . '(' . $value_key . ',' . $args[ 'js_callback' ][ 1 ] . ');';
261 261
 		}
262 262
 		$script .= '_.each(' . $value_key . ', function(subValue,subKey){';
263 263
 
264 264
 		// Apply the value_pattern.
265
-		if ( '' !== $args['value_pattern'] ) {
265
+		if ( '' !== $args[ 'value_pattern' ] ) {
266 266
 			$script .= $this->value_pattern_replacements( 'subValue', $args );
267 267
 		}
268 268
 
269 269
 		// Tweak to add url() for background-images.
270 270
 		if ( '' === $choice || 'background-image' === $choice ) {
271
-			$script .= 'if(\'background-image\'===\'' . $args['property'] . '\'||\'background-image\'===subKey){if(-1===subValue.indexOf(\'url(\')){subValue=\'url("\'+subValue+\'")\';}}';
271
+			$script .= 'if(\'background-image\'===\'' . $args[ 'property' ] . '\'||\'background-image\'===subKey){if(-1===subValue.indexOf(\'url(\')){subValue=\'url("\'+subValue+\'")\';}}';
272 272
 		}
273 273
 
274 274
 		// Apply prefix.
275 275
 		$value = $value_key;
276
-		if ( '' !== $args['prefix'] ) {
277
-			$value = '\'' . $args['prefix'] . '\'+subValue';
276
+		if ( '' !== $args[ 'prefix' ] ) {
277
+			$value = '\'' . $args[ 'prefix' ] . '\'+subValue';
278 278
 		}
279 279
 
280 280
 		// Mostly used for padding, margin & position properties.
281 281
 		$direction_script  = 'if(_.contains([\'top\',\'bottom\',\'left\',\'right\'],subKey)){';
282
-		$direction_script .= 'css+=\'' . $args['element'] . '{' . $args['property'] . '-\'+subKey+\':\'+subValue+\'' . $args['units'] . $args['suffix'] . ';}\';}';
282
+		$direction_script .= 'css+=\'' . $args[ 'element' ] . '{' . $args[ 'property' ] . '-\'+subKey+\':\'+subValue+\'' . $args[ 'units' ] . $args[ 'suffix' ] . ';}\';}';
283 283
 		// Allows us to apply this just for a specific choice in the array of the values.
284 284
 		if ( '' !== $choice ) {
285 285
 			$choice_is_direction = ( false !== strpos( $choice, 'top' ) || false !== strpos( $choice, 'bottom' ) || false !== strpos( $choice, 'left' ) || false !== strpos( $choice, 'right' ) );
286 286
 			// The script.
287 287
 			$script .= 'if(\'' . $choice . '\'===subKey){';
288 288
 			$script .= ( $choice_is_direction ) ? $direction_script . 'else{' : '';
289
-			$script .= 'css+=\'' . $args['element'] . '{' . $args['property'] . ':\'+subValue+\';}\';';
289
+			$script .= 'css+=\'' . $args[ 'element' ] . '{' . $args[ 'property' ] . ':\'+subValue+\';}\';';
290 290
 			$script .= ( $choice_is_direction ) ? '}' : '';
291 291
 			$script .= '}';
292 292
 		} else {
293 293
 
294 294
 			// This is where most object-based fields will go.
295
-			$script .= $direction_script . 'else{css+=\'' . $args['element'] . '{\'+subKey+\':\'+subValue+\'' . $args['units'] . $args['suffix'] . ';}\';}';
295
+			$script .= $direction_script . 'else{css+=\'' . $args[ 'element' ] . '{\'+subKey+\':\'+subValue+\'' . $args[ 'units' ] . $args[ 'suffix' ] . ';}\';}';
296 296
 		}
297 297
 		$script .= '});';
298 298
 
299
-		if ( isset( $args['media_query'] ) ) {
300
-			$script .= 'css=\'' . $args['media_query'] . '{\'+css+\'}\';';
299
+		if ( isset( $args[ 'media_query' ] ) ) {
300
+			$script .= 'css=\'' . $args[ 'media_query' ] . '{\'+css+\'}\';';
301 301
 		}
302 302
 
303 303
 		return array(
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 		$webfont_loader = 'sc=\'a\';jQuery(\'head\').append(sc.replace(\'a\',\'<\')+\'script>if(!_.isUndefined(WebFont)&&fontFamily){WebFont.load({google:{families:["\'+fontFamily.replace( /\"/g, \'&quot;\' )+\':\'+variant+\'cyrillic,cyrillic-ext,devanagari,greek,greek-ext,khmer,latin,latin-ext,vietnamese,hebrew,arabic,bengali,gujarati,tamil,telugu,thai"]}});}\'+sc.replace(\'a\',\'<\')+\'/script>\');';
327 327
 
328 328
 		// Add the css.
329
-		$css_build_array  = array(
329
+		$css_build_array = array(
330 330
 			'font-family'     => 'fontFamily',
331 331
 			'font-size'       => 'fontSize',
332 332
 			'line-height'     => 'lineHeight',
@@ -339,41 +339,41 @@  discard block
 block discarded – undo
339 339
 			'font-weight'     => 'fontWeight',
340 340
 			'font-style'      => 'fontStyle',
341 341
 		);
342
-		$choice_condition = ( isset( $args['choice'] ) && '' !== $args['choice'] && isset( $css_build_array[ $args['choice'] ] ) );
342
+		$choice_condition = ( isset( $args[ 'choice' ] ) && '' !== $args[ 'choice' ] && isset( $css_build_array[ $args[ 'choice' ] ] ) );
343 343
 		$script          .= ( ! $choice_condition ) ? $webfont_loader : '';
344 344
 		foreach ( $css_build_array as $property => $var ) {
345
-			if ( $choice_condition && $property !== $args['choice'] ) {
345
+			if ( $choice_condition && $property !== $args[ 'choice' ] ) {
346 346
 				continue;
347 347
 			}
348 348
 			// Fixes https://github.com/aristath/kirki/issues/1436.
349
-			if ( ! isset( $field['default'] ) || (
350
-				( 'font-family' === $property && ! isset( $field['default']['font-family'] ) ) ||
351
-				( 'font-size' === $property && ! isset( $field['default']['font-size'] ) ) ||
352
-				( 'line-height' === $property && ! isset( $field['default']['line-height'] ) ) ||
353
-				( 'letter-spacing' === $property && ! isset( $field['default']['letter-spacing'] ) ) ||
354
-				( 'word-spacing' === $property && ! isset( $field['default']['word-spacing'] ) ) ||
355
-				( 'text-align' === $property && ! isset( $field['default']['text-align'] ) ) ||
356
-				( 'text-transform' === $property && ! isset( $field['default']['text-transform'] ) ) ||
357
-				( 'text-decoration' === $property && ! isset( $field['default']['text-decoration'] ) ) ||
358
-				( 'color' === $property && ! isset( $field['default']['color'] ) ) ||
359
-				( 'font-weight' === $property && ! isset( $field['default']['variant'] ) && ! isset( $field['default']['font-weight'] ) ) ||
360
-				( 'font-style' === $property && ! isset( $field['default']['variant'] ) && ! isset( $field['default']['font-style'] ) )
349
+			if ( ! isset( $field[ 'default' ] ) || (
350
+				( 'font-family' === $property && ! isset( $field[ 'default' ][ 'font-family' ] ) ) ||
351
+				( 'font-size' === $property && ! isset( $field[ 'default' ][ 'font-size' ] ) ) ||
352
+				( 'line-height' === $property && ! isset( $field[ 'default' ][ 'line-height' ] ) ) ||
353
+				( 'letter-spacing' === $property && ! isset( $field[ 'default' ][ 'letter-spacing' ] ) ) ||
354
+				( 'word-spacing' === $property && ! isset( $field[ 'default' ][ 'word-spacing' ] ) ) ||
355
+				( 'text-align' === $property && ! isset( $field[ 'default' ][ 'text-align' ] ) ) ||
356
+				( 'text-transform' === $property && ! isset( $field[ 'default' ][ 'text-transform' ] ) ) ||
357
+				( 'text-decoration' === $property && ! isset( $field[ 'default' ][ 'text-decoration' ] ) ) ||
358
+				( 'color' === $property && ! isset( $field[ 'default' ][ 'color' ] ) ) ||
359
+				( 'font-weight' === $property && ! isset( $field[ 'default' ][ 'variant' ] ) && ! isset( $field[ 'default' ][ 'font-weight' ] ) ) ||
360
+				( 'font-style' === $property && ! isset( $field[ 'default' ][ 'variant' ] ) && ! isset( $field[ 'default' ][ 'font-style' ] ) )
361 361
 				) ) {
362 362
 				continue;
363 363
 			}
364
-			$script .= ( $choice_condition && 'font-family' === $args['choice'] ) ? $webfont_loader : '';
364
+			$script .= ( $choice_condition && 'font-family' === $args[ 'choice' ] ) ? $webfont_loader : '';
365 365
 
366
-			if ( 'font-family' === $property || ( isset( $args['choice'] ) && 'font-family' === $args['choice'] ) ) {
366
+			if ( 'font-family' === $property || ( isset( $args[ 'choice' ] ) && 'font-family' === $args[ 'choice' ] ) ) {
367 367
 				$css .= 'fontFamilyCSS=fontFamily;if(0<fontFamily.indexOf(\' \')&&-1===fontFamily.indexOf(\'"\')){fontFamilyCSS=\'"\'+fontFamily+\'"\';}';
368 368
 				$var  = 'fontFamilyCSS';
369 369
 			}
370
-			$var  = ( ( empty( $args['prefix'] ) ) ? '' : '\'' . $args['prefix'] . '\'+' ) . $var . ( ( empty( $args['units'] ) ) ? '' : '+\'' . $args['units'] . '\'' ) . ( ( empty( $args['suffix'] ) ) ? '' : '+\'' . $args['suffix'] . '\'' );
371
-			$css .= 'css+=(\'\'!==' . $var . ')?\'' . $args['element'] . '\'+\'{' . $property . ':\'+' . $var . '+\';}\':\'\';';
370
+			$var  = ( ( empty( $args[ 'prefix' ] ) ) ? '' : '\'' . $args[ 'prefix' ] . '\'+' ) . $var . ( ( empty( $args[ 'units' ] ) ) ? '' : '+\'' . $args[ 'units' ] . '\'' ) . ( ( empty( $args[ 'suffix' ] ) ) ? '' : '+\'' . $args[ 'suffix' ] . '\'' );
371
+			$css .= 'css+=(\'\'!==' . $var . ')?\'' . $args[ 'element' ] . '\'+\'{' . $property . ':\'+' . $var . '+\';}\':\'\';';
372 372
 		}
373 373
 
374 374
 		$script .= $css;
375
-		if ( isset( $args['media_query'] ) ) {
376
-			$script .= 'css=\'' . $args['media_query'] . '{\'+css+\'}\';';
375
+		if ( isset( $args[ 'media_query' ] ) ) {
376
+			$script .= 'css=\'' . $args[ 'media_query' ] . '{\'+css+\'}\';';
377 377
 		}
378 378
 		return array(
379 379
 			'script' => $script,
@@ -391,8 +391,8 @@  discard block
 block discarded – undo
391 391
 	protected function script_var_image( $args ) {
392 392
 		$return = $this->script_var( $args );
393 393
 		return array(
394
-			'script' => 'newval=(!_.isUndefined(newval.url))?newval.url:newval;' . $return['script'],
395
-			'css'    => $return['css'],
394
+			'script' => 'newval=(!_.isUndefined(newval.url))?newval.url:newval;' . $return[ 'script' ],
395
+			'css'    => $return[ 'css' ],
396 396
 		);
397 397
 	}
398 398
 
@@ -408,8 +408,8 @@  discard block
 block discarded – undo
408 408
 
409 409
 		$script = '';
410 410
 
411
-		if ( isset( $args['type'] ) ) {
412
-			switch ( $args['type'] ) {
411
+		if ( isset( $args[ 'type' ] ) ) {
412
+			switch ( $args[ 'type' ] ) {
413 413
 				case 'kirki-typography':
414 414
 					$script .= 'fontFamily=(_.isUndefined(newval[\'font-family\']))?\'\':newval[\'font-family\'];variant=(_.isUndefined(newval.variant))?\'400\':newval.variant;fontSize=(_.isUndefined(newval[\'font-size\']))?\'\':newval[\'font-size\'];lineHeight=(_.isUndefined(newval[\'line-height\']))?\'\':newval[\'line-height\'];letterSpacing=(_.isUndefined(newval[\'letter-spacing\']))?\'\':newval[\'letter-spacing\'];wordSpacing=(_.isUndefined(newval[\'word-spacing\']))?\'\':newval[\'word-spacing\'];textAlign=(_.isUndefined(newval[\'text-align\']))?\'\':newval[\'text-align\'];textTransform=(_.isUndefined(newval[\'text-transform\']))?\'\':newval[\'text-transform\'];textDecoration=(_.isUndefined(newval[\'text-decoration\']))?\'\':newval[\'text-decoration\'];color=(_.isUndefined(newval.color))?\'\':newval.color;fw=(!_.isString(newval.variant))?\'400\':newval.variant.match(/\d/g);fontWeight=(!_.isObject(fw))?400:fw.join(\'\');fontStyle=(variant&&-1!==variant.indexOf(\'italic\'))?\'italic\':\'normal\';css=\'\';';
415 415
 					break;
@@ -442,17 +442,17 @@  discard block
 block discarded – undo
442 442
 		);
443 443
 
444 444
 		// Element should be a string.
445
-		if ( is_array( $args['element'] ) ) {
446
-			$args['element'] = implode( ',', $args['element'] );
445
+		if ( is_array( $args[ 'element' ] ) ) {
446
+			$args[ 'element' ] = implode( ',', $args[ 'element' ] );
447 447
 		}
448 448
 
449 449
 		// Make sure arguments that are passed-on to callbacks are strings.
450
-		if ( is_array( $args['js_callback'] ) && isset( $args['js_callback'][1] ) && is_array( $args['js_callback'][1] ) ) {
451
-			$args['js_callback'][1] = wp_json_encode( $args['js_callback'][1] );
450
+		if ( is_array( $args[ 'js_callback' ] ) && isset( $args[ 'js_callback' ][ 1 ] ) && is_array( $args[ 'js_callback' ][ 1 ] ) ) {
451
+			$args[ 'js_callback' ][ 1 ] = wp_json_encode( $args[ 'js_callback' ][ 1 ] );
452 452
 		}
453 453
 
454
-		if ( ! isset( $args['js_callback'][1] ) ) {
455
-			$args['js_callback'][1] = '';
454
+		if ( ! isset( $args[ 'js_callback' ][ 1 ] ) ) {
455
+			$args[ 'js_callback' ][ 1 ] = '';
456 456
 		}
457 457
 		return $args;
458 458
 
@@ -470,15 +470,15 @@  discard block
 block discarded – undo
470 470
 	private function value_pattern_replacements( $value, $js_vars ) {
471 471
 		$script = '';
472 472
 		$alias  = $value;
473
-		if ( ! isset( $js_vars['value_pattern'] ) ) {
473
+		if ( ! isset( $js_vars[ 'value_pattern' ] ) ) {
474 474
 			return $value;
475 475
 		}
476
-		$value = $js_vars['value_pattern'];
477
-		if ( isset( $js_vars['pattern_replace'] ) ) {
476
+		$value = $js_vars[ 'value_pattern' ];
477
+		if ( isset( $js_vars[ 'pattern_replace' ] ) ) {
478 478
 			$script .= 'settings=window.wp.customize.get();';
479
-			foreach ( $js_vars['pattern_replace'] as $search => $replace ) {
479
+			foreach ( $js_vars[ 'pattern_replace' ] as $search => $replace ) {
480 480
 				$replace = '\'+settings["' . $replace . '"]+\'';
481
-				$value   = str_replace( $search, $replace, $js_vars['value_pattern'] );
481
+				$value   = str_replace( $search, $replace, $js_vars[ 'value_pattern' ] );
482 482
 				$value   = trim( $value, '+' );
483 483
 			}
484 484
 		}
@@ -498,7 +498,7 @@  discard block
 block discarded – undo
498 498
 	 */
499 499
 	protected function get_callback( $args ) {
500 500
 
501
-		switch ( $args['type'] ) {
501
+		switch ( $args[ 'type' ] ) {
502 502
 			case 'kirki-background':
503 503
 			case 'kirki-dimensions':
504 504
 			case 'kirki-multicolor':
Please login to merge, or discard this patch.