Completed
Pull Request — develop (#1353)
by
unknown
05:50
created
modules/webfonts/class-kirki-modules-webfonts-async.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,9 +80,9 @@
 block discarded – undo
80 80
 		$fonts_to_load = array();
81 81
 		foreach ( $this->googlefonts->fonts as $font => $weights ) {
82 82
 			foreach ( $weights as $key => $value ) {
83
-				$weights[ $key ] = str_replace( array( 'regular', 'bold', 'italic' ), array( '400', '', 'i' ), $value );
83
+				$weights[$key] = str_replace( array( 'regular', 'bold', 'italic' ), array( '400', '', 'i' ), $value );
84 84
 				if ( 'i' === $value ) {
85
-					$weights[ $key ] = '400i';
85
+					$weights[$key] = '400i';
86 86
 				}
87 87
 			}
88 88
 			$fonts_to_load[] = $font . ':' . join( ',', $weights );
Please login to merge, or discard this patch.
modules/css/class-kirki-modules-css.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -243,8 +243,8 @@
 block discarded – undo
243 243
 				$css = Kirki_Helper::array_replace_recursive( $css, Kirki_Modules_CSS_Generator::css( $field ) );
244 244
 
245 245
 				// Add the globals.
246
-				if ( isset( self::$css_array[ $config_id ] ) && ! empty( self::$css_array[ $config_id ] ) ) {
247
-					Kirki_Helper::array_replace_recursive( $css, self::$css_array[ $config_id ] );
246
+				if ( isset( self::$css_array[$config_id] ) && ! empty( self::$css_array[$config_id] ) ) {
247
+					Kirki_Helper::array_replace_recursive( $css, self::$css_array[$config_id] );
248 248
 				}
249 249
 			}
250 250
 		}
Please login to merge, or discard this patch.
modules/css/class-kirki-output.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 				if ( isset( $output['pattern_replace'] ) && is_array( $output['pattern_replace'] ) ) {
103 103
 					$option_type = 'theme_mod';
104 104
 					$option_name = false;
105
-					if ( isset( Kirki::$config[ $this->config_id ] ) ) {
106
-						$config = Kirki::$config[ $this->config_id ];
105
+					if ( isset( Kirki::$config[$this->config_id] ) ) {
106
+						$config = Kirki::$config[$this->config_id];
107 107
 						$option_type = ( isset( $config['option_type'] ) ) ? $config['option_type'] : 'theme_mod';
108 108
 						if ( 'option' === $option_type || 'site_option' === $option_type ) {
109 109
 							$option_name = ( isset( $config['option_name'] ) ) ? $config['option_name'] : false;
@@ -119,16 +119,16 @@  discard block
 block discarded – undo
119 119
 								if ( is_array( $options ) ) {
120 120
 									if ( $option_name ) {
121 121
 										$subkey = str_replace( array( $option_name, '[', ']' ), '', $replace );
122
-										$replacement = ( isset( $options[ $subkey ] ) ) ? $options[ $subkey ] : '';
122
+										$replacement = ( isset( $options[$subkey] ) ) ? $options[$subkey] : '';
123 123
 										break;
124 124
 									}
125
-									$replacement = ( isset( $options[ $replace ] ) ) ? $options[ $replace ] : '';
125
+									$replacement = ( isset( $options[$replace] ) ) ? $options[$replace] : '';
126 126
 									break;
127 127
 								}
128 128
 								$replacement = get_option( $replace );
129 129
 								break;
130 130
 							case 'site_option':
131
-								$replacement = ( is_array( $options ) && isset( $options[ $replace ] ) ) ? $options[ $replace ] : get_site_option( $replace );
131
+								$replacement = ( is_array( $options ) && isset( $options[$replace] ) ) ? $options[$replace] : get_site_option( $replace );
132 132
 								break;
133 133
 							case 'user_meta':
134 134
 								$user_id = get_current_user_id();
@@ -222,9 +222,9 @@  discard block
 block discarded – undo
222 222
 			return;
223 223
 		}
224 224
 		$output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global';
225
-		$output['prefix']      = ( isset( $output['prefix'] ) )      ? $output['prefix']      : '';
226
-		$output['units']       = ( isset( $output['units'] ) )       ? $output['units']       : '';
227
-		$output['suffix']      = ( isset( $output['suffix'] ) )      ? $output['suffix']      : '';
225
+		$output['prefix']      = ( isset( $output['prefix'] ) ) ? $output['prefix'] : '';
226
+		$output['units']       = ( isset( $output['units'] ) ) ? $output['units'] : '';
227
+		$output['suffix']      = ( isset( $output['suffix'] ) ) ? $output['suffix'] : '';
228 228
 
229 229
 		// Properties that can accept multiple values.
230 230
 		// Useful for example for gradients where all browsers use the "background-image" property
@@ -233,13 +233,13 @@  discard block
 block discarded – undo
233 233
 			'background-image',
234 234
 		);
235 235
 		if ( in_array( $output['property'], $accepts_multiple ) ) {
236
-			if ( isset( $this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] ) && ! is_array( $this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] ) ) {
237
-				$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = (array) $this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ];
236
+			if ( isset( $this->styles[$output['media_query']][$output['element']][$output['property']] ) && ! is_array( $this->styles[$output['media_query']][$output['element']][$output['property']] ) ) {
237
+				$this->styles[$output['media_query']][$output['element']][$output['property']] = (array) $this->styles[$output['media_query']][$output['element']][$output['property']];
238 238
 			}
239
-			$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ][] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
239
+			$this->styles[$output['media_query']][$output['element']][$output['property']][] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
240 240
 			return;
241 241
 		}
242
-		$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
242
+		$this->styles[$output['media_query']][$output['element']][$output['property']] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
243 243
 	}
244 244
 
245 245
 	/**
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 			'background-position' => 'Kirki_Output_Property_Background_Position',
260 260
 		) );
261 261
 		if ( array_key_exists( $property, $properties ) ) {
262
-			$classname = $properties[ $property ];
262
+			$classname = $properties[$property];
263 263
 			$obj = new $classname( $property, $value );
264 264
 			return $obj->get_value();
265 265
 		}
Please login to merge, or discard this patch.
modules/css/property/class-kirki-output-property-font-family.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@
 block discarded – undo
43 43
 		// Add backup font.
44 44
 		if ( Kirki_Fonts::is_google_font( $family ) ) {
45 45
 
46
-			if ( '' === $backup && isset( $google_fonts_array[ $family ] ) && isset( $backup_fonts[ $google_fonts_array[ $family ]['category'] ] ) ) {
47
-				$backup = $backup_fonts[ $google_fonts_array[ $family ]['category'] ];
46
+			if ( '' === $backup && isset( $google_fonts_array[$family] ) && isset( $backup_fonts[$google_fonts_array[$family]['category']] ) ) {
47
+				$backup = $backup_fonts[$google_fonts_array[$family]['category']];
48 48
 			}
49 49
 
50 50
 			// Add double quotes if needed.
Please login to merge, or discard this patch.
modules/css/field/class-kirki-output-field-typography.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -47,14 +47,14 @@  discard block
 block discarded – undo
47 47
 		);
48 48
 
49 49
 		foreach ( $properties as $property ) {
50
-			if ( ! isset( $value[ $property ] ) || '' === $value[ $property ] ) {
50
+			if ( ! isset( $value[$property] ) || '' === $value[$property] ) {
51 51
 				continue;
52 52
 			}
53 53
 			if ( isset( $output['choice'] ) && $output['choice'] !== $property ) {
54 54
 				continue;
55 55
 			}
56 56
 
57
-			$property_value = $this->process_property_value( $property, $value[ $property ] );
57
+			$property_value = $this->process_property_value( $property, $value[$property] );
58 58
 			if ( 'font-family' === $property ) {
59 59
 				$value['font-backup'] = ( isset( $value['font-backup'] ) ) ? $value['font-backup'] : '';
60 60
 				$property_value = $this->process_property_value( $property, array(
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
 					$value['font-backup'],
63 63
 				) );
64 64
 			}
65
-			$this->styles[ $output['media_query'] ][ $output['element'] ][ $property ] = $output['prefix'] . $property_value . $output['suffix'];
65
+			$this->styles[$output['media_query']][$output['element']][$property] = $output['prefix'] . $property_value . $output['suffix'];
66 66
 		}
67 67
 	}
68 68
 }
Please login to merge, or discard this patch.
core/class-kirki-values.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -43,43 +43,43 @@  discard block
 block discarded – undo
43 43
 		$config_id = ( '' === $config_id ) ? 'global' : $config_id;
44 44
 
45 45
 		// Fallback to 'global' if $config_id is not found.
46
-		if ( ! isset( Kirki::$config[ $config_id ] ) ) {
46
+		if ( ! isset( Kirki::$config[$config_id] ) ) {
47 47
 			$config_id = 'global';
48 48
 		}
49 49
 
50
-		if ( 'theme_mod' === Kirki::$config[ $config_id ]['option_type'] ) {
50
+		if ( 'theme_mod' === Kirki::$config[$config_id]['option_type'] ) {
51 51
 
52 52
 			// We're using theme_mods so just get the value using get_theme_mod.
53 53
 			$default_value = null;
54
-			if ( isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ $field_id ]['default'] ) ) {
55
-				$default_value = Kirki::$fields[ $field_id ]['default'];
54
+			if ( isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[$field_id]['default'] ) ) {
55
+				$default_value = Kirki::$fields[$field_id]['default'];
56 56
 			}
57 57
 			$value = get_theme_mod( $field_id, $default_value );
58 58
 			return apply_filters( 'kirki/values/get_value', $value, $field_id );
59 59
 		}
60 60
 
61
-		if ( 'option' === Kirki::$config[ $config_id ]['option_type'] ) {
61
+		if ( 'option' === Kirki::$config[$config_id]['option_type'] ) {
62 62
 
63 63
 			// We're using options.
64
-			if ( '' !== Kirki::$config[ $config_id ]['option_name'] ) {
64
+			if ( '' !== Kirki::$config[$config_id]['option_name'] ) {
65 65
 
66 66
 				// Options are serialized as a single option in the db.
67 67
 				// We'll have to get the option and then get the item from the array.
68
-				$options = get_option( Kirki::$config[ $config_id ]['option_name'] );
68
+				$options = get_option( Kirki::$config[$config_id]['option_name'] );
69 69
 
70
-				if ( ! isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ Kirki::$config[ $config_id ]['option_name'] . '[' . $field_id . ']' ] ) ) {
71
-					$field_id = Kirki::$config[ $config_id ]['option_name'] . '[' . $field_id . ']';
70
+				if ( ! isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[Kirki::$config[$config_id]['option_name'] . '[' . $field_id . ']'] ) ) {
71
+					$field_id = Kirki::$config[$config_id]['option_name'] . '[' . $field_id . ']';
72 72
 				}
73
-				$setting_modified = str_replace( ']', '', str_replace( Kirki::$config[ $config_id ]['option_name'] . '[', '', $field_id ) );
73
+				$setting_modified = str_replace( ']', '', str_replace( Kirki::$config[$config_id]['option_name'] . '[', '', $field_id ) );
74 74
 
75
-				$default_value = ( isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ $field_id ]['default'] ) ) ? Kirki::$fields[ $field_id ]['default'] : '';
76
-				$value = ( isset( $options[ $setting_modified ] ) ) ? $options[ $setting_modified ] : $default_value;
75
+				$default_value = ( isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[$field_id]['default'] ) ) ? Kirki::$fields[$field_id]['default'] : '';
76
+				$value = ( isset( $options[$setting_modified] ) ) ? $options[$setting_modified] : $default_value;
77 77
 				$value = maybe_unserialize( $value );
78 78
 				return apply_filters( 'kirki/values/get_value', $value, $field_id );
79 79
 			}
80 80
 
81 81
 			// Each option separately saved in the db.
82
-			$value = get_option( $field_id, Kirki::$fields[ $field_id ]['default'] );
82
+			$value = get_option( $field_id, Kirki::$fields[$field_id]['default'] );
83 83
 			return apply_filters( 'kirki/values/get_value', $value, $field_id );
84 84
 
85 85
 		} // End if().
@@ -104,8 +104,8 @@  discard block
 block discarded – undo
104 104
 			if ( isset( $field['option_name'] ) && '' !== $field['option_name'] ) {
105 105
 				$all_values = get_option( $field['option_name'], array() );
106 106
 				$sub_setting_id = str_replace( array( ']', $field['option_name'] . '[' ), '', $field['settings'] );
107
-				if ( isset( $all_values[ $sub_setting_id ] ) ) {
108
-					$value = $all_values[ $sub_setting_id ];
107
+				if ( isset( $all_values[$sub_setting_id] ) ) {
108
+					$value = $all_values[$sub_setting_id];
109 109
 				}
110 110
 			} else {
111 111
 				$value = get_option( $field['settings'], $field['default'] );
Please login to merge, or discard this patch.
core/class-kirki-modules.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
 		foreach ( self::$modules as $key => $module_class ) {
88 88
 			if ( class_exists( $module_class ) ) {
89
-				self::$active_modules[ $key ] = $module_class::get_instance();
89
+				self::$active_modules[$key] = $module_class::get_instance();
90 90
 			}
91 91
 		}
92 92
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
 		$key = array_search( $module, self::$modules, true );
122 122
 		if ( false !== $key ) {
123
-			unset( self::$modules[ $key ] );
123
+			unset( self::$modules[$key] );
124 124
 		}
125 125
 	}
126 126
 
Please login to merge, or discard this patch.
modules/postmessage/class-kirki-modules-postmessage.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -113,10 +113,10 @@  discard block
 block discarded – undo
113 113
 			$js_var['index_key'] = $key;
114 114
 			$callback = $this->get_callback( $args );
115 115
 			if ( is_callable( $callback ) ) {
116
-				$field['scripts'][ $key ] = call_user_func_array( $callback, array( $js_var, $args ) );
116
+				$field['scripts'][$key] = call_user_func_array( $callback, array( $js_var, $args ) );
117 117
 				continue;
118 118
 			}
119
-			$field['scripts'][ $key ] = $this->script_var( $js_var );
119
+			$field['scripts'][$key] = $this->script_var( $js_var );
120 120
 		}
121 121
 		$combo_extra_script = '';
122 122
 		$combo_css_script   = '';
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 		$property_script = '';
208 208
 
209 209
 		// Define choice.
210
-		$choice  = ( isset( $args['choice'] ) && '' !== $args['choice'] ) ? $args['choice'] : '';
210
+		$choice = ( isset( $args['choice'] ) && '' !== $args['choice'] ) ? $args['choice'] : '';
211 211
 
212 212
 		$value_key = 'newval' . $args['index_key'];
213 213
 		$property_script .= $value_key . '=newval;';
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
 			'font-weight'    => 'fontWeight',
298 298
 			'font-style'     => 'fontStyle',
299 299
 		);
300
-		$choice_condition = ( isset( $args['choice'] ) && '' !== $args['choice'] && isset( $css_build_array[ $args['choice'] ] ) );
300
+		$choice_condition = ( isset( $args['choice'] ) && '' !== $args['choice'] && isset( $css_build_array[$args['choice']] ) );
301 301
 		$script .= ( ! $choice_condition ) ? $webfont_loader : '';
302 302
 		foreach ( $css_build_array as $property => $var ) {
303 303
 			if ( $choice_condition && $property !== $args['choice'] ) {
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 			'units'         => '',
379 379
 			'js_callback'   => array( '', '' ),
380 380
 			'value_pattern' => '',
381
-		));
381
+		) );
382 382
 
383 383
 		// Element should be a string.
384 384
 		if ( is_array( $args['element'] ) ) {
Please login to merge, or discard this patch.