aristath /
kirki
| Conditions | 29 |
| Paths | 8 |
| Total Lines | 100 |
| Code Lines | 67 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 72 | public function sanitize( $value ) { |
||
| 73 | |||
| 74 | // is the value formatted as a string? |
||
| 75 | if ( is_string( $value ) ) { |
||
| 76 | $value = rawurldecode( $value ); |
||
| 77 | $value = json_decode( $value, true ); |
||
| 78 | } |
||
| 79 | |||
| 80 | // Nothing to sanitize if we don't have fields. |
||
| 81 | if ( empty( $this->fields ) ) { |
||
| 82 | return $value; |
||
| 83 | } |
||
| 84 | |||
| 85 | foreach ( $value as $row_id => $row_value ) { |
||
| 86 | |||
| 87 | // Make sure the row is formatted as an array. |
||
| 88 | if ( ! is_array( $row_value ) ) { |
||
| 89 | $value[ $row_id ] = array(); |
||
| 90 | continue; |
||
| 91 | } |
||
| 92 | // Start parsing sub-fields in rows. |
||
| 93 | foreach ( $row_value as $subfield_id => $subfield_value ) { |
||
| 94 | // Make sure this is a valid subfield. |
||
| 95 | // If it's not, then unset it. |
||
| 96 | if ( ! isset( $this->fields[ $subfield_id ] ) ) { |
||
| 97 | unset( $value[ $row_id ][ $subfield_id ] ); |
||
| 98 | } |
||
| 99 | // Get the subfield-type. |
||
| 100 | $subfield_type = $this->fields[ $subfield_id ]['type']; |
||
| 101 | |||
| 102 | // Allow using a sanitize-callback on a per-field basis. |
||
| 103 | if ( isset( $this->fields[ $subfield_id ]['sanitize_callback'] ) ) { |
||
| 104 | |||
| 105 | $subfield_value = call_user_func( $this->fields[ $subfield_id ]['sanitize_callback'], $subfield_value ); |
||
| 106 | |||
| 107 | } else { |
||
| 108 | |||
| 109 | switch ( $subfield_type ) { |
||
| 110 | case 'image': |
||
| 111 | case 'cropped_image': |
||
| 112 | case 'upload': |
||
| 113 | if ( ! is_numeric( $subfield_value ) && is_string( $subfield_value ) ) { |
||
| 114 | $subfield_value = esc_url_raw( $subfield_value ); |
||
| 115 | } |
||
| 116 | break; |
||
| 117 | case 'dropdown-pages': |
||
| 118 | $subfield_value = (int) $subfield_value; |
||
| 119 | break; |
||
| 120 | case 'color': |
||
| 121 | // Instantiate the object. |
||
| 122 | $color_obj = ariColor::newColor( $subfield_value ); |
||
| 123 | $$subfield_value = $color_obj->toCSS( $color_obj->mode ); |
||
| 124 | break; |
||
| 125 | case 'text': |
||
| 126 | $subfield_value = esc_textarea( $subfield_value ); |
||
| 127 | break; |
||
| 128 | case 'url': |
||
| 129 | case 'link': |
||
| 130 | $subfield_value = esc_url_raw( $subfield_value ); |
||
| 131 | break; |
||
| 132 | case 'email': |
||
| 133 | $subfield_value = filter_var( $subfield_value, FILTER_SANITIZE_EMAIL ); |
||
| 134 | break; |
||
| 135 | case 'tel': |
||
| 136 | $subfield_value = esc_attr( $subfield_value ); |
||
| 137 | break; |
||
| 138 | case 'checkbox': |
||
| 139 | $subfield_value = (string) intval( $subfield_value ); |
||
| 140 | break; |
||
| 141 | case 'select': |
||
| 142 | if ( isset( $this->fields[ $subfield_id ]['multiple'] ) ) { |
||
| 143 | if ( true === $this->fields[ $subfield_id ]['multiple'] ) { |
||
| 144 | $multiple = 2; |
||
|
|
|||
| 145 | } |
||
| 146 | $multiple = (int) $this->fields[ $subfield_id ]['multiple']; |
||
| 147 | if ( 1 < $multiple ) { |
||
| 148 | $subfield_value = (array) $subfield_value; |
||
| 149 | foreach ( $subfield_value as $sub_subfield_key => $sub_subfield_value ) { |
||
| 150 | $subfield_value[ $sub_subfield_key ] = esc_attr( $sub_subfield_value ); |
||
| 151 | } |
||
| 152 | } else { |
||
| 153 | $subfield_value = esc_attr( $subfield_value ); |
||
| 154 | } |
||
| 155 | } |
||
| 156 | break; |
||
| 157 | case 'radio': |
||
| 158 | case 'radio-image': |
||
| 159 | $subfield_value = esc_attr( $subfield_value ); |
||
| 160 | break; |
||
| 161 | case 'textarea': |
||
| 162 | $subfield_value = wp_kses_post( $subfield_value ); |
||
| 163 | |||
| 164 | } // End switch(). |
||
| 165 | } // End if(). |
||
| 166 | $value[ $row_id ][ $subfield_id ] = $subfield_value; |
||
| 167 | } // End foreach(). |
||
| 168 | } // End foreach(). |
||
| 169 | |||
| 170 | return $value; |
||
| 171 | } |
||
| 172 | } |
||
| 173 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.