Completed
Pull Request — master (#1653)
by Aristeides
04:14 queued 02:13
created
controls/php/class-kirki-control-typography.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 		if ( Kirki_Util::get_wp_version() >= 4.9 ) {
40 40
 			return;
41 41
 		}
42
-		$custom_fonts_array  = ( isset( $this->choices['fonts'] ) && ( isset( $this->choices['fonts']['google'] ) || isset( $this->choices['fonts']['standard'] ) ) && ( ! empty( $this->choices['fonts']['google'] ) || ! empty( $this->choices['fonts']['standard'] ) ) );
42
+		$custom_fonts_array  = ( isset( $this->choices[ 'fonts' ] ) && ( isset( $this->choices[ 'fonts' ][ 'google' ] ) || isset( $this->choices[ 'fonts' ][ 'standard' ] ) ) && ( ! empty( $this->choices[ 'fonts' ][ 'google' ] ) || ! empty( $this->choices[ 'fonts' ][ 'standard' ] ) ) );
43 43
 		$localize_script_var = ( $custom_fonts_array ) ? 'kirkiFonts' . $this->id : 'kirkiAllFonts';
44 44
 		wp_localize_script(
45 45
 			'kirki-script', $localize_script_var, array(
@@ -57,25 +57,25 @@  discard block
 block discarded – undo
57 57
 	public function to_json() {
58 58
 		parent::to_json();
59 59
 
60
-		if ( is_array( $this->json['value'] ) ) {
61
-			foreach ( array_keys( $this->json['value'] ) as $key ) {
62
-				if ( ! in_array( $key, array( 'variant', 'font-weight', 'font-style' ), true ) && ! isset( $this->json['default'][ $key ] ) ) {
63
-					unset( $this->json['value'][ $key ] );
60
+		if ( is_array( $this->json[ 'value' ] ) ) {
61
+			foreach ( array_keys( $this->json[ 'value' ] ) as $key ) {
62
+				if ( ! in_array( $key, array( 'variant', 'font-weight', 'font-style' ), true ) && ! isset( $this->json[ 'default' ][ $key ] ) ) {
63
+					unset( $this->json[ 'value' ][ $key ] );
64 64
 				}
65 65
 				// Fix for https://wordpress.org/support/topic/white-font-after-updateing-to-3-0-16.
66
-				if ( ! isset( $this->json['default'][ $key ] ) ) {
67
-					unset( $this->json['value'][ $key ] );
66
+				if ( ! isset( $this->json[ 'default' ][ $key ] ) ) {
67
+					unset( $this->json[ 'value' ][ $key ] );
68 68
 				}
69 69
 				// Fix for https://github.com/aristath/kirki/issues/1405.
70
-				if ( isset( $this->json['default'][ $key ] ) && false === $this->json['default'][ $key ] ) {
71
-					unset( $this->json['value'][ $key ] );
70
+				if ( isset( $this->json[ 'default' ][ $key ] ) && false === $this->json[ 'default' ][ $key ] ) {
71
+					unset( $this->json[ 'value' ][ $key ] );
72 72
 				}
73 73
 			}
74 74
 		}
75 75
 
76
-		$this->json['show_variants'] = ( true === Kirki_Fonts_Google::$force_load_all_variants ) ? false : true;
77
-		$this->json['show_subsets']  = ( true === Kirki_Fonts_Google::$force_load_all_subsets ) ? false : true;
78
-		$this->json['languages']     = Kirki_Fonts::get_google_font_subsets();
76
+		$this->json[ 'show_variants' ] = ( true === Kirki_Fonts_Google::$force_load_all_variants ) ? false : true;
77
+		$this->json[ 'show_subsets' ]  = ( true === Kirki_Fonts_Google::$force_load_all_subsets ) ? false : true;
78
+		$this->json[ 'languages' ]     = Kirki_Fonts::get_google_font_subsets();
79 79
 	}
80 80
 
81 81
 	/**
@@ -282,12 +282,12 @@  discard block
 block discarded – undo
282 282
 		$final_variants = array();
283 283
 		foreach ( $variants as $variant ) {
284 284
 			if ( is_string( $variant ) ) {
285
-				$final_variants[] = array(
285
+				$final_variants[ ] = array(
286 286
 					'id'    => $variant,
287 287
 					'label' => isset( $all_variants[ $variant ] ) ? $all_variants[ $variant ] : $variant,
288 288
 				);
289
-			} elseif ( is_array( $variant ) && isset( $variant['id'] ) && isset( $variant['label'] ) ) {
290
-				$final_variants[] = $variant;
289
+			} elseif ( is_array( $variant ) && isset( $variant[ 'id' ] ) && isset( $variant[ 'label' ] ) ) {
290
+				$final_variants[ ] = $variant;
291 291
 			}
292 292
 		}
293 293
 		return $final_variants;
@@ -305,8 +305,8 @@  discard block
 block discarded – undo
305 305
 		$standard_fonts = Kirki_Fonts::get_standard_fonts();
306 306
 
307 307
 		$std_user_keys = array();
308
-		if ( isset( $this->choices['fonts'] ) && isset( $this->choices['fonts']['standard'] ) ) {
309
-			$std_user_keys = $this->choices['fonts']['standard'];
308
+		if ( isset( $this->choices[ 'fonts' ] ) && isset( $this->choices[ 'fonts' ][ 'standard' ] ) ) {
309
+			$std_user_keys = $this->choices[ 'fonts' ][ 'standard' ];
310 310
 		}
311 311
 
312 312
 		$standard_fonts_final = array();
@@ -319,15 +319,15 @@  discard block
 block discarded – undo
319 319
 			)
320 320
 		);
321 321
 		foreach ( $standard_fonts as $key => $font ) {
322
-			if ( ( ! empty( $std_user_keys ) && ! in_array( $key, $std_user_keys, true ) ) || ! isset( $font['stack'] ) || ! isset( $font['label'] ) ) {
322
+			if ( ( ! empty( $std_user_keys ) && ! in_array( $key, $std_user_keys, true ) ) || ! isset( $font[ 'stack' ] ) || ! isset( $font[ 'label' ] ) ) {
323 323
 				continue;
324 324
 			}
325
-			$standard_fonts_final[] = array(
326
-				'family'      => $font['stack'],
327
-				'label'       => $font['label'],
325
+			$standard_fonts_final[ ] = array(
326
+				'family'      => $font[ 'stack' ],
327
+				'label'       => $font[ 'label' ],
328 328
 				'subsets'     => array(),
329 329
 				'is_standard' => true,
330
-				'variants'    => ( isset( $font['variants'] ) ) ? $this->format_variants_array( $font['variants'] ) : $default_variants,
330
+				'variants'    => ( isset( $font[ 'variants' ] ) ) ? $this->format_variants_array( $font[ 'variants' ] ) : $default_variants,
331 331
 			);
332 332
 		}
333 333
 		return $standard_fonts_final;
@@ -347,8 +347,8 @@  discard block
 block discarded – undo
347 347
 		$all_subsets  = Kirki_Fonts::get_google_font_subsets();
348 348
 
349 349
 		$gf_user_keys = array();
350
-		if ( isset( $this->choices['fonts'] ) && isset( $this->choices['fonts']['google'] ) ) {
351
-			$gf_user_keys = $this->choices['fonts']['google'];
350
+		if ( isset( $this->choices[ 'fonts' ] ) && isset( $this->choices[ 'fonts' ][ 'google' ] ) ) {
351
+			$gf_user_keys = $this->choices[ 'fonts' ][ 'google' ];
352 352
 		}
353 353
 
354 354
 		$google_fonts_final = array();
@@ -357,15 +357,15 @@  discard block
 block discarded – undo
357 357
 				continue;
358 358
 			}
359 359
 
360
-			$label    = ( isset( $args['label'] ) ) ? $args['label'] : $family;
361
-			$variants = ( isset( $args['variants'] ) ) ? $args['variants'] : array( 'regular', '700' );
362
-			$subsets  = ( isset( $args['subsets'] ) ) ? $args['subsets'] : array();
360
+			$label    = ( isset( $args[ 'label' ] ) ) ? $args[ 'label' ] : $family;
361
+			$variants = ( isset( $args[ 'variants' ] ) ) ? $args[ 'variants' ] : array( 'regular', '700' );
362
+			$subsets  = ( isset( $args[ 'subsets' ] ) ) ? $args[ 'subsets' ] : array();
363 363
 
364 364
 			$available_variants = array();
365 365
 			if ( is_array( $variants ) ) {
366 366
 				foreach ( $variants as $variant ) {
367 367
 					if ( array_key_exists( $variant, $all_variants ) ) {
368
-						$available_variants[] = array(
368
+						$available_variants[ ] = array(
369 369
 							'id' => $variant,
370 370
 							'label' => $all_variants[ $variant ],
371 371
 						);
@@ -377,7 +377,7 @@  discard block
 block discarded – undo
377 377
 			if ( is_array( $subsets ) ) {
378 378
 				foreach ( $subsets as $subset ) {
379 379
 					if ( array_key_exists( $subset, $all_subsets ) ) {
380
-						$available_subsets[] = array(
380
+						$available_subsets[ ] = array(
381 381
 							'id' => $subset,
382 382
 							'label' => $all_subsets[ $subset ],
383 383
 						);
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
 				}
386 386
 			}
387 387
 
388
-			$google_fonts_final[] = array(
388
+			$google_fonts_final[ ] = array(
389 389
 				'family'       => $family,
390 390
 				'label'        => $label,
391 391
 				'variants'     => $available_variants,
Please login to merge, or discard this patch.