modules/custom-sections/sections.js - Code Metrics - Inspection of "3.0.17" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1653)

by Aristeides

created 2017-12-03 13:40 UTC

modules/custom-sections/sections.js B

↳ Parent: Project

Complexity

Total Complexity	53
Complexity/F	2.41

Size

Lines of Code	256
Function Count	22

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	0
nc	256
dl	0
loc	256
rs	7.4757
c	0
b	0
f	0
wmc	53
mnd	2
bc	48
fnc	22
bpm	2.1818
cpm	2.4089
noi	13

8 Functions

Rating	Name	Size	Complexity
B	wp.customize.Panel.extend.attachEvents	33	3
B	wp.customize.Panel.extend.isContextuallyActive	33	2
B	wp.customize.bind(ꞌpane-contents-reflowedꞌ)	38	1
B		233	1
B	wp.customize.Section.extend.isContextuallyActive	37	2
B	wp.customize.Section.extend.attachEvents	31	3
A	wp.customize.Section.extend.embed	16	3
A	wp.customize.Panel.extend.embed	15	3

How to fix Complexity

jQuery( document ).ready( function() {

	wp.customize.section.each( function( section ) {

		// Get the pane element.
		var pane      = jQuery( '#sub-accordion-section-' + section.id ),
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
		    sectionLi = jQuery( '#accordion-section-' + section.id );

		// Check if the section is expanded.
		if ( sectionLi.hasClass( 'control-section-kirki-expanded' ) ) {

			// Move element.
			pane.appendTo( sectionLi );

		}

	} );

} );

/**
 * @see https://wordpress.stackexchange.com/a/256103/17078
 */
( function() {

	var _panelEmbed,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
	    _panelIsContextuallyActive,
	    _panelAttachEvents,
	    _sectionEmbed,
	    _sectionIsContextuallyActive,
	    _sectionAttachEvents;

	wp.customize.bind( 'pane-contents-reflowed', function() {

		var panels   = [],
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
		    sections = [];

		// Reflow Sections.
		wp.customize.section.each( function( section ) {

			if ( 'kirki-nested' !== section.params.type || _.isUndefined( section.params.section ) ) {
				return;
			}
			sections.push( section );
		});

		sections.sort( wp.customize.utils.prioritySort ).reverse();

		jQuery.each( sections, function( i, section ) {
			var parentContainer = jQuery( '#sub-accordion-section-' + section.params.section );
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

			parentContainer.children( '.section-meta' ).after( section.headContainer );
		});

		// Reflow Panels.
		wp.customize.panel.each( function( panel ) {
			if ( 'kirki-nested' !== panel.params.type || _.isUndefined( panel.params.panel ) ) {
				return;
			}
			panels.push( panel );
		});

		panels.sort( wp.customize.utils.prioritySort ).reverse();

		jQuery.each( panels, function( i, panel ) {
			var parentContainer = jQuery( '#sub-accordion-panel-' + panel.params.panel );
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

			parentContainer.children( '.panel-meta' ).after( panel.headContainer );
		});
	});

	// Extend Panel.
	_panelEmbed = wp.customize.Panel.prototype.embed;
	_panelIsContextuallyActive = wp.customize.Panel.prototype.isContextuallyActive;
	_panelAttachEvents = wp.customize.Panel.prototype.attachEvents;

	wp.customize.Panel = wp.customize.Panel.extend({
		attachEvents: function() {
			var panel;
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

			if ( 'kirki-nested' !== this.params.type || _.isUndefined( this.params.panel ) ) {
				_panelAttachEvents.call( this );
				return;
			}

			_panelAttachEvents.call( this );

			panel = this;

			panel.expanded.bind( function( expanded ) {
				var parent = wp.customize.panel( panel.params.panel );
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

				if ( expanded ) {
					parent.contentContainer.addClass( 'current-panel-parent' );
				} else {
					parent.contentContainer.removeClass( 'current-panel-parent' );
				}
			});

			panel.container.find( '.customize-panel-back' ).off( 'click keydown' ).on( 'click keydown', function( event ) {
				if ( wp.customize.utils.isKeydownButNotEnterEvent( event ) ) {
					return;
				}
				event.preventDefault(); // Keep this AFTER the key filter above

				if ( panel.expanded() ) {
					wp.customize.panel( panel.params.panel ).expand();
				}
			});
		},

		embed: function() {

			var panel = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			    parentContainer;
			if ( 'kirki-nested' !== this.params.type || _.isUndefined( this.params.panel ) ) {
				_panelEmbed.call( this );
				return;
			}

			_panelEmbed.call( this );

			parentContainer = jQuery( '#sub-accordion-panel-' + this.params.panel );

			parentContainer.append( panel.headContainer );
		},

		isContextuallyActive: function() {

			var panel = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			    children,
			    activeCount = 0;

			if ( 'kirki-nested' !== this.params.type ) {
				return _panelIsContextuallyActive.call( this );
			}

			children = this._children( 'panel', 'section' );

			wp.customize.panel.each( function( child ) {
				if ( ! child.params.panel ) {
					return;
				}

				if ( child.params.panel !== panel.id ) {
					return;
				}

				children.push( child );
			});

			children.sort( wp.customize.utils.prioritySort );

			_( children ).each( function( child ) {
				if ( child.active() && child.isContextuallyActive() ) {
					activeCount += 1;
				}
			});
			return ( 0 !== activeCount );
		}
	});

	// Extend Section.
	_sectionEmbed = wp.customize.Section.prototype.embed;
	_sectionIsContextuallyActive = wp.customize.Section.prototype.isContextuallyActive;
	_sectionAttachEvents = wp.customize.Section.prototype.attachEvents;

	wp.customize.Section = wp.customize.Section.extend({
		attachEvents: function() {

			var section = this;
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

			if ( 'kirki-nested' !== this.params.type || _.isUndefined( this.params.section ) ) {
				_sectionAttachEvents.call( section );
				return;
			}

			_sectionAttachEvents.call( section );

			section.expanded.bind( function( expanded ) {
				var parent = wp.customize.section( section.params.section );
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

				if ( expanded ) {
					parent.contentContainer.addClass( 'current-section-parent' );
				} else {
					parent.contentContainer.removeClass( 'current-section-parent' );
				}
			});

			section.container.find( '.customize-section-back' ).off( 'click keydown' ).on( 'click keydown', function( event ) {
				if ( wp.customize.utils.isKeydownButNotEnterEvent( event ) ) {
					return;
				}
				event.preventDefault(); // Keep this AFTER the key filter above
				if ( section.expanded() ) {
					wp.customize.section( section.params.section ).expand();
				}
			});
		},

		embed: function() {

			var section = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			    parentContainer;

			if ( 'kirki-nested' !== this.params.type || _.isUndefined( this.params.section ) ) {
				_sectionEmbed.call( section );
				return;
			}

			_sectionEmbed.call( section );

			parentContainer = jQuery( '#sub-accordion-section-' + this.params.section );

			parentContainer.append( section.headContainer );
		},

		isContextuallyActive: function() {
			var section = this,
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			    children,
			    activeCount = 0;
			if ( 'kirki-nested' !== this.params.type ) {
				return _sectionIsContextuallyActive.call( this );
			}

			children = this._children( 'section', 'control' );

			wp.customize.section.each( function( child ) {
				if ( ! child.params.section ) {
					return;
				}

				if ( child.params.section !== section.id ) {
					return;
				}
				children.push( child );
			});

			children.sort( wp.customize.utils.prioritySort );

			_( children ).each( function( child ) {
				if ( 'undefined' !== typeof child.isContextuallyActive ) {
					if ( child.active() && child.isContextuallyActive() ) {
						activeCount += 1;
					}
				} else {
					if ( child.active() ) {
						activeCount += 1;
					}
				}
			});

			return ( 0 !== activeCount );
		}
	});
})( jQuery );


1			jQuery( document ).ready( function() {
2
3			wp.customize.section.each( function( section ) {
4
5			// Get the pane element.
6			var pane = jQuery( '#sub-accordion-section-' + section.id ),
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
7			sectionLi = jQuery( '#accordion-section-' + section.id );
8
9			// Check if the section is expanded.
10			if ( sectionLi.hasClass( 'control-section-kirki-expanded' ) ) {
11
12			// Move element.
13			pane.appendTo( sectionLi );
14
15			}
16
17			} );
18
19			} );
20
21			/**
22			* @see https://wordpress.stackexchange.com/a/256103/17078
23			*/
24			( function() {
25
26			var _panelEmbed,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
27			_panelIsContextuallyActive,
28			_panelAttachEvents,
29			_sectionEmbed,
30			_sectionIsContextuallyActive,
31			_sectionAttachEvents;
32
33			wp.customize.bind( 'pane-contents-reflowed', function() {
34
35			var panels = [],
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
36			sections = [];
37
38			// Reflow Sections.
39			wp.customize.section.each( function( section ) {
40
41			if ( 'kirki-nested' !== section.params.type \|\| _.isUndefined( section.params.section ) ) {
42			return;
43			}
44			sections.push( section );
45			});
46
47			sections.sort( wp.customize.utils.prioritySort ).reverse();
48
49			jQuery.each( sections, function( i, section ) {
50			var parentContainer = jQuery( '#sub-accordion-section-' + section.params.section );
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
51
52			parentContainer.children( '.section-meta' ).after( section.headContainer );
53			});
54
55			// Reflow Panels.
56			wp.customize.panel.each( function( panel ) {
57			if ( 'kirki-nested' !== panel.params.type \|\| _.isUndefined( panel.params.panel ) ) {
58			return;
59			}
60			panels.push( panel );
61			});
62
63			panels.sort( wp.customize.utils.prioritySort ).reverse();
64
65			jQuery.each( panels, function( i, panel ) {
66			var parentContainer = jQuery( '#sub-accordion-panel-' + panel.params.panel );
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
67
68			parentContainer.children( '.panel-meta' ).after( panel.headContainer );
69			});
70			});
71
72			// Extend Panel.
73			_panelEmbed = wp.customize.Panel.prototype.embed;
74			_panelIsContextuallyActive = wp.customize.Panel.prototype.isContextuallyActive;
75			_panelAttachEvents = wp.customize.Panel.prototype.attachEvents;
76
77			wp.customize.Panel = wp.customize.Panel.extend({
78			attachEvents: function() {
79			var panel;
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
80
81			if ( 'kirki-nested' !== this.params.type \|\| _.isUndefined( this.params.panel ) ) {
82			_panelAttachEvents.call( this );
83			return;
84			}
85
86			_panelAttachEvents.call( this );
87
88			panel = this;
89
90			panel.expanded.bind( function( expanded ) {
91			var parent = wp.customize.panel( panel.params.panel );
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
92
93			if ( expanded ) {
94			parent.contentContainer.addClass( 'current-panel-parent' );
95			} else {
96			parent.contentContainer.removeClass( 'current-panel-parent' );
97			}
98			});
99
100			panel.container.find( '.customize-panel-back' ).off( 'click keydown' ).on( 'click keydown', function( event ) {
101			if ( wp.customize.utils.isKeydownButNotEnterEvent( event ) ) {
102			return;
103			}
104			event.preventDefault(); // Keep this AFTER the key filter above
105
106			if ( panel.expanded() ) {
107			wp.customize.panel( panel.params.panel ).expand();
108			}
109			});
110			},
111
112			embed: function() {
113
114			var panel = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
115			parentContainer;
116			if ( 'kirki-nested' !== this.params.type \|\| _.isUndefined( this.params.panel ) ) {
117			_panelEmbed.call( this );
118			return;
119			}
120
121			_panelEmbed.call( this );
122
123			parentContainer = jQuery( '#sub-accordion-panel-' + this.params.panel );
124
125			parentContainer.append( panel.headContainer );
126			},
127
128			isContextuallyActive: function() {
129
130			var panel = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
131			children,
132			activeCount = 0;
133
134			if ( 'kirki-nested' !== this.params.type ) {
135			return _panelIsContextuallyActive.call( this );
136			}
137
138			children = this._children( 'panel', 'section' );
139
140			wp.customize.panel.each( function( child ) {
141			if ( ! child.params.panel ) {
142			return;
143			}
144
145			if ( child.params.panel !== panel.id ) {
146			return;
147			}
148
149			children.push( child );
150			});
151
152			children.sort( wp.customize.utils.prioritySort );
153
154			_( children ).each( function( child ) {
155			if ( child.active() && child.isContextuallyActive() ) {
156			activeCount += 1;
157			}
158			});
159			return ( 0 !== activeCount );
160			}
161			});
162
163			// Extend Section.
164			_sectionEmbed = wp.customize.Section.prototype.embed;
165			_sectionIsContextuallyActive = wp.customize.Section.prototype.isContextuallyActive;
166			_sectionAttachEvents = wp.customize.Section.prototype.attachEvents;
167
168			wp.customize.Section = wp.customize.Section.extend({
169			attachEvents: function() {
170
171			var section = this;
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
172
173			if ( 'kirki-nested' !== this.params.type \|\| _.isUndefined( this.params.section ) ) {
174			_sectionAttachEvents.call( section );
175			return;
176			}
177
178			_sectionAttachEvents.call( section );
179
180			section.expanded.bind( function( expanded ) {
181			var parent = wp.customize.section( section.params.section );
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
182
183			if ( expanded ) {
184			parent.contentContainer.addClass( 'current-section-parent' );
185			} else {
186			parent.contentContainer.removeClass( 'current-section-parent' );
187			}
188			});
189
190			section.container.find( '.customize-section-back' ).off( 'click keydown' ).on( 'click keydown', function( event ) {
191			if ( wp.customize.utils.isKeydownButNotEnterEvent( event ) ) {
192			return;
193			}
194			event.preventDefault(); // Keep this AFTER the key filter above
195			if ( section.expanded() ) {
196			wp.customize.section( section.params.section ).expand();
197			}
198			});
199			},
200
201			embed: function() {
202
203			var section = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
204			parentContainer;
205
206			if ( 'kirki-nested' !== this.params.type \|\| _.isUndefined( this.params.section ) ) {
207			_sectionEmbed.call( section );
208			return;
209			}
210
211			_sectionEmbed.call( section );
212
213			parentContainer = jQuery( '#sub-accordion-section-' + this.params.section );
214
215			parentContainer.append( section.headContainer );
216			},
217
218			isContextuallyActive: function() {
219			var section = this,
			0 ignored issues – show Coding Style introduced 2017-12-03 13:42 UTC by Report Bug Copy Issue Report As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
220			children,
221			activeCount = 0;
222			if ( 'kirki-nested' !== this.params.type ) {
223			return _sectionIsContextuallyActive.call( this );
224			}
225
226			children = this._children( 'section', 'control' );
227
228			wp.customize.section.each( function( child ) {
229			if ( ! child.params.section ) {
230			return;
231			}
232
233			if ( child.params.section !== section.id ) {
234			return;
235			}
236			children.push( child );
237			});
238
239			children.sort( wp.customize.utils.prioritySort );
240
241			_( children ).each( function( child ) {
242			if ( 'undefined' !== typeof child.isContextuallyActive ) {
243			if ( child.active() && child.isContextuallyActive() ) {
244			activeCount += 1;
245			}
246			} else {
247			if ( child.active() ) {
248			activeCount += 1;
249			}
250			}
251			});
252
253			return ( 0 !== activeCount );
254			}
255			});
256			})( jQuery );
257

aristath / kirki

Pull Request — master (#1653)

modules/custom-sections/sections.js B

Complexity

Size

Duplication

Importance

8 Functions

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like