Inspection of "Merge pull request #658 from aristath/develop" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (3e1132)

by Aristeides

created 2016-02-24 18:33 UTC

Status

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * select2 Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * select2 Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-slider-control.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * slider Customizer Control.
- *
- * Creates a jQuery slider control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * slider Customizer Control.
+	 *
+	 * Creates a jQuery slider control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-spacing-control.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * spacing Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.1
- */
+	 * spacing Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.1
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -26,15 +26,15 @@
 block discarded – undo
 			if ( is_array( $this->choices ) ) {
 				foreach ( $this->choices as $choice => $value ) {
 					if ( true === $value ) {
-						$this->json['choices'][ $choice ] = true;
+						$this->json['choices'][$choice] = true;
 					}
 				}
 			}
 
 			if ( is_array( $this->json['default'] ) ) {
 				foreach ( $this->json['default'] as $key => $value ) {
-					if ( isset( $this->json['choices'][ $key ] ) && ! isset( $this->json['value'][ $key ] ) ) {
-						$this->json['value'][ $key ] = $value;
+					if ( isset( $this->json['choices'][$key] ) && ! isset( $this->json['value'][$key] ) ) {
+						$this->json['value'][$key] = $value;
 					}
 				}
 			}

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-switch-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * switch Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * switch Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-toggle-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * toggle Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * toggle Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-typography-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * typography Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.1
- */
+	 * typography Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.1
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/deprecated.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * This file contains all the deprecated functions.
- * We could easily delete all these but they are kept for backwards-compatibility purposes.
- *
- * @package     Kirki
- * @category    Core
- * @author      Aristeides Stathopoulos
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * This file contains all the deprecated functions.
+	 * We could easily delete all these but they are kept for backwards-compatibility purposes.
+	 *
+	 * @package     Kirki
+	 * @category    Core
+	 * @author      Aristeides Stathopoulos
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/lib/class-kirki-colourlovers.php 1 patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -1,14 +1,14 @@
 block discarded – undo
 <?php
 /**
- * Retrieve colors from the Colourlovers API.
- *
- * @package     Kirki
- * @category    Addon
- * @author      Aristeides Stathopoulos
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * Retrieve colors from the Colourlovers API.
+	 *
+	 * @package     Kirki
+	 * @category    Addon
+	 * @author      Aristeides Stathopoulos
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

kirki.php 1 patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -1,24 +1,24 @@
 block discarded – undo
 <?php
 /**
- * Plugin Name:   Kirki Toolkit
- * Plugin URI:    http://kirki.org
- * Description:   The ultimate WordPress Customizer Toolkit
- * Author:        Aristeides Stathopoulos
- * Author URI:    http://aristeides.com
- * Version:       2.1.0.1
- * Text Domain:   kirki
- *
- * GitHub Plugin URI: aristath/kirki
- * GitHub Plugin URI: https://github.com/aristath/kirki
- *
- *
- * @package     Kirki
- * @category    Core
- * @author      Aristeides Stathopoulos
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * Plugin Name:   Kirki Toolkit
+	 * Plugin URI:    http://kirki.org
+	 * Description:   The ultimate WordPress Customizer Toolkit
+	 * Author:        Aristeides Stathopoulos
+	 * Author URI:    http://aristeides.com
+	 * Version:       2.1.0.1
+	 * Text Domain:   kirki
+	 *
+	 * GitHub Plugin URI: aristath/kirki
+	 * GitHub Plugin URI: https://github.com/aristath/kirki
+	 *
+	 *
+	 * @package     Kirki
+	 * @category    Core
+	 * @author      Aristeides Stathopoulos
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

		@@ -26,15 +26,15 @@
		block discarded – undo
26	26	if ( is_array( $this->choices ) ) {
27	27	foreach ( $this->choices as $choice => $value ) {
28	28	if ( true === $value ) {
29		- $this->json['choices'][ $choice ] = true;
	29	+ $this->json['choices'][$choice] = true;
30	30	}
31	31	}
32	32	}
33	33
34	34	if ( is_array( $this->json['default'] ) ) {
35	35	foreach ( $this->json['default'] as $key => $value ) {
36		- if ( isset( $this->json['choices'][ $key ] ) && ! isset( $this->json['value'][ $key ] ) ) {
37		- $this->json['value'][ $key ] = $value;
	36	+ if ( isset( $this->json['choices'][$key] ) && ! isset( $this->json['value'][$key] ) ) {
	37	+ $this->json['value'][$key] = $value;
38	38	}
39	39	}
40	40	}

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * select2 Customizer Control.
4		- *
5		- * @package Kirki
6		- * @subpackage Controls
7		- * @copyright Copyright (c) 2016, Aristeides Stathopoulos
8		- * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
9		- * @since 1.0
10		- */
	3	+ * select2 Customizer Control.
	4	+ *
	5	+ * @package Kirki
	6	+ * @subpackage Controls
	7	+ * @copyright Copyright (c) 2016, Aristeides Stathopoulos
	8	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
	9	+ * @since 1.0
	10	+ */
11	11
12	12	// Exit if accessed directly
13	13	if ( ! defined( 'ABSPATH' ) ) {

		@@ -1,15 +1,15 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * slider Customizer Control.
4		- *
5		- * Creates a jQuery slider control.
6		- *
7		- * @package Kirki
8		- * @subpackage Controls
9		- * @copyright Copyright (c) 2016, Aristeides Stathopoulos
10		- * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
11		- * @since 1.0
12		- */
	3	+ * slider Customizer Control.
	4	+ *
	5	+ * Creates a jQuery slider control.
	6	+ *
	7	+ * @package Kirki
	8	+ * @subpackage Controls
	9	+ * @copyright Copyright (c) 2016, Aristeides Stathopoulos
	10	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
	11	+ * @since 1.0
	12	+ */
13	13
14	14	// Exit if accessed directly
15	15	if ( ! defined( 'ABSPATH' ) ) {

		@@ -1,14 +1,14 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Retrieve colors from the Colourlovers API.
4		- *
5		- * @package Kirki
6		- * @category Addon
7		- * @author Aristeides Stathopoulos
8		- * @copyright Copyright (c) 2016, Aristeides Stathopoulos
9		- * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
10		- * @since 1.0
11		- */
	3	+ * Retrieve colors from the Colourlovers API.
	4	+ *
	5	+ * @package Kirki
	6	+ * @category Addon
	7	+ * @author Aristeides Stathopoulos
	8	+ * @copyright Copyright (c) 2016, Aristeides Stathopoulos
	9	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
	10	+ * @since 1.0
	11	+ */
12	12
13	13	// Exit if accessed directly
14	14	if ( ! defined( 'ABSPATH' ) ) {

		@@ -1,24 +1,24 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Plugin Name: Kirki Toolkit
4		- * Plugin URI: http://kirki.org
5		- * Description: The ultimate WordPress Customizer Toolkit
6		- * Author: Aristeides Stathopoulos
7		- * Author URI: http://aristeides.com
8		- * Version: 2.1.0.1
9		- * Text Domain: kirki
10		- *
11		- * GitHub Plugin URI: aristath/kirki
12		- * GitHub Plugin URI: https://github.com/aristath/kirki
13		- *
14		- *
15		- * @package Kirki
16		- * @category Core
17		- * @author Aristeides Stathopoulos
18		- * @copyright Copyright (c) 2016, Aristeides Stathopoulos
19		- * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
20		- * @since 1.0
21		- */
	3	+ * Plugin Name: Kirki Toolkit
	4	+ * Plugin URI: http://kirki.org
	5	+ * Description: The ultimate WordPress Customizer Toolkit
	6	+ * Author: Aristeides Stathopoulos
	7	+ * Author URI: http://aristeides.com
	8	+ * Version: 2.1.0.1
	9	+ * Text Domain: kirki
	10	+ *
	11	+ * GitHub Plugin URI: aristath/kirki
	12	+ * GitHub Plugin URI: https://github.com/aristath/kirki
	13	+ *
	14	+ *
	15	+ * @package Kirki
	16	+ * @category Core
	17	+ * @author Aristeides Stathopoulos
	18	+ * @copyright Copyright (c) 2016, Aristeides Stathopoulos
	19	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
	20	+ * @since 1.0
	21	+ */
22	22
23	23	// Exit if accessed directly
24	24	if ( ! defined( 'ABSPATH' ) ) {

aristath / kirki

Branch — master (3e1132)

Status

Category

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +9 added lines, -9 removed lines patch added patch discarded remove patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch