Completed
Pull Request — master (#1454)
by Aristeides
05:16 queued 02:37
created
core/class-kirki-init.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
 		$this->control_types = $this->default_control_types();
168 168
 		foreach ( $this->control_types as $key => $classname ) {
169 169
 			if ( ! class_exists( $classname ) ) {
170
-				unset( $this->control_types[ $key ] );
170
+				unset( $this->control_types[$key] );
171 171
 			}
172 172
 		}
173 173
 
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
 			foreach ( Kirki::$panels as $panel_args ) {
196 196
 				// Extra checks for nested panels.
197 197
 				if ( isset( $panel_args['panel'] ) ) {
198
-					if ( isset( Kirki::$panels[ $panel_args['panel'] ] ) ) {
198
+					if ( isset( Kirki::$panels[$panel_args['panel']] ) ) {
199 199
 						// Set the type to nested.
200 200
 						$panel_args['type'] = 'kirki-nested';
201 201
 					}
@@ -217,11 +217,11 @@  discard block
 block discarded – undo
217 217
 			foreach ( Kirki::$sections as $section_args ) {
218 218
 				// Extra checks for nested sections.
219 219
 				if ( isset( $section_args['section'] ) ) {
220
-					if ( isset( Kirki::$sections[ $section_args['section'] ] ) ) {
220
+					if ( isset( Kirki::$sections[$section_args['section']] ) ) {
221 221
 						// Set the type to nested.
222 222
 						$section_args['type'] = 'kirki-nested';
223 223
 						// We need to check if the parent section is nested inside a panel.
224
-						$parent_section = Kirki::$sections[ $section_args['section'] ];
224
+						$parent_section = Kirki::$sections[$section_args['section']];
225 225
 						if ( isset( $parent_section['panel'] ) ) {
226 226
 							$section_args['panel'] = $parent_section['panel'];
227 227
 						}
Please login to merge, or discard this patch.
core/class-kirki-util.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,9 +118,9 @@
 block discarded – undo
118 118
 						// If we have a variable_callback defined then get the value of the option
119 119
 						// and run it through the callback function.
120 120
 						// If no callback is defined (false) then just get the value.
121
-						$variables[ $variable_name ] = Kirki_Values::get_value( $field['settings'] );
121
+						$variables[$variable_name] = Kirki_Values::get_value( $field['settings'] );
122 122
 						if ( $variable_callback ) {
123
-							$variables[ $variable_name ] = call_user_func( $field_variable['callback'], Kirki_Values::get_value( $field['settings'] ) );
123
+							$variables[$variable_name] = call_user_func( $field_variable['callback'], Kirki_Values::get_value( $field['settings'] ) );
124 124
 						}
125 125
 					}
126 126
 				}
Please login to merge, or discard this patch.
core/class-kirki-values.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -40,8 +40,8 @@  discard block
 block discarded – undo
40 40
 	 */
41 41
 	public function typography_field_tweaks( $value, $field_id ) {
42 42
 
43
-		if ( isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ $field_id ]['type'] ) ) {
44
-			if ( 'kirki-typography' === Kirki::$fields[ $field_id ]['type'] ) {
43
+		if ( isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[$field_id]['type'] ) ) {
44
+			if ( 'kirki-typography' === Kirki::$fields[$field_id]['type'] ) {
45 45
 
46 46
 				// Sanitize the value.
47 47
 				// This also adds font-weight if it doesn't already exist.
@@ -83,43 +83,43 @@  discard block
 block discarded – undo
83 83
 		$config_id = ( '' === $config_id ) ? 'global' : $config_id;
84 84
 
85 85
 		// Fallback to 'global' if $config_id is not found.
86
-		if ( ! isset( Kirki::$config[ $config_id ] ) ) {
86
+		if ( ! isset( Kirki::$config[$config_id] ) ) {
87 87
 			$config_id = 'global';
88 88
 		}
89 89
 
90
-		if ( 'theme_mod' === Kirki::$config[ $config_id ]['option_type'] ) {
90
+		if ( 'theme_mod' === Kirki::$config[$config_id]['option_type'] ) {
91 91
 
92 92
 			// We're using theme_mods so just get the value using get_theme_mod.
93 93
 			$default_value = null;
94
-			if ( isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ $field_id ]['default'] ) ) {
95
-				$default_value = Kirki::$fields[ $field_id ]['default'];
94
+			if ( isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[$field_id]['default'] ) ) {
95
+				$default_value = Kirki::$fields[$field_id]['default'];
96 96
 			}
97 97
 			$value = get_theme_mod( $field_id, $default_value );
98 98
 			return apply_filters( 'kirki/values/get_value', $value, $field_id );
99 99
 		}
100 100
 
101
-		if ( 'option' === Kirki::$config[ $config_id ]['option_type'] ) {
101
+		if ( 'option' === Kirki::$config[$config_id]['option_type'] ) {
102 102
 
103 103
 			// We're using options.
104
-			if ( '' !== Kirki::$config[ $config_id ]['option_name'] ) {
104
+			if ( '' !== Kirki::$config[$config_id]['option_name'] ) {
105 105
 
106 106
 				// Options are serialized as a single option in the db.
107 107
 				// We'll have to get the option and then get the item from the array.
108
-				$options = get_option( Kirki::$config[ $config_id ]['option_name'] );
108
+				$options = get_option( Kirki::$config[$config_id]['option_name'] );
109 109
 
110
-				if ( ! isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ Kirki::$config[ $config_id ]['option_name'] . '[' . $field_id . ']' ] ) ) {
111
-					$field_id = Kirki::$config[ $config_id ]['option_name'] . '[' . $field_id . ']';
110
+				if ( ! isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[Kirki::$config[$config_id]['option_name'] . '[' . $field_id . ']'] ) ) {
111
+					$field_id = Kirki::$config[$config_id]['option_name'] . '[' . $field_id . ']';
112 112
 				}
113
-				$setting_modified = str_replace( ']', '', str_replace( Kirki::$config[ $config_id ]['option_name'] . '[', '', $field_id ) );
113
+				$setting_modified = str_replace( ']', '', str_replace( Kirki::$config[$config_id]['option_name'] . '[', '', $field_id ) );
114 114
 
115
-				$default_value = ( isset( Kirki::$fields[ $field_id ] ) && isset( Kirki::$fields[ $field_id ]['default'] ) ) ? Kirki::$fields[ $field_id ]['default'] : '';
116
-				$value = ( isset( $options[ $setting_modified ] ) ) ? $options[ $setting_modified ] : $default_value;
115
+				$default_value = ( isset( Kirki::$fields[$field_id] ) && isset( Kirki::$fields[$field_id]['default'] ) ) ? Kirki::$fields[$field_id]['default'] : '';
116
+				$value = ( isset( $options[$setting_modified] ) ) ? $options[$setting_modified] : $default_value;
117 117
 				$value = maybe_unserialize( $value );
118 118
 				return apply_filters( 'kirki/values/get_value', $value, $field_id );
119 119
 			}
120 120
 
121 121
 			// Each option separately saved in the db.
122
-			$value = get_option( $field_id, Kirki::$fields[ $field_id ]['default'] );
122
+			$value = get_option( $field_id, Kirki::$fields[$field_id]['default'] );
123 123
 			return apply_filters( 'kirki/values/get_value', $value, $field_id );
124 124
 
125 125
 		} // End if().
@@ -144,8 +144,8 @@  discard block
 block discarded – undo
144 144
 			if ( isset( $field['option_name'] ) && '' !== $field['option_name'] ) {
145 145
 				$all_values = get_option( $field['option_name'], array() );
146 146
 				$sub_setting_id = str_replace( array( ']', $field['option_name'] . '[' ), '', $field['settings'] );
147
-				if ( isset( $all_values[ $sub_setting_id ] ) ) {
148
-					$value = $all_values[ $sub_setting_id ];
147
+				if ( isset( $all_values[$sub_setting_id] ) ) {
148
+					$value = $all_values[$sub_setting_id];
149 149
 				}
150 150
 			} else {
151 151
 				$value = get_option( $field['settings'], $field['default'] );
Please login to merge, or discard this patch.
controls/typography/class-kirki-control-typography.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
 
161 161
 		// Fix for https://github.com/aristath/kirki/issues/1405.
162 162
 		foreach ( array_keys( $this->json['value'] ) as $key ) {
163
-			if ( isset( $this->json['default'][ $key ] ) && false === $this->json['default'][ $key ] ) {
164
-				unset( $this->json['value'][ $key ] );
163
+			if ( isset( $this->json['default'][$key] ) && false === $this->json['default'][$key] ) {
164
+				unset( $this->json['value'][$key] );
165 165
 			}
166 166
 		}
167 167
 		$this->json['show_variants'] = ( true === Kirki_Fonts_Google::$force_load_all_variants ) ? false : true;
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
 			if ( is_string( $variant ) ) {
345 345
 				$final_variants[] = array(
346 346
 					'id'    => $variant,
347
-					'label' => isset( $all_variants[ $variant ] ) ? $all_variants[ $variant ] : $variant,
347
+					'label' => isset( $all_variants[$variant] ) ? $all_variants[$variant] : $variant,
348 348
 				);
349 349
 			} elseif ( is_array( $variant ) && isset( $variant['id'] ) && isset( $variant['label'] ) ) {
350 350
 				$final_variants[] = $variant;
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
 					if ( array_key_exists( $variant, $all_variants ) ) {
420 420
 						$available_variants[] = array(
421 421
 							'id' => $variant,
422
-							'label' => $all_variants[ $variant ],
422
+							'label' => $all_variants[$variant],
423 423
 						);
424 424
 					}
425 425
 				}
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
 					if ( array_key_exists( $subset, $all_subsets ) ) {
432 432
 						$available_subsets[] = array(
433 433
 							'id' => $subset,
434
-							'label' => $all_subsets[ $subset ],
434
+							'label' => $all_subsets[$subset],
435 435
 						);
436 436
 					}
437 437
 				}
Please login to merge, or discard this patch.