View GitHub Repository kirki

Schedule Inspection
Subscribe
Completed
Pull Request — master (#1653)
by Aristeides
04:39 queued 02:31
created

controls/js/src/date.js   A

↳ Parent: Project

Complexity

Total Complexity 2
Complexity/F 2

Size

Lines of Code 22
Function Count 1

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 0
nc 1
dl 0
loc 22
rs 10
c 0
b 0
f 0
wmc 2
mnd 1
bc 2
fnc 1
bpm 2
cpm 2
noi 1

1 Function

Rating   Name   Duplication   Size   Complexity  
A wp.customize.kirkiDynamicControl.extend.initKirkiControl 0 19 2
1 
wp.customize.controlConstructor['kirki-date'] = wp.customize.kirkiDynamicControl.extend({
2 

            


            
                                                        
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
	initKirkiControl: function() {

            


            
                                                        
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
		var control  = this;

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
As per coding-style, prefer block-scoped variables using let or const which have better semantics than var.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Since ECMAScript 6, you can create block-scoped vars or constants with the keywords
let or const. These variables/constants are only valid in the code
block where they have been declared.


Consider the following two pieces of code:


if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console





and


if (true)
 {
    let x = "Hello, Stonehenge!";
}

console.log(x); //ReferenceError: x is not defined





The variable is not defined otuside of its block. This limits bleeding of
variables into other contexts.


To know more about this  ECMA6 feature, look at the MDN pages on
let and
const.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
		// Only add in WP 4.9+.

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
		if ( _.isUndefined( wp.customize.DateTimeControl ) ) {

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
			return;

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
		}

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
		// New method for the DateTime control.

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
		wp.customize.control.add( new wp.customize.DateTimeControl( control.id, {

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
			section: control.params.section,

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
			priority: control.params.priority,

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
			label: control.params.label,

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
			description: control.params.description,

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
			settings: { 'default': control.id },

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
			'default': control.params['default']

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
		} ) );

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
	}

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
});

            


            
                                                        
            
                                    
            
            

                
                    23