| Conditions | 39 |
| Paths | > 20000 |
| Total Lines | 213 |
| Code Lines | 137 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 40 | public function custom_css() { |
||
| 41 | |||
| 42 | $config = apply_filters( 'kirki/config', array() ); |
||
| 43 | ?> |
||
| 44 | <style> |
||
| 45 | .wp-full-overlay-sidebar, |
||
| 46 | #customize-controls .customize-info .accordion-section-title, |
||
| 47 | #customize-controls .panel-meta.customize-info .accordion-section-title:hover, |
||
| 48 | #customize-theme-controls .accordion-section-title, |
||
| 49 | .customize-section-title, |
||
| 50 | #customize-theme-controls .control-section-themes .accordion-section-title, |
||
| 51 | #customize-theme-controls .control-section-themes .accordion-section-title:hover { |
||
| 52 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 53 | background: <?php echo esc_attr( $config['color_back'] ); ?>; |
||
| 54 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 55 | <?php $text_color = ( 60 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 60 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 60 )->toCSS( $color_obj->mode ); ?> |
||
| 56 | color: <?php echo esc_attr( $text_color ); ?> |
||
| 57 | <?php endif; ?> |
||
| 58 | } |
||
| 59 | |||
| 60 | #customize-theme-controls .control-section-themes .accordion-section-title, |
||
| 61 | #customize-theme-controls .control-section-themes .accordion-section-title:hover { |
||
| 62 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 63 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 64 | <?php $text_color = ( 60 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 60 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 60 )->toCSS( $color_obj->mode ); ?> |
||
| 65 | color: <?php echo esc_attr( $text_color ); ?> |
||
| 66 | <?php endif; ?> |
||
| 67 | } |
||
| 68 | |||
| 69 | #customize-controls .control-section .accordion-section-title:focus, |
||
| 70 | #customize-controls .control-section .accordion-section-title:hover, |
||
| 71 | #customize-controls .control-section.open .accordion-section-title, |
||
| 72 | #customize-controls .control-section:hover > .accordion-section-title, |
||
| 73 | .customize-panel-back:focus, |
||
| 74 | .customize-panel-back:hover, |
||
| 75 | .customize-section-back:focus, |
||
| 76 | .customize-section-back:hover { |
||
| 77 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 78 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 79 | <?php $hover_color = ( 90 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 3 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 3 )->toCSS( $color_obj->mode ); ?> |
||
| 80 | background: <?php echo esc_attr( $hover_color ); ?>; |
||
| 81 | <?php endif; ?> |
||
| 82 | <?php if ( isset( $config['color_accent'] ) ) : ?> |
||
| 83 | color: <?php echo esc_attr( $config['color_accent'] ); ?>; |
||
| 84 | border-left-color: <?php echo esc_attr( $config['color_accent'] ); ?>; |
||
| 85 | <?php endif; ?> |
||
| 86 | } |
||
| 87 | |||
| 88 | #customize-controls .customize-info, |
||
| 89 | #customize-header-actions, |
||
| 90 | .customize-section-title { |
||
| 91 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 92 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 93 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 4 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 4 )->toCSS( $color_obj->mode ); ?> |
||
| 94 | border-bottom-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 95 | <?php endif; ?> |
||
| 96 | } |
||
| 97 | |||
| 98 | .wp-full-overlay-sidebar .wp-full-overlay-header, |
||
| 99 | .customize-controls-close, |
||
| 100 | .expanded .wp-full-overlay-footer { |
||
| 101 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 102 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 103 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 15 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 15 )->toCSS( $color_obj->mode ); ?> |
||
| 104 | <?php $bg_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 5 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 5 )->toCSS( $color_obj->mode ); ?> |
||
| 105 | <?php $text_color = ( 60 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 60 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 60 )->toCSS( $color_obj->mode ); ?> |
||
| 106 | color: <?php echo esc_attr( $text_color ); ?>; |
||
| 107 | background-color: <?php echo esc_attr( $bg_color ); ?>; |
||
| 108 | border-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 109 | <?php endif; ?> |
||
| 110 | } |
||
| 111 | |||
| 112 | .customize-controls-close:hover { |
||
| 113 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 114 | background-color: <?php echo esc_attr( $config['color_back'] ); ?>; |
||
| 115 | <?php endif; ?> |
||
| 116 | <?php if ( isset( $config['color_accent'] ) ) : ?> |
||
| 117 | color: <?php echo esc_attr( $config['color_accent'] ); ?>; |
||
| 118 | border-color: <?php echo esc_attr( $config['color_accent'] ); ?>; |
||
| 119 | <?php endif; ?> |
||
| 120 | } |
||
| 121 | |||
| 122 | #accordion-section-themes+.control-section, |
||
| 123 | #customize-theme-controls .control-section:last-of-type.open, |
||
| 124 | #customize-theme-controls .control-section:last-of-type > .accordion-section-title, |
||
| 125 | #customize-theme-controls .control-section.open { |
||
| 126 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 127 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 128 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 4 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 4 )->toCSS( $color_obj->mode ); ?> |
||
| 129 | border-bottom-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 130 | border-top-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 131 | <?php endif; ?> |
||
| 132 | } |
||
| 133 | |||
| 134 | #customize-theme-controls .accordion-section-title { |
||
| 135 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 136 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 137 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 4 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 4 )->toCSS( $color_obj->mode ); ?> |
||
| 138 | border-bottom-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 139 | <?php endif; ?> |
||
| 140 | border-bottom-color: <?php echo esc_attr( $border_color ); ?>; |
||
|
|
|||
| 141 | border-left-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 142 | } |
||
| 143 | |||
| 144 | #customize-theme-controls .control-section-themes .accordion-section-title, |
||
| 145 | #customize-theme-controls .control-section-themes .accordion-section-title:hover { |
||
| 146 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 147 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 148 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 4 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 4 )->toCSS( $color_obj->mode ); ?> |
||
| 149 | border-bottom-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 150 | <?php endif; ?> |
||
| 151 | border-top-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 152 | border-bottom-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 153 | } |
||
| 154 | |||
| 155 | #customize-theme-controls .accordion-section-title:after { |
||
| 156 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 157 | <?php $color_obj = ariColor::newColor( $config['color_back'] ); ?> |
||
| 158 | <?php $arrows_color = ( 50 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 30 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 30 )->toCSS( $color_obj->mode ); ?> |
||
| 159 | color: <?php echo esc_attr( $arrows_color ); ?>; |
||
| 160 | <?php endif; ?> |
||
| 161 | } |
||
| 162 | |||
| 163 | #customize-theme-controls .control-section .accordion-section-title:focus:after, |
||
| 164 | #customize-theme-controls .control-section .accordion-section-title:hover:after, |
||
| 165 | #customize-theme-controls .control-section.open .accordion-section-title:after, |
||
| 166 | #customize-theme-controls .control-section:hover>.accordion-section-title:after { |
||
| 167 | <?php if ( isset( $config['color_accent'] ) ) : ?> |
||
| 168 | color: <?php echo esc_attr( $config['color_accent'] ); ?>; |
||
| 169 | <?php endif; ?> |
||
| 170 | } |
||
| 171 | |||
| 172 | .wp-core-ui .button-primary { |
||
| 173 | <?php if ( isset( $config['color_accent'] ) ) : ?> |
||
| 174 | <?php $color_obj = ariColor::newColor( $config['color_accent'] ); ?> |
||
| 175 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness -15 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 15 )->toCSS( $color_obj->mode ); ?> |
||
| 176 | <?php $text_color = ( 60 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 60 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 60 )->toCSS( $color_obj->mode ); ?> |
||
| 177 | background-color: <?php echo esc_attr( $config['color_accent'] ); ?>; |
||
| 178 | border-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 179 | box-shadow: 0 1px 0 <?php echo esc_attr( $border_color ); ?>; |
||
| 180 | -webkit-box-shadow: 0 1px 0 <?php echo esc_attr( $border_color ); ?>; |
||
| 181 | text-shadow: 0 -1px 1px <?php echo esc_attr( $border_color ); ?>, 1px 0 1px <?php echo esc_attr( $border_color ); ?>, 0 1px 1px <?php echo esc_attr( $border_color ); ?>, -1px 0 1px <?php echo esc_attr( $border_color ); ?>; |
||
| 182 | color: <?php echo esc_attr( $text_color ); ?>; |
||
| 183 | <?php endif; ?> |
||
| 184 | } |
||
| 185 | |||
| 186 | .wp-core-ui .button-primary.focus, |
||
| 187 | .wp-core-ui .button-primary.hover, |
||
| 188 | .wp-core-ui .button-primary:focus, |
||
| 189 | .wp-core-ui .button-primary:hover { |
||
| 190 | <?php if ( isset( $config['color_accent'] ) ) : ?> |
||
| 191 | <?php $color_obj = ariColor::newColor( $config['color_accent'] ); ?> |
||
| 192 | <?php $color_obj = ( 90 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 3 ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 3 ); ?> |
||
| 193 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 15 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 15 )->toCSS( $color_obj->mode ); ?> |
||
| 194 | <?php $text_color = ( 60 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 60 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 60 )->toCSS( $color_obj->mode ); ?> |
||
| 195 | background-color: <?php echo esc_attr( $color_obj->toCSS( $color_obj->mode ) ); ?>; |
||
| 196 | border-color: <?php echo esc_attr( $border_color ); ?>; |
||
| 197 | box-shadow: 0 1px 0 <?php echo esc_attr( $border_color ); ?>; |
||
| 198 | -webkit-box-shadow: 0 1px 0 <?php echo esc_attr( $border_color ); ?>; |
||
| 199 | text-shadow: 0 -1px 1px <?php echo esc_attr( $border_color ); ?>, 1px 0 1px <?php echo esc_attr( $border_color ); ?>, 0 1px 1px <?php echo esc_attr( $border_color ); ?>, -1px 0 1px <?php echo esc_attr( $border_color ); ?>; |
||
| 200 | color: <?php echo esc_attr( $text_color ); ?>; |
||
| 201 | <?php endif; ?> |
||
| 202 | } |
||
| 203 | |||
| 204 | .wp-core-ui .button-primary-disabled, |
||
| 205 | .wp-core-ui .button-primary.disabled, |
||
| 206 | .wp-core-ui .button-primary:disabled, |
||
| 207 | .wp-core-ui .button-primary[disabled] { |
||
| 208 | <?php if ( isset( $config['color_accent'] ) ) : ?> |
||
| 209 | <?php $color_obj = ariColor::newColor( $config['color_accent'] ); ?> |
||
| 210 | <?php $color_obj = ( 35 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness - 30 ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 30 ); ?> |
||
| 211 | <?php $border_color = ( 50 < $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness -15 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness + 15 )->toCSS( $color_obj->mode ); ?> |
||
| 212 | <?php $text_color = ( 60 > $color_obj->lightness ) ? $color_obj->getNew( 'lightness', $color_obj->lightness + 60 )->toCSS( $color_obj->mode ) : $color_obj->getNew( 'lightness', $color_obj->lightness - 60 )->toCSS( $color_obj->mode ); ?> |
||
| 213 | background-color: <?php echo esc_attr( $color_obj->toCSS( $color_obj->mode ) ); ?> !important; |
||
| 214 | border-color: <?php echo esc_attr( $border_color ); ?> !important; |
||
| 215 | box-shadow: 0 1px 0 <?php echo esc_attr( $border_color ); ?> !important; |
||
| 216 | -webkit-box-shadow: 0 1px 0 <?php echo esc_attr( $border_color ); ?> !important; |
||
| 217 | text-shadow: 0 -1px 1px <?php echo esc_attr( $border_color ); ?>, 1px 0 1px <?php echo esc_attr( $border_color ); ?>, 0 1px 1px <?php echo esc_attr( $border_color ); ?>, -1px 0 1px <?php echo esc_attr( $border_color ); ?> !important; |
||
| 218 | color: <?php echo esc_attr( $text_color ); ?> !important; |
||
| 219 | <?php endif; ?> |
||
| 220 | } |
||
| 221 | <?php if ( isset( $config['color_back'] ) ) : ?> |
||
| 222 | .wp-full-overlay-footer .devices { |
||
| 223 | background: none; |
||
| 224 | background: transparent; |
||
| 225 | box-shadow: none; |
||
| 226 | -webkit-box-shadow: none; |
||
| 227 | } |
||
| 228 | <?php endif; ?> |
||
| 229 | <?php if ( isset( $config['width'] ) ) : ?> |
||
| 230 | .wp-full-overlay-sidebar { |
||
| 231 | width: <?php echo esc_attr( $config['width'] ); ?>; |
||
| 232 | } |
||
| 233 | .expanded .wp-full-overlay-footer { |
||
| 234 | <?php if ( false === strpos( $config['width'], 'calc' ) ) : ?> |
||
| 235 | width: calc(<?php echo esc_attr( $config['width'] ); ?> - 1px); |
||
| 236 | <?php else : ?> |
||
| 237 | width: <?php echo esc_attr( $config['width'] ); ?> |
||
| 238 | <?php endif; ?> |
||
| 239 | } |
||
| 240 | |||
| 241 | .wp-full-overlay.expanded { |
||
| 242 | margin-left: <?php echo esc_attr( $config['width'] ); ?>; |
||
| 243 | } |
||
| 244 | .wp-full-overlay.collapsed .wp-full-overlay-sidebar { |
||
| 245 | margin-left: -<?php echo esc_attr( $config['width'] ); ?>; |
||
| 246 | } |
||
| 247 | <?php endif; ?> |
||
| 248 | |||
| 249 | </style> |
||
| 250 | <?php |
||
| 251 | |||
| 252 | } |
||
| 253 | } |
||
| 254 |
If you define a variable conditionally, it can happen that it is not defined for all execution paths.
Let’s take a look at an example:
In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.
Available Fixes
Check for existence of the variable explicitly:
Define a default value for the variable:
Add a value for the missing path: