Conditions | 2 |
Paths | 2 |
Total Lines | 179 |
Code Lines | 42 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
88 | protected function content_template() { |
||
89 | ?> |
||
90 | <label class="customizer-text"> |
||
91 | <# if ( data.label ) { #><span class="customize-control-title">{{{ data.label }}}</span><# } #> |
||
92 | <# if ( data.description ) { #><span class="description customize-control-description">{{{ data.description }}}</span><# } #> |
||
93 | </label> |
||
94 | |||
95 | <div class="wrapper"> |
||
96 | |||
97 | <# if ( data.default['font-family'] ) { #> |
||
98 | <# data.value['font-family'] = data.value['font-family'] || data['default']['font-family']; #> |
||
99 | <# if ( data.choices['fonts'] ) { data.fonts = data.choices['fonts']; } #> |
||
100 | <div class="font-family"> |
||
101 | <h5><?php esc_attr_e( 'Font Family', 'kirki' ); ?></h5> |
||
102 | <select {{{ data.inputAttrs }}} id="kirki-typography-font-family-{{{ data.id }}}" placeholder="<?php esc_attr_e( 'Select Font Family', 'kirki' ); ?>"></select> |
||
103 | </div> |
||
104 | <# if ( ! _.isUndefined( data.choices['font-backup'] ) && true === data.choices['font-backup'] ) { #> |
||
105 | <div class="font-backup hide-on-standard-fonts kirki-font-backup-wrapper"> |
||
106 | <h5><?php esc_attr_e( 'Backup Font', 'kirki' ); ?></h5> |
||
107 | <select {{{ data.inputAttrs }}} id="kirki-typography-font-backup-{{{ data.id }}}" placeholder="<?php esc_attr_e( 'Select Font Family', 'kirki' ); ?>"></select> |
||
108 | </div> |
||
109 | <# } #> |
||
110 | <# if ( true === data.show_variants || false !== data.default.variant ) { #> |
||
111 | <div class="variant kirki-variant-wrapper"> |
||
112 | <h5><?php esc_attr_e( 'Variant', 'kirki' ); ?></h5> |
||
113 | <select {{{ data.inputAttrs }}} class="variant" id="kirki-typography-variant-{{{ data.id }}}"></select> |
||
114 | </div> |
||
115 | <# } #> |
||
116 | <# if ( true === data.show_subsets ) { #> |
||
117 | <div class="subsets hide-on-standard-fonts kirki-subsets-wrapper"> |
||
118 | <h5><?php esc_attr_e( 'Subset(s)', 'kirki' ); ?></h5> |
||
119 | <select {{{ data.inputAttrs }}} class="subset" id="kirki-typography-subsets-{{{ data.id }}}"<# if ( _.isUndefined( data.choices['disable-multiple-variants'] ) || false === data.choices['disable-multiple-variants'] ) { #> multiple<# } #>> |
||
120 | <# _.each( data.value.subsets, function( subset ) { #> |
||
121 | <option value="{{ subset }}" selected="selected">{{ data.languages[ subset ] }}</option> |
||
122 | <# } ); #> |
||
123 | </select> |
||
124 | </div> |
||
125 | <# } #> |
||
126 | <# } #> |
||
127 | |||
128 | <# if ( data.default['font-size'] ) { #> |
||
129 | <# data.value['font-size'] = data.value['font-size'] || data['default']['font-size']; #> |
||
130 | <div class="font-size"> |
||
131 | <h5><?php esc_attr_e( 'Font Size', 'kirki' ); ?></h5> |
||
132 | <input {{{ data.inputAttrs }}} type="text" value="{{ data.value['font-size'] }}"/> |
||
133 | </div> |
||
134 | <# } #> |
||
135 | |||
136 | <# if ( data.default['line-height'] ) { #> |
||
137 | <# data.value['line-height'] = data.value['line-height'] || data['default']['line-height']; #> |
||
138 | <div class="line-height"> |
||
139 | <h5><?php esc_attr_e( 'Line Height', 'kirki' ); ?></h5> |
||
140 | <input {{{ data.inputAttrs }}} type="text" value="{{ data.value['line-height'] }}"/> |
||
141 | </div> |
||
142 | <# } #> |
||
143 | |||
144 | <# if ( data.default['letter-spacing'] ) { #> |
||
145 | <# data.value['letter-spacing'] = data.value['letter-spacing'] || data['default']['letter-spacing']; #> |
||
146 | <div class="letter-spacing"> |
||
147 | <h5><?php esc_attr_e( 'Letter Spacing', 'kirki' ); ?></h5> |
||
148 | <input {{{ data.inputAttrs }}} type="text" value="{{ data.value['letter-spacing'] }}"/> |
||
149 | </div> |
||
150 | <# } #> |
||
151 | |||
152 | <# if ( data.default['word-spacing'] ) { #> |
||
153 | <# data.value['word-spacing'] = data.value['word-spacing'] || data['default']['word-spacing']; #> |
||
154 | <div class="word-spacing"> |
||
155 | <h5><?php esc_attr_e( 'Word Spacing', 'kirki' ); ?></h5> |
||
156 | <input {{{ data.inputAttrs }}} type="text" value="{{ data.value['word-spacing'] }}"/> |
||
157 | </div> |
||
158 | <# } #> |
||
159 | |||
160 | <# if ( data.default['text-align'] ) { #> |
||
161 | <# data.value['text-align'] = data.value['text-align'] || data['default']['text-align']; #> |
||
162 | <div class="text-align"> |
||
163 | <h5><?php esc_attr_e( 'Text Align', 'kirki' ); ?></h5> |
||
164 | <div class="text-align-choices"> |
||
165 | <input {{{ data.inputAttrs }}} type="radio" value="inherit" name="_customize-typography-text-align-radio-{{ data.id }}" id="{{ data.id }}-text-align-inherit" <# if ( data.value['text-align'] === 'inherit' ) { #> checked="checked"<# } #>> |
||
166 | <label for="{{ data.id }}-text-align-inherit"> |
||
167 | <span class="dashicons dashicons-editor-removeformatting"></span> |
||
168 | <span class="screen-reader-text"><?php esc_attr_e( 'Inherit', 'kirki' ); ?></span> |
||
169 | </label> |
||
170 | </input> |
||
171 | <input {{{ data.inputAttrs }}} type="radio" value="left" name="_customize-typography-text-align-radio-{{ data.id }}" id="{{ data.id }}-text-align-left" <# if ( data.value['text-align'] === 'left' ) { #> checked="checked"<# } #>> |
||
172 | <label for="{{ data.id }}-text-align-left"> |
||
173 | <span class="dashicons dashicons-editor-alignleft"></span> |
||
174 | <span class="screen-reader-text"><?php esc_attr_e( 'Left', 'kirki' ); ?></span> |
||
175 | </label> |
||
176 | </input> |
||
177 | <input {{{ data.inputAttrs }}} type="radio" value="center" name="_customize-typography-text-align-radio-{{ data.id }}" id="{{ data.id }}-text-align-center" <# if ( data.value['text-align'] === 'center' ) { #> checked="checked"<# } #>> |
||
178 | <label for="{{ data.id }}-text-align-center"> |
||
179 | <span class="dashicons dashicons-editor-aligncenter"></span> |
||
180 | <span class="screen-reader-text"><?php esc_attr_e( 'Center', 'kirki' ); ?></span> |
||
181 | </label> |
||
182 | </input> |
||
183 | <input {{{ data.inputAttrs }}} type="radio" value="right" name="_customize-typography-text-align-radio-{{ data.id }}" id="{{ data.id }}-text-align-right" <# if ( data.value['text-align'] === 'right' ) { #> checked="checked"<# } #>> |
||
184 | <label for="{{ data.id }}-text-align-right"> |
||
185 | <span class="dashicons dashicons-editor-alignright"></span> |
||
186 | <span class="screen-reader-text"><?php esc_attr_e( 'Right', 'kirki' ); ?></span> |
||
187 | </label> |
||
188 | </input> |
||
189 | <input {{{ data.inputAttrs }}} type="radio" value="justify" name="_customize-typography-text-align-radio-{{ data.id }}" id="{{ data.id }}-text-align-justify" <# if ( data.value['text-align'] === 'justify' ) { #> checked="checked"<# } #>> |
||
190 | <label for="{{ data.id }}-text-align-justify"> |
||
191 | <span class="dashicons dashicons-editor-justify"></span> |
||
192 | <span class="screen-reader-text"><?php esc_attr_e( 'Justify', 'kirki' ); ?></span> |
||
193 | </label> |
||
194 | </input> |
||
195 | </div> |
||
196 | </div> |
||
197 | <# } #> |
||
198 | |||
199 | <# if ( data.default['text-transform'] ) { #> |
||
200 | <# data.value['text-transform'] = data.value['text-transform'] || data['default']['text-transform']; #> |
||
201 | <div class="text-transform"> |
||
202 | <h5><?php esc_attr_e( 'Text Transform', 'kirki' ); ?></h5> |
||
203 | <select {{{ data.inputAttrs }}} id="kirki-typography-text-transform-{{{ data.id }}}"> |
||
204 | <option value="none"<# if ( 'none' === data.value['text-transform'] ) { #>selected<# } #>><?php esc_attr_e( 'None', 'kirki' ); ?></option> |
||
205 | <option value="capitalize"<# if ( 'capitalize' === data.value['text-transform'] ) { #>selected<# } #>><?php esc_attr_e( 'Capitalize', 'kirki' ); ?></option> |
||
206 | <option value="uppercase"<# if ( 'uppercase' === data.value['text-transform'] ) { #>selected<# } #>><?php esc_attr_e( 'Uppercase', 'kirki' ); ?></option> |
||
207 | <option value="lowercase"<# if ( 'lowercase' === data.value['text-transform'] ) { #>selected<# } #>><?php esc_attr_e( 'Lowercase', 'kirki' ); ?></option> |
||
208 | <option value="initial"<# if ( 'initial' === data.value['text-transform'] ) { #>selected<# } #>><?php esc_attr_e( 'Initial', 'kirki' ); ?></option> |
||
209 | <option value="inherit"<# if ( 'inherit' === data.value['text-transform'] ) { #>selected<# } #>><?php esc_attr_e( 'Inherit', 'kirki' ); ?></option> |
||
210 | </select> |
||
211 | </div> |
||
212 | <# } #> |
||
213 | |||
214 | <# if ( data.default['text-decoration'] ) { #> |
||
215 | <# data.value['text-decoration'] = data.value['text-decoration'] || data['default']['text-decoration']; #> |
||
216 | <div class="text-decoration"> |
||
217 | <h5><?php esc_attr_e( 'Text Decoration', 'kirki' ); ?></h5> |
||
218 | <select {{{ data.inputAttrs }}} id="kirki-typography-text-decoration-{{{ data.id }}}"> |
||
219 | <option value="none"<# if ( 'none' === data.value['text-decoration'] ) { #>selected<# } #>><?php esc_attr_e( 'None', 'kirki' ); ?></option> |
||
220 | <option value="underline"<# if ( 'underline' === data.value['text-decoration'] ) { #>selected<# } #>><?php esc_attr_e( 'Underline', 'kirki' ); ?></option> |
||
221 | <option value="overline"<# if ( 'overline' === data.value['text-decoration'] ) { #>selected<# } #>><?php esc_attr_e( 'Overline', 'kirki' ); ?></option> |
||
222 | <option value="line-through"<# if ( 'line-through' === data.value['text-decoration'] ) { #>selected<# } #>><?php esc_attr_e( 'Line-Through', 'kirki' ); ?></option> |
||
223 | <option value="initial"<# if ( 'initial' === data.value['text-decoration'] ) { #>selected<# } #>><?php esc_attr_e( 'Initial', 'kirki' ); ?></option> |
||
224 | <option value="inherit"<# if ( 'inherit' === data.value['text-decoration'] ) { #>selected<# } #>><?php esc_attr_e( 'Inherit', 'kirki' ); ?></option> |
||
225 | </select> |
||
226 | </div> |
||
227 | <# } #> |
||
228 | |||
229 | <# if ( data.default['margin-top'] ) { #> |
||
230 | <# data.value['margin-top'] = data.value['margin-top'] || data['default']['margin-top']; #> |
||
231 | <div class="margin-top"> |
||
232 | <h5><?php esc_attr_e( 'Margin Top', 'kirki' ); ?></h5> |
||
233 | <input {{{ data.inputAttrs }}} type="text" value="{{ data.value['margin-top'] }}"/> |
||
234 | </div> |
||
235 | <# } #> |
||
236 | |||
237 | <# if ( data.default['margin-bottom'] ) { #> |
||
238 | <# data.value['margin-bottom'] = data.value['margin-bottom'] || data['default']['margin-bottom']; #> |
||
239 | <div class="margin-bottom"> |
||
240 | <h5><?php esc_attr_e( 'Margin Bottom', 'kirki' ); ?></h5> |
||
241 | <input {{{ data.inputAttrs }}} type="text" value="{{ data.value['margin-bottom'] }}"/> |
||
242 | </div> |
||
243 | <# } #> |
||
244 | |||
245 | <# if ( false !== data.default['color'] && data.default['color'] ) { #> |
||
246 | <# data.value['color'] = data.value['color'] || data['default']['color']; #> |
||
247 | <div class="color"> |
||
248 | <h5><?php esc_attr_e( 'Color', 'kirki' ); ?></h5> |
||
249 | <input {{{ data.inputAttrs }}} type="text" data-palette="{{ data.palette }}" data-default-color="{{ data.default['color'] }}" value="{{ data.value['color'] }}" class="kirki-color-control"/> |
||
250 | </div> |
||
251 | <# } #> |
||
252 | |||
253 | </div> |
||
254 | <?php if ( Kirki_Util::get_wp_version() >= 4.9 ) : ?> |
||
255 | <input class="typography-hidden-value" type="hidden" {{{ data.link }}}> |
||
256 | <?php return; ?> |
||
257 | <?php endif; ?> |
||
1 ignored issue
–
show
|
|||
258 | <# |
||
259 | if ( ! _.isUndefined( data.value['font-family'] ) ) { |
||
260 | data.value['font-family'] = data.value['font-family'].replace( /"/g, ''' ); |
||
261 | } |
||
262 | valueJSON = JSON.stringify( data.value ).replace( /'/g, ''' ); |
||
263 | #> |
||
264 | <input class="typography-hidden-value" type="hidden" value='{{{ valueJSON }}}' {{{ data.link }}}> |
||
265 | <?php |
||
266 | } |
||
267 | |||
395 |
This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed.
Unreachable code is most often the result of
return
,die
orexit
statements that have been added for debug purposes.In the above example, the last
return false
will never be executed, because a return statement has already been met in every possible execution path.