Complex classes like Kirki_Output often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Kirki_Output, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 15 | class Kirki_Output { |
||
| 16 | |||
| 17 | /** |
||
| 18 | * The Kirki configuration used in the field. |
||
| 19 | * |
||
| 20 | * @access protected |
||
| 21 | * @var string |
||
| 22 | */ |
||
| 23 | protected $config_id = 'global'; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * The field's `output` argument. |
||
| 27 | * |
||
| 28 | * @access protected |
||
| 29 | * @var array |
||
| 30 | */ |
||
| 31 | protected $output = array(); |
||
| 32 | |||
| 33 | /** |
||
| 34 | * An array of the generated styles. |
||
| 35 | * |
||
| 36 | * @access protected |
||
| 37 | * @var array |
||
| 38 | */ |
||
| 39 | protected $styles = array(); |
||
| 40 | |||
| 41 | /** |
||
| 42 | * The value. |
||
| 43 | * |
||
| 44 | * @access protected |
||
| 45 | * @var string|array |
||
| 46 | */ |
||
| 47 | protected $value; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * The class constructor. |
||
| 51 | * |
||
| 52 | * @access public |
||
| 53 | * @param string $config_id The config ID. |
||
| 54 | * @param array $output The output argument. |
||
| 55 | * @param string|array $value The value. |
||
| 56 | * @param array $field The field. |
||
| 57 | */ |
||
| 58 | public function __construct( $config_id, $output, $value, $field ) { |
||
| 59 | |||
| 60 | $this->config_id = $config_id; |
||
| 61 | $this->value = $value; |
||
| 62 | $this->output = $output; |
||
| 63 | $this->field = $field; |
||
|
|
|||
| 64 | |||
| 65 | $this->parse_output(); |
||
| 66 | } |
||
| 67 | |||
| 68 | /** |
||
| 69 | * If we have a sanitize_callback defined, apply it to the value. |
||
| 70 | * |
||
| 71 | * @param array $output The output args. |
||
| 72 | * @param string|array $value The value. |
||
| 73 | * |
||
| 74 | * @return string|array |
||
| 75 | */ |
||
| 76 | protected function apply_sanitize_callback( $output, $value ) { |
||
| 90 | |||
| 91 | /** |
||
| 92 | * If we have a value_pattern defined, apply it to the value. |
||
| 93 | * |
||
| 94 | * @param array $output The output args. |
||
| 95 | * @param string|array $value The value. |
||
| 96 | * @return string|array |
||
| 97 | */ |
||
| 98 | protected function apply_value_pattern( $output, $value ) { |
||
| 122 | |||
| 123 | /** |
||
| 124 | * If we have a value_pattern defined, apply it to the value. |
||
| 125 | * |
||
| 126 | * @param array $output The output args. |
||
| 127 | * @param string|array $value The value. |
||
| 128 | * @return string|array |
||
| 129 | */ |
||
| 130 | protected function apply_pattern_replace( $output, $value ) { |
||
| 179 | |||
| 180 | /** |
||
| 181 | * Parses the output arguments. |
||
| 182 | * Calls the process_output method for each of them. |
||
| 183 | * |
||
| 184 | * @access protected |
||
| 185 | */ |
||
| 186 | protected function parse_output() { |
||
| 243 | |||
| 244 | /** |
||
| 245 | * Parses an output and creates the styles array for it. |
||
| 246 | * |
||
| 247 | * @access protected |
||
| 248 | * @param array $output The field output. |
||
| 249 | * @param string|array $value The value. |
||
| 250 | * |
||
| 251 | * @return null |
||
| 252 | */ |
||
| 253 | protected function process_output( $output, $value ) { |
||
| 278 | |||
| 279 | /** |
||
| 280 | * Some CSS properties are unique. |
||
| 281 | * We need to tweak the value to make everything works as expected. |
||
| 282 | * |
||
| 283 | * @access protected |
||
| 284 | * @param string $property The CSS property. |
||
| 285 | * @param string|array $value The value. |
||
| 286 | * |
||
| 287 | * @return array |
||
| 288 | */ |
||
| 289 | protected function process_property_value( $property, $value ) { |
||
| 304 | |||
| 305 | /** |
||
| 306 | * Returns the value. |
||
| 307 | * |
||
| 308 | * @access protected |
||
| 309 | * @param string|array $value The value. |
||
| 310 | * @param array $output The field "output". |
||
| 311 | * @return string|array |
||
| 312 | */ |
||
| 313 | protected function process_value( $value, $output ) { |
||
| 319 | |||
| 320 | /** |
||
| 321 | * Exploses the private $styles property to the world |
||
| 322 | * |
||
| 323 | * @access protected |
||
| 324 | * @return array |
||
| 325 | */ |
||
| 326 | public function get_styles() { |
||
| 329 | } |
||
| 330 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: