Inspection of "3.0.23" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1728)

by Aristeides

created 2018-01-09 16:07 UTC

Status

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -53,7 +53,7 @@  discard block
 block discarded – undo
 	$config_ids = Kirki_Config::get_config_ids();
 	global $kirki_deprecated_filters_iteration;
 	foreach ( $config_ids as $config_id ) {
-		foreach( array(
+		foreach ( array(
 			'/dynamic_css',
 			'/output/control-classnames',
 			'/css/skip_hidden',
@@ -64,15 +64,15 @@  discard block
 block discarded – undo
 			$kirki_deprecated_filters_iteration = array( $config_id, $filter_suffix );
 			add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
 				global $kirki_deprecated_filters_iteration;
-				$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
-				return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
+				$kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
+				return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[ 0 ]}/{$kirki_deprecated_filters_iteration[ 1 ]}", $args );
 			}, 99 );
-			if ( false !== strpos( $kirki_deprecated_filters_iteration[1], '-' ) ) {
-				$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
+			if ( false !== strpos( $kirki_deprecated_filters_iteration[ 1 ], '-' ) ) {
+				$kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
 				add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
 					global $kirki_deprecated_filters_iteration;
-					$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
-					return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
+					$kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
+					return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[ 0 ]}/{$kirki_deprecated_filters_iteration[ 1 ]}", $args );
 				}, 99 );
 			}
 		}

Please login to merge, or discard this patch.

Braces +48 added lines, -24 removed lines patch added patch discarded remove patch

@@ -1,55 +1,68 @@  discard block
 block discarded – undo
 <?php
 // @codingStandardsIgnoreFile
 
-add_filter( 'kirki_config', function( $args ) {
+add_filter( 'kirki_config', function( $args )
+{
 	return apply_filters( 'kirki/config', $args );
 }, 99 );
 
-add_filter( 'kirki_control_types', function( $args ) {
+add_filter( 'kirki_control_types', function( $args )
+{
 	return apply_filters( 'kirki/control_types', $args );
 }, 99 );
 
-add_filter( 'kirki_section_types', function( $args ) {
+add_filter( 'kirki_section_types', function( $args )
+{
 	return apply_filters( 'kirki/section_types', $args );
 }, 99 );
 
-add_filter( 'kirki_section_types_exclude', function( $args ) {
+add_filter( 'kirki_section_types_exclude', function( $args )
+{
 	return apply_filters( 'kirki/section_types/exclude', $args );
 }, 99 );
 
-add_filter( 'kirki_control_types_exclude', function( $args ) {
+add_filter( 'kirki_control_types_exclude', function( $args )
+{
 	return apply_filters( 'kirki/control_types/exclude', $args );
 }, 99 );
 
-add_filter( 'kirki_controls', function( $args ) {
+add_filter( 'kirki_controls', function( $args )
+{
 	return apply_filters( 'kirki/controls', $args );
 }, 99 );
 
-add_filter( 'kirki_fields', function( $args ) {
+add_filter( 'kirki_fields', function( $args )
+{
 	return apply_filters( 'kirki/fields', $args );
 }, 99 );
 
-add_filter( 'kirki_modules', function( $args ) {
+add_filter( 'kirki_modules', function( $args )
+{
 	return apply_filters( 'kirki/modules', $args );
 }, 99 );
 
-add_filter( 'kirki_panel_types', function( $args ) {
+add_filter( 'kirki_panel_types', function( $args )
+{
 	return apply_filters( 'kirki/panel_types', $args );
 }, 99 );
 
-add_filter( 'kirki_setting_types', function( $args ) {
+add_filter( 'kirki_setting_types', function( $args )
+{
 	return apply_filters( 'kirki/setting_types', $args );
 }, 99 );
 
-add_filter( 'kirki_variable', function( $args ) {
+add_filter( 'kirki_variable', function( $args )
+{
 	return apply_filters( 'kirki/variable', $args );
 }, 99 );
 
-add_filter( 'kirki_values_get_value', function( $arg1, $arg2 ) {
+add_filter( 'kirki_values_get_value', function( $arg1, $arg2 )
+{
 	return apply_filters( 'kirki/values/get_value', $arg1, $arg2 );
 }, 99, 2 );
 
-add_action( 'init', function() {
+add_action( 'init', function()
+{
 	$config_ids = Kirki_Config::get_config_ids();
 	global $kirki_deprecated_filters_iteration;
 	foreach ( $config_ids as $config_id ) {
@@ -62,14 +75,16 @@  discard block
 block discarded – undo
 			'/webfonts/skip_hidden',
 		) as $filter_suffix ) {
 			$kirki_deprecated_filters_iteration = array( $config_id, $filter_suffix );
-			add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
+			add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args )
+			{
 				global $kirki_deprecated_filters_iteration;
 				$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
 				return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
 			}, 99 );
 			if ( false !== strpos( $kirki_deprecated_filters_iteration[1], '-' ) ) {
 				$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
-				add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
+				add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args )
+				{
 					global $kirki_deprecated_filters_iteration;
 					$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
 					return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
@@ -79,38 +94,47 @@  discard block
 block discarded – undo
 	}
 }, 99 );
 
-add_filter( 'kirki_enqueue_google_fonts', function( $args ) {
+add_filter( 'kirki_enqueue_google_fonts', function( $args )
+{
 	return apply_filters( 'kirki/enqueue_google_fonts', $args );
 }, 99 );
 
-add_filter( 'kirki_styles_array', function( $args ) {
+add_filter( 'kirki_styles_array', function( $args )
+{
 	return apply_filters( 'kirki/styles_array', $args );
 }, 99 );
 
-add_filter( 'kirki_dynamic_css_method', function( $args ) {
+add_filter( 'kirki_dynamic_css_method', function( $args )
+{
 	return apply_filters( 'kirki/dynamic_css/method', $args );
 }, 99 );
 
-add_filter( 'kirki_postmessage_script', function( $args ) {
+add_filter( 'kirki_postmessage_script', function( $args )
+{
 	return apply_filters( 'kirki/postmessage/script', $args );
 }, 99 );
 
-add_filter( 'kirki_fonts_all', function( $args ) {
+add_filter( 'kirki_fonts_all', function( $args )
+{
 	return apply_filters( 'kirki/fonts/all', $args );
 }, 99 );
 
-add_filter( 'kirki_fonts_standard_fonts', function( $args ) {
+add_filter( 'kirki_fonts_standard_fonts', function( $args )
+{
 	return apply_filters( 'kirki/fonts/standard_fonts', $args );
 }, 99 );
 
-add_filter( 'kirki_fonts_backup_fonts', function( $args ) {
+add_filter( 'kirki_fonts_backup_fonts', function( $args )
+{
 	return apply_filters( 'kirki/fonts/backup_fonts', $args );
 }, 99 );
 
-add_filter( 'kirki_fonts_google_fonts', function( $args ) {
+add_filter( 'kirki_fonts_google_fonts', function( $args )
+{
 	return apply_filters( 'kirki/fonts/google_fonts', $args );
 }, 99 );
 
-add_filter( 'kirki_googlefonts_load_method', function( $args ) {
+add_filter( 'kirki_googlefonts_load_method', function( $args )
+{
 	return apply_filters( 'kirki/googlefonts_load_method', $args );
 }, 99 );

Please login to merge, or discard this patch.

field/class-kirki-field-code.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -59,10 +59,10 @@  discard block
 block discarded – undo
 	 * @access protected
 	 */
 	protected function set_choices() {
-		if ( ! isset( $this->choices['language'] ) ) {
+		if ( ! isset( $this->choices[ 'language' ] ) ) {
 			return;
 		}
-		$language = $this->choices['language'];
+		$language = $this->choices[ 'language' ];
 		switch ( $language ) {
 			case 'json':
 			case 'xml':
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
 				$language = 'text/x-' . $language;
 				break;
 		}
-		if ( ! isset( $this->editor_settings['codemirror'] ) ) {
-			$this->editor_settings['codemirror'] = array();
+		if ( ! isset( $this->editor_settings[ 'codemirror' ] ) ) {
+			$this->editor_settings[ 'codemirror' ] = array();
 		}
-		if ( ! isset( $this->editor_settings['codemirror']['mode'] ) ) {
-			$this->editor_settings['codemirror']['mode'] = $language;
+		if ( ! isset( $this->editor_settings[ 'codemirror' ][ 'mode' ] ) ) {
+			$this->editor_settings[ 'codemirror' ][ 'mode' ] = $language;
 		}
 	}
 

Please login to merge, or discard this patch.

field/class-kirki-field-image.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -60,14 +60,14 @@  discard block
 block discarded – undo
 		if ( ! is_array( $this->choices ) ) {
 			$this->choices = (array) $this->choices;
 		}
-		if ( ! isset( $this->choices['save_as'] ) ) {
-			$this->choices['save_as'] = 'url';
+		if ( ! isset( $this->choices[ 'save_as' ] ) ) {
+			$this->choices[ 'save_as' ] = 'url';
 		}
-		if ( ! isset( $this->choices['labels'] ) ) {
-			$this->choices['labels'] = array();
+		if ( ! isset( $this->choices[ 'labels' ] ) ) {
+			$this->choices[ 'labels' ] = array();
 		}
 		$this->set_button_labels();
-		$this->choices['labels'] = wp_parse_args( $this->choices['labels'], $this->button_labels );
+		$this->choices[ 'labels' ] = wp_parse_args( $this->choices[ 'labels' ], $this->button_labels );
 	}
 
 	/**
@@ -93,15 +93,15 @@  discard block
 block discarded – undo
 	 */
 	public function sanitize( $value ) {
 
-		if ( isset( $this->choices['save_as'] ) && 'array' === $this->choices['save_as'] ) {
+		if ( isset( $this->choices[ 'save_as' ] ) && 'array' === $this->choices[ 'save_as' ] ) {
 			return array(
-				'id'     => ( isset( $value['id'] ) && '' !== $value['id'] ) ? (int) $value['id'] : '',
-				'url'    => ( isset( $value['url'] ) && '' !== $value['url'] ) ? esc_url_raw( $value['url'] ) : '',
-				'width'  => ( isset( $value['width'] ) && '' !== $value['width'] ) ? (int) $value['width'] : '',
-				'height' => ( isset( $value['height'] ) && '' !== $value['height'] ) ? (int) $value['height'] : '',
+				'id'     => ( isset( $value[ 'id' ] ) && '' !== $value[ 'id' ] ) ? (int) $value[ 'id' ] : '',
+				'url'    => ( isset( $value[ 'url' ] ) && '' !== $value[ 'url' ] ) ? esc_url_raw( $value[ 'url' ] ) : '',
+				'width'  => ( isset( $value[ 'width' ] ) && '' !== $value[ 'width' ] ) ? (int) $value[ 'width' ] : '',
+				'height' => ( isset( $value[ 'height' ] ) && '' !== $value[ 'height' ] ) ? (int) $value[ 'height' ] : '',
 			);
 		}
-		if ( isset( $this->choices['save_as'] ) && 'id' === $this->choices['save_as'] ) {
+		if ( isset( $this->choices[ 'save_as' ] ) && 'id' === $this->choices[ 'save_as' ] ) {
 			return absint( $value );
 		}
 		if ( is_string( $value ) ) {

Please login to merge, or discard this patch.

		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	$config_ids = Kirki_Config::get_config_ids();
54	54	global $kirki_deprecated_filters_iteration;
55	55	foreach ( $config_ids as $config_id ) {
56		- foreach( array(
	56	+ foreach ( array(
57	57	'/dynamic_css',
58	58	'/output/control-classnames',
59	59	'/css/skip_hidden',
		@@ -64,15 +64,15 @@ discard block
		block discarded – undo
64	64	$kirki_deprecated_filters_iteration = array( $config_id, $filter_suffix );
65	65	add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
66	66	global $kirki_deprecated_filters_iteration;
67		- $kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
68		- return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
	67	+ $kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
	68	+ return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[ 0 ]}/{$kirki_deprecated_filters_iteration[ 1 ]}", $args );
69	69	}, 99 );
70		- if ( false !== strpos( $kirki_deprecated_filters_iteration[1], '-' ) ) {
71		- $kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
	70	+ if ( false !== strpos( $kirki_deprecated_filters_iteration[ 1 ], '-' ) ) {
	71	+ $kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
72	72	add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
73	73	global $kirki_deprecated_filters_iteration;
74		- $kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
75		- return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
	74	+ $kirki_deprecated_filters_iteration[ 1 ] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[ 1 ] );
	75	+ return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[ 0 ]}/{$kirki_deprecated_filters_iteration[ 1 ]}", $args );
76	76	}, 99 );
77	77	}
78	78	}

		@@ -1,55 +1,68 @@ discard block
		block discarded – undo
1	1	<?php
2	2	// @codingStandardsIgnoreFile
3	3
4		-add_filter( 'kirki_config', function( $args ) {
	4	+add_filter( 'kirki_config', function( $args )
	5	+{
5	6	return apply_filters( 'kirki/config', $args );
6	7	}, 99 );
7	8
8		-add_filter( 'kirki_control_types', function( $args ) {
	9	+add_filter( 'kirki_control_types', function( $args )
	10	+{
9	11	return apply_filters( 'kirki/control_types', $args );
10	12	}, 99 );
11	13
12		-add_filter( 'kirki_section_types', function( $args ) {
	14	+add_filter( 'kirki_section_types', function( $args )
	15	+{
13	16	return apply_filters( 'kirki/section_types', $args );
14	17	}, 99 );
15	18
16		-add_filter( 'kirki_section_types_exclude', function( $args ) {
	19	+add_filter( 'kirki_section_types_exclude', function( $args )
	20	+{
17	21	return apply_filters( 'kirki/section_types/exclude', $args );
18	22	}, 99 );
19	23
20		-add_filter( 'kirki_control_types_exclude', function( $args ) {
	24	+add_filter( 'kirki_control_types_exclude', function( $args )
	25	+{
21	26	return apply_filters( 'kirki/control_types/exclude', $args );
22	27	}, 99 );
23	28
24		-add_filter( 'kirki_controls', function( $args ) {
	29	+add_filter( 'kirki_controls', function( $args )
	30	+{
25	31	return apply_filters( 'kirki/controls', $args );
26	32	}, 99 );
27	33
28		-add_filter( 'kirki_fields', function( $args ) {
	34	+add_filter( 'kirki_fields', function( $args )
	35	+{
29	36	return apply_filters( 'kirki/fields', $args );
30	37	}, 99 );
31	38
32		-add_filter( 'kirki_modules', function( $args ) {
	39	+add_filter( 'kirki_modules', function( $args )
	40	+{
33	41	return apply_filters( 'kirki/modules', $args );
34	42	}, 99 );
35	43
36		-add_filter( 'kirki_panel_types', function( $args ) {
	44	+add_filter( 'kirki_panel_types', function( $args )
	45	+{
37	46	return apply_filters( 'kirki/panel_types', $args );
38	47	}, 99 );
39	48
40		-add_filter( 'kirki_setting_types', function( $args ) {
	49	+add_filter( 'kirki_setting_types', function( $args )
	50	+{
41	51	return apply_filters( 'kirki/setting_types', $args );
42	52	}, 99 );
43	53
44		-add_filter( 'kirki_variable', function( $args ) {
	54	+add_filter( 'kirki_variable', function( $args )
	55	+{
45	56	return apply_filters( 'kirki/variable', $args );
46	57	}, 99 );
47	58
48		-add_filter( 'kirki_values_get_value', function( $arg1, $arg2 ) {
	59	+add_filter( 'kirki_values_get_value', function( $arg1, $arg2 )
	60	+{
49	61	return apply_filters( 'kirki/values/get_value', $arg1, $arg2 );
50	62	}, 99, 2 );
51	63
52		-add_action( 'init', function() {
	64	+add_action( 'init', function()
	65	+{
53	66	$config_ids = Kirki_Config::get_config_ids();
54	67	global $kirki_deprecated_filters_iteration;
55	68	foreach ( $config_ids as $config_id ) {
		@@ -62,14 +75,16 @@ discard block
		block discarded – undo
62	75	'/webfonts/skip_hidden',
63	76	) as $filter_suffix ) {
64	77	$kirki_deprecated_filters_iteration = array( $config_id, $filter_suffix );
65		- add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
	78	+ add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args )
	79	+ {
66	80	global $kirki_deprecated_filters_iteration;
67	81	$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
68	82	return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
69	83	}, 99 );
70	84	if ( false !== strpos( $kirki_deprecated_filters_iteration[1], '-' ) ) {
71	85	$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
72		- add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args ) {
	86	+ add_filter( "kirki_{$config_id}_{$filter_suffix}", function( $args )
	87	+ {
73	88	global $kirki_deprecated_filters_iteration;
74	89	$kirki_deprecated_filters_iteration[1] = str_replace( '-', '_', $kirki_deprecated_filters_iteration[1] );
75	90	return apply_filters( "kirki/{$kirki_deprecated_filters_iteration[0]}/{$kirki_deprecated_filters_iteration[1]}", $args );
		@@ -79,38 +94,47 @@ discard block
		block discarded – undo
79	94	}
80	95	}, 99 );
81	96
82		-add_filter( 'kirki_enqueue_google_fonts', function( $args ) {
	97	+add_filter( 'kirki_enqueue_google_fonts', function( $args )
	98	+{
83	99	return apply_filters( 'kirki/enqueue_google_fonts', $args );
84	100	}, 99 );
85	101
86		-add_filter( 'kirki_styles_array', function( $args ) {
	102	+add_filter( 'kirki_styles_array', function( $args )
	103	+{
87	104	return apply_filters( 'kirki/styles_array', $args );
88	105	}, 99 );
89	106
90		-add_filter( 'kirki_dynamic_css_method', function( $args ) {
	107	+add_filter( 'kirki_dynamic_css_method', function( $args )
	108	+{
91	109	return apply_filters( 'kirki/dynamic_css/method', $args );
92	110	}, 99 );
93	111
94		-add_filter( 'kirki_postmessage_script', function( $args ) {
	112	+add_filter( 'kirki_postmessage_script', function( $args )
	113	+{
95	114	return apply_filters( 'kirki/postmessage/script', $args );
96	115	}, 99 );
97	116
98		-add_filter( 'kirki_fonts_all', function( $args ) {
	117	+add_filter( 'kirki_fonts_all', function( $args )
	118	+{
99	119	return apply_filters( 'kirki/fonts/all', $args );
100	120	}, 99 );
101	121
102		-add_filter( 'kirki_fonts_standard_fonts', function( $args ) {
	122	+add_filter( 'kirki_fonts_standard_fonts', function( $args )
	123	+{
103	124	return apply_filters( 'kirki/fonts/standard_fonts', $args );
104	125	}, 99 );
105	126
106		-add_filter( 'kirki_fonts_backup_fonts', function( $args ) {
	127	+add_filter( 'kirki_fonts_backup_fonts', function( $args )
	128	+{
107	129	return apply_filters( 'kirki/fonts/backup_fonts', $args );
108	130	}, 99 );
109	131
110		-add_filter( 'kirki_fonts_google_fonts', function( $args ) {
	132	+add_filter( 'kirki_fonts_google_fonts', function( $args )
	133	+{
111	134	return apply_filters( 'kirki/fonts/google_fonts', $args );
112	135	}, 99 );
113	136
114		-add_filter( 'kirki_googlefonts_load_method', function( $args ) {
	137	+add_filter( 'kirki_googlefonts_load_method', function( $args )
	138	+{
115	139	return apply_filters( 'kirki/googlefonts_load_method', $args );
116	140	}, 99 );

		@@ -59,10 +59,10 @@ discard block
		block discarded – undo
59	59	* @access protected
60	60	*/
61	61	protected function set_choices() {
62		- if ( ! isset( $this->choices['language'] ) ) {
	62	+ if ( ! isset( $this->choices[ 'language' ] ) ) {
63	63	return;
64	64	}
65		- $language = $this->choices['language'];
	65	+ $language = $this->choices[ 'language' ];
66	66	switch ( $language ) {
67	67	case 'json':
68	68	case 'xml':
		@@ -90,11 +90,11 @@ discard block
		block discarded – undo
90	90	$language = 'text/x-' . $language;
91	91	break;
92	92	}
93		- if ( ! isset( $this->editor_settings['codemirror'] ) ) {
94		- $this->editor_settings['codemirror'] = array();
	93	+ if ( ! isset( $this->editor_settings[ 'codemirror' ] ) ) {
	94	+ $this->editor_settings[ 'codemirror' ] = array();
95	95	}
96		- if ( ! isset( $this->editor_settings['codemirror']['mode'] ) ) {
97		- $this->editor_settings['codemirror']['mode'] = $language;
	96	+ if ( ! isset( $this->editor_settings[ 'codemirror' ][ 'mode' ] ) ) {
	97	+ $this->editor_settings[ 'codemirror' ][ 'mode' ] = $language;
98	98	}
99	99	}
100	100

		@@ -60,14 +60,14 @@ discard block
		block discarded – undo
60	60	if ( ! is_array( $this->choices ) ) {
61	61	$this->choices = (array) $this->choices;
62	62	}
63		- if ( ! isset( $this->choices['save_as'] ) ) {
64		- $this->choices['save_as'] = 'url';
	63	+ if ( ! isset( $this->choices[ 'save_as' ] ) ) {
	64	+ $this->choices[ 'save_as' ] = 'url';
65	65	}
66		- if ( ! isset( $this->choices['labels'] ) ) {
67		- $this->choices['labels'] = array();
	66	+ if ( ! isset( $this->choices[ 'labels' ] ) ) {
	67	+ $this->choices[ 'labels' ] = array();
68	68	}
69	69	$this->set_button_labels();
70		- $this->choices['labels'] = wp_parse_args( $this->choices['labels'], $this->button_labels );
	70	+ $this->choices[ 'labels' ] = wp_parse_args( $this->choices[ 'labels' ], $this->button_labels );
71	71	}
72	72
73	73	/**
		@@ -93,15 +93,15 @@ discard block
		block discarded – undo
93	93	*/
94	94	public function sanitize( $value ) {
95	95
96		- if ( isset( $this->choices['save_as'] ) && 'array' === $this->choices['save_as'] ) {
	96	+ if ( isset( $this->choices[ 'save_as' ] ) && 'array' === $this->choices[ 'save_as' ] ) {
97	97	return array(
98		- 'id' => ( isset( $value['id'] ) && '' !== $value['id'] ) ? (int) $value['id'] : '',
99		- 'url' => ( isset( $value['url'] ) && '' !== $value['url'] ) ? esc_url_raw( $value['url'] ) : '',
100		- 'width' => ( isset( $value['width'] ) && '' !== $value['width'] ) ? (int) $value['width'] : '',
101		- 'height' => ( isset( $value['height'] ) && '' !== $value['height'] ) ? (int) $value['height'] : '',
	98	+ 'id' => ( isset( $value[ 'id' ] ) && '' !== $value[ 'id' ] ) ? (int) $value[ 'id' ] : '',
	99	+ 'url' => ( isset( $value[ 'url' ] ) && '' !== $value[ 'url' ] ) ? esc_url_raw( $value[ 'url' ] ) : '',
	100	+ 'width' => ( isset( $value[ 'width' ] ) && '' !== $value[ 'width' ] ) ? (int) $value[ 'width' ] : '',
	101	+ 'height' => ( isset( $value[ 'height' ] ) && '' !== $value[ 'height' ] ) ? (int) $value[ 'height' ] : '',
102	102	);
103	103	}
104		- if ( isset( $this->choices['save_as'] ) && 'id' === $this->choices['save_as'] ) {
	104	+ if ( isset( $this->choices[ 'save_as' ] ) && 'id' === $this->choices[ 'save_as' ] ) {
105	105	return absint( $value );
106	106	}
107	107	if ( is_string( $value ) ) {

aristath / kirki

Pull Request — master (#1728)

Status

Category

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Braces +48 added lines, -24 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch