Inspection of "coding improvements" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (1becb4)

by Aristeides

created 2016-03-11 19:37 UTC

Status

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * palette Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * palette Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-radio-buttonset-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * radio-buttonset Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * radio-buttonset Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-radio-image-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * radio-image Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * radio-image Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-repeater-control.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * Repeater Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * Repeater Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -34,13 +34,13 @@  discard block
 block discarded – undo
 
 			foreach ( $args['fields'] as $key => $value ) {
 				if ( ! isset( $value['default'] ) ) {
-					$args['fields'][ $key ]['default'] = '';
+					$args['fields'][$key]['default'] = '';
 				}
 
 				if ( ! isset( $value['label'] ) ) {
-					$args['fields'][ $key ]['label'] = '';
+					$args['fields'][$key]['label'] = '';
 				}
-				$args['fields'][ $key ]['id'] = $key;
+				$args['fields'][$key]['id'] = $key;
 			}
 
 			$this->fields = $args['fields'];
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
 					continue;
 				}
 
-				$fields[ $key ]['buttonLabels'] = $default_image_button_labels;
+				$fields[$key]['buttonLabels'] = $default_image_button_labels;
 			}
 
 			$this->json['fields'] = $fields;

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-select-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * select2 Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * select2 Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-slider-control.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * slider Customizer Control.
- *
- * Creates a jQuery slider control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * slider Customizer Control.
+	 *
+	 * Creates a jQuery slider control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-sortable-control.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * sortable Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * sortable Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -55,7 +55,7 @@
 block discarded – undo
 			if ( is_array( $values ) && ! empty( $values ) ) {
 				foreach ( $values as $key => $value ) {
 					if ( array_key_exists( $value, $this->choices ) ) {
-						$filtered_values[ $key ] = $value;
+						$filtered_values[$key] = $value;
 					}
 				}
 			}

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-spacing-control.php 2 patches

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * spacing Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.1
- */
+	 * spacing Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.1
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -26,15 +26,15 @@
 block discarded – undo
 			if ( is_array( $this->choices ) ) {
 				foreach ( $this->choices as $choice => $value ) {
 					if ( true === $value ) {
-						$this->json['choices'][ $choice ] = true;
+						$this->json['choices'][$choice] = true;
 					}
 				}
 			}
 
 			if ( is_array( $this->json['default'] ) ) {
 				foreach ( $this->json['default'] as $key => $value ) {
-					if ( isset( $this->json['choices'][ $key ] ) && ! isset( $this->json['value'][ $key ] ) ) {
-						$this->json['value'][ $key ] = $value;
+					if ( isset( $this->json['choices'][$key] ) && ! isset( $this->json['value'][$key] ) ) {
+						$this->json['value'][$key] = $value;
 					}
 				}
 			}

Please login to merge, or discard this patch.

includes/controls/class-kirki-controls-switch-control.php 1 patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 /**
- * switch Customizer Control.
- *
- * @package     Kirki
- * @subpackage  Controls
- * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
- * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
- * @since       1.0
- */
+	 * switch Customizer Control.
+	 *
+	 * @package     Kirki
+	 * @subpackage  Controls
+	 * @copyright   Copyright (c) 2016, Aristeides Stathopoulos
+	 * @license     http://opensource.org/licenses/gpl-2.0.php GNU Public License
+	 * @since       1.0
+	 */
 
 // Exit if accessed directly
 if ( ! defined( 'ABSPATH' ) ) {

Please login to merge, or discard this patch.

		@@ -34,13 +34,13 @@ discard block
		block discarded – undo
34	34
35	35	foreach ( $args['fields'] as $key => $value ) {
36	36	if ( ! isset( $value['default'] ) ) {
37		- $args['fields'][ $key ]['default'] = '';
	37	+ $args['fields'][$key]['default'] = '';
38	38	}
39	39
40	40	if ( ! isset( $value['label'] ) ) {
41		- $args['fields'][ $key ]['label'] = '';
	41	+ $args['fields'][$key]['label'] = '';
42	42	}
43		- $args['fields'][ $key ]['id'] = $key;
	43	+ $args['fields'][$key]['id'] = $key;
44	44	}
45	45
46	46	$this->fields = $args['fields'];
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	continue;
64	64	}
65	65
66		- $fields[ $key ]['buttonLabels'] = $default_image_button_labels;
	66	+ $fields[$key]['buttonLabels'] = $default_image_button_labels;
67	67	}
68	68
69	69	$this->json['fields'] = $fields;

		@@ -55,7 +55,7 @@
		block discarded – undo
55	55	if ( is_array( $values ) && ! empty( $values ) ) {
56	56	foreach ( $values as $key => $value ) {
57	57	if ( array_key_exists( $value, $this->choices ) ) {
58		- $filtered_values[ $key ] = $value;
	58	+ $filtered_values[$key] = $value;
59	59	}
60	60	}
61	61	}

		@@ -26,15 +26,15 @@
		block discarded – undo
26	26	if ( is_array( $this->choices ) ) {
27	27	foreach ( $this->choices as $choice => $value ) {
28	28	if ( true === $value ) {
29		- $this->json['choices'][ $choice ] = true;
	29	+ $this->json['choices'][$choice] = true;
30	30	}
31	31	}
32	32	}
33	33
34	34	if ( is_array( $this->json['default'] ) ) {
35	35	foreach ( $this->json['default'] as $key => $value ) {
36		- if ( isset( $this->json['choices'][ $key ] ) && ! isset( $this->json['value'][ $key ] ) ) {
37		- $this->json['value'][ $key ] = $value;
	36	+ if ( isset( $this->json['choices'][$key] ) && ! isset( $this->json['value'][$key] ) ) {
	37	+ $this->json['value'][$key] = $value;
38	38	}
39	39	}
40	40	}

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * palette Customizer Control.
4		- *
5		- * @package Kirki
6		- * @subpackage Controls
7		- * @copyright Copyright (c) 2016, Aristeides Stathopoulos
8		- * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
9		- * @since 1.0
10		- */
	3	+ * palette Customizer Control.
	4	+ *
	5	+ * @package Kirki
	6	+ * @subpackage Controls
	7	+ * @copyright Copyright (c) 2016, Aristeides Stathopoulos
	8	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
	9	+ * @since 1.0
	10	+ */
11	11
12	12	// Exit if accessed directly
13	13	if ( ! defined( 'ABSPATH' ) ) {

		@@ -1,15 +1,15 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * slider Customizer Control.
4		- *
5		- * Creates a jQuery slider control.
6		- *
7		- * @package Kirki
8		- * @subpackage Controls
9		- * @copyright Copyright (c) 2016, Aristeides Stathopoulos
10		- * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
11		- * @since 1.0
12		- */
	3	+ * slider Customizer Control.
	4	+ *
	5	+ * Creates a jQuery slider control.
	6	+ *
	7	+ * @package Kirki
	8	+ * @subpackage Controls
	9	+ * @copyright Copyright (c) 2016, Aristeides Stathopoulos
	10	+ * @license http://opensource.org/licenses/gpl-2.0.php GNU Public License
	11	+ * @since 1.0
	12	+ */
13	13
14	14	// Exit if accessed directly
15	15	if ( ! defined( 'ABSPATH' ) ) {

aristath / kirki

Branch — develop (1becb4)

Status

Category

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch