Kirki_Output_Field_Typography::process_output() - Code Metrics - Inspection of "fix quotes for font-families" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 1afbdc...5783f5 )

by Aristeides

created 2017-05-31 11:19 UTC

Kirki_Output_Field_Typography::process_output() D

↳ Parent: Kirki_Output_Field_Typography

Complexity

Conditions	15
Paths	192

Size

Total Lines	44
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	15
eloc	31
nc	192
nop	2
dl	0
loc	44
rs	4.7582
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 * Handles CSS output for typography fields.
 *
 * @package     Kirki
 * @subpackage  Controls
 * @copyright   Copyright (c) 2017, Aristeides Stathopoulos
 * @license     http://opensource.org/licenses/https://opensource.org/licenses/MIT
 * @since       2.2.0
 */

/**
 * Output overrides.
 */
class Kirki_Output_Field_Typography extends Kirki_Output {

	/**
	 * Processes a single item from the `output` array.
	 *
	 * @access protected
	 * @param array $output The `output` item.
	 * @param array $value  The field's value.
	 */
	protected function process_output( $output, $value ) {

		$output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global';
		$output['element']     = ( isset( $output['element'] ) ) ? $output['element'] : 'body';
		$output['prefix']      = ( isset( $output['prefix'] ) ) ? $output['prefix'] : '';
		$output['suffix']      = ( isset( $output['suffix'] ) ) ? $output['suffix'] : '';

		if ( ! isset( $value['variant'] ) || ! isset( $value['font-weight'] ) || ! isset( $value['font-style'] ) ) {
			$value = Kirki_Field_Typography::sanitize( $value );
			$this->value = $value;
		}

		$properties = array(
			'font-family',
			'font-size',
			'font-weight',
			'font-style',
			'letter-spacing',
			'word-spacing',
			'line-height',
			'text-align',
			'text-transform',
			'color',
		);

		foreach ( $properties as $property ) {
			if ( ! isset( $value[ $property ] ) || '' === $value[ $property ] ) {
				continue;
			}
			if ( isset( $output['choice'] ) && $output['choice'] !== $property ) {
				continue;
			}

			$property_value = $this->process_property_value( $property, $value[ $property ] );
			if ( 'font-family' === $property ) {
				$value['font-backup'] = ( isset( $value['font-backup'] ) ) ? $value['font-backup'] : '';
				$property_value = $this->process_property_value( $property, array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
					$value['font-family'],
					$value['font-backup'],
				) );
			}
			$this->styles[ $output['media_query'] ][ $output['element'] ][ $property ] = $output['prefix'] . $property_value . $output['suffix'];
		}
	}
}


1			<?php
2			/**
3			* Handles CSS output for typography fields.
4			*
5			* @package Kirki
6			* @subpackage Controls
7			* @copyright Copyright (c) 2017, Aristeides Stathopoulos
8			* @license http://opensource.org/licenses/https://opensource.org/licenses/MIT
9			* @since 2.2.0
10			*/
11
12			/**
13			* Output overrides.
14			*/
15			class Kirki_Output_Field_Typography extends Kirki_Output {
16
17			/**
18			* Processes a single item from the `output` array.
19			*
20			* @access protected
21			* @param array $output The `output` item.
22			* @param array $value The field's value.
23			*/
24			protected function process_output( $output, $value ) {
25
26			$output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global';
27			$output['element'] = ( isset( $output['element'] ) ) ? $output['element'] : 'body';
28			$output['prefix'] = ( isset( $output['prefix'] ) ) ? $output['prefix'] : '';
29			$output['suffix'] = ( isset( $output['suffix'] ) ) ? $output['suffix'] : '';
30
31			if ( ! isset( $value['variant'] ) \|\| ! isset( $value['font-weight'] ) \|\| ! isset( $value['font-style'] ) ) {
32			$value = Kirki_Field_Typography::sanitize( $value );
33			$this->value = $value;
34			}
35
36			$properties = array(
37			'font-family',
38			'font-size',
39			'font-weight',
40			'font-style',
41			'letter-spacing',
42			'word-spacing',
43			'line-height',
44			'text-align',
45			'text-transform',
46			'color',
47			);
48
49			foreach ( $properties as $property ) {
50			if ( ! isset( $value[ $property ] ) \|\| '' === $value[ $property ] ) {
51			continue;
52			}
53			if ( isset( $output['choice'] ) && $output['choice'] !== $property ) {
54			continue;
55			}
56
57			$property_value = $this->process_property_value( $property, $value[ $property ] );
58			if ( 'font-family' === $property ) {
59			$value['font-backup'] = ( isset( $value['font-backup'] ) ) ? $value['font-backup'] : '';
60			$property_value = $this->process_property_value( $property, array(
			0 ignored issues – show Documentation introduced 2017-05-31 11:22 UTC by Report Bug Copy Issue Report `array($value['font-famil... $value['font-backup'])` is of type `array<integer,?,{"0":"?","1":"?"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			$value['font-family'],
62			$value['font-backup'],
63			) );
64			}
65			$this->styles[ $output['media_query'] ][ $output['element'] ][ $property ] = $output['prefix'] . $property_value . $output['suffix'];
66			}
67			}
68			}
69

aristath / kirki

Push — develop ( 1afbdc...5783f5 )

Kirki_Output_Field_Typography::process_output() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like