aristath /
kirki
| Conditions | 18 |
| Paths | 2048 |
| Total Lines | 38 |
| Code Lines | 18 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 24 | protected function process_output( $output, $value ) { |
||
| 25 | |||
| 26 | $output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global'; |
||
| 27 | $output['element'] = ( isset( $output['element'] ) ) ? $output['element'] : 'body'; |
||
| 28 | $output['prefix'] = ( isset( $output['prefix'] ) ) ? $output['prefix'] : ''; |
||
| 29 | $output['suffix'] = ( isset( $output['suffix'] ) ) ? $output['suffix'] : ''; |
||
| 30 | $output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global'; |
||
| 31 | |||
| 32 | // Background-image. |
||
| 33 | if ( isset( $value['background-image'] ) && ! empty( $value['background-image'] ) ) { |
||
| 34 | $this->styles[ $output['media_query'] ][ $output['element'] ]['background-image'] = $output['prefix'] . $this->process_property_value( 'background-image', $value['background-image'] ) . $output['suffix']; |
||
| 35 | } |
||
| 36 | |||
| 37 | // Background-color. |
||
| 38 | if ( isset( $value['background-color'] ) && ! empty( $value['background-color'] ) ) { |
||
| 39 | $this->styles[ $output['media_query'] ][ $output['element'] ]['background-color'] = $output['prefix'] . $this->process_property_value( 'background-color', $value['background-color'] ) . $output['suffix']; |
||
| 40 | } |
||
| 41 | |||
| 42 | // Background-repeat. |
||
| 43 | if ( isset( $value['background-repeat'] ) && ! empty( $value['background-repeat'] ) ) { |
||
| 44 | $this->styles[ $output['media_query'] ][ $output['element'] ]['background-repeat'] = $output['prefix'] . $this->process_property_value( 'background-repeat', $value['background-repeat'] ) . $output['suffix']; |
||
| 45 | } |
||
| 46 | |||
| 47 | // Background-position. |
||
| 48 | if ( isset( $value['background-position'] ) && ! empty( $value['background-position'] ) ) { |
||
| 49 | $this->styles[ $output['media_query'] ][ $output['element'] ]['background-position'] = $output['prefix'] . $this->process_property_value( 'background-position', $value['background-position'] ) . $output['suffix']; |
||
| 50 | } |
||
| 51 | |||
| 52 | // Background-size. |
||
| 53 | if ( isset( $value['background-size'] ) && ! empty( $value['background-size'] ) ) { |
||
| 54 | $this->styles[ $output['media_query'] ][ $output['element'] ]['background-size'] = $output['prefix'] . $this->process_property_value( 'background-size', $value['background-size'] ) . $output['suffix']; |
||
| 55 | } |
||
| 56 | |||
| 57 | // Background-attachment. |
||
| 58 | if ( isset( $value['background-attachment'] ) && ! empty( $value['background-attachment'] ) ) { |
||
| 59 | $this->styles[ $output['media_query'] ][ $output['element'] ]['background-attachment'] = $output['prefix'] . $this->process_property_value( 'background-attachment', $value['background-attachment'] ) . $output['suffix']; |
||
| 60 | } |
||
| 61 | } |
||
| 62 | } |
||
| 63 |
