Completed
Push — develop ( 689869...4a87f4 )
by Aristeides
03:11
created
modules/webfonts/class-kirki-fonts.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 			$google_fonts = array();
96 96
 			if ( is_array( $fonts ) ) {
97 97
 				foreach ( $fonts['items'] as $font ) {
98
-					$google_fonts[ $font['family'] ] = array(
98
+					$google_fonts[$font['family']] = array(
99 99
 						'label'    => $font['family'],
100 100
 						'variants' => $font['variants'],
101 101
 						'subsets'  => $font['subsets'],
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 		$fonts = self::get_all_fonts();
147 147
 		$fonts_array = array();
148 148
 		foreach ( $fonts as $key => $args ) {
149
-			$fonts_array[ $key ] = $key;
149
+			$fonts_array[$key] = $key;
150 150
 		}
151 151
 		return $fonts_array;
152 152
 	}
Please login to merge, or discard this patch.
modules/webfonts/class-kirki-fonts-google.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -142,15 +142,15 @@  discard block
 block discarded – undo
142 142
 			}
143 143
 
144 144
 			// Add the requested google-font.
145
-			if ( ! isset( $this->fonts[ $value['font-family'] ] ) ) {
146
-				$this->fonts[ $value['font-family'] ] = array();
145
+			if ( ! isset( $this->fonts[$value['font-family']] ) ) {
146
+				$this->fonts[$value['font-family']] = array();
147 147
 			}
148
-			if ( ! in_array( $value['variant'], $this->fonts[ $value['font-family'] ], true ) ) {
149
-				$this->fonts[ $value['font-family'] ][] = $value['variant'];
148
+			if ( ! in_array( $value['variant'], $this->fonts[$value['font-family']], true ) ) {
149
+				$this->fonts[$value['font-family']][] = $value['variant'];
150 150
 			}
151 151
 			if ( ! empty( $args['choices']['variant'] ) ) {
152 152
 				foreach ( $args['choices']['variant'] as $extra_variant ) {
153
-					$this->fonts[ $value['font-family'] ][] = $extra_variant;
153
+					$this->fonts[$value['font-family']][] = $extra_variant;
154 154
 				}
155 155
 			}
156 156
 		} else {
@@ -169,12 +169,12 @@  discard block
 block discarded – undo
169 169
 
170 170
 					if ( 'font-family' === $output['property'] ) {
171 171
 						if ( ! array_key_exists( $value, $this->fonts ) ) {
172
-							$this->fonts[ $value ] = array();
172
+							$this->fonts[$value] = array();
173 173
 						}
174 174
 					} elseif ( 'font-weight' === $output['property'] ) {
175 175
 						foreach ( $this->fonts as $font => $variants ) {
176 176
 							if ( ! in_array( $value, $variants, true ) ) {
177
-								$this->fonts[ $font ][] = $value;
177
+								$this->fonts[$font][] = $value;
178 178
 							}
179 179
 						}
180 180
 					} elseif ( 'font-subset' === $output['property'] || 'subset' === $output['property'] || 'subsets' === $output['property'] ) {
@@ -213,31 +213,31 @@  discard block
 block discarded – undo
213 213
 			// Determine if this is indeed a google font or not.
214 214
 			// If it's not, then just remove it from the array.
215 215
 			if ( ! array_key_exists( $font, $this->google_fonts ) ) {
216
-				unset( $this->fonts[ $font ] );
216
+				unset( $this->fonts[$font] );
217 217
 				continue;
218 218
 			}
219 219
 
220 220
 			// Get all valid font variants for this font.
221 221
 			$font_variants = array();
222
-			if ( isset( $this->google_fonts[ $font ]['variants'] ) ) {
223
-				$font_variants = $this->google_fonts[ $font ]['variants'];
222
+			if ( isset( $this->google_fonts[$font]['variants'] ) ) {
223
+				$font_variants = $this->google_fonts[$font]['variants'];
224 224
 			}
225 225
 			foreach ( $variants as $variant ) {
226 226
 
227 227
 				// If this is not a valid variant for this font-family
228 228
 				// then unset it and move on to the next one.
229 229
 				if ( ! in_array( $variant, $font_variants, true ) ) {
230
-					$variant_key = array_search( $variant, $this->fonts[ $font ] );
231
-					unset( $this->fonts[ $font ][ $variant_key ] );
230
+					$variant_key = array_search( $variant, $this->fonts[$font] );
231
+					unset( $this->fonts[$font][$variant_key] );
232 232
 					continue;
233 233
 				}
234 234
 			}
235 235
 
236 236
 			// Check if the selected subsets exist, even in one of the selected fonts.
237 237
 			// If they don't, then they have to be removed otherwise the link will fail.
238
-			if ( isset( $this->google_fonts[ $font ]['subsets'] ) ) {
238
+			if ( isset( $this->google_fonts[$font]['subsets'] ) ) {
239 239
 				foreach ( $this->subsets as $subset ) {
240
-					if ( in_array( $subset, $this->google_fonts[ $font ]['subsets'], true ) ) {
240
+					if ( in_array( $subset, $this->google_fonts[$font]['subsets'], true ) ) {
241 241
 						$valid_subsets[] = $subset;
242 242
 					}
243 243
 				}
Please login to merge, or discard this patch.
core/class-kirki-setting-user-meta.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 		// @codingStandardsIgnoreLine
46 46
 		$single_meta = get_user_meta( get_current_user_id(), $id_base, true );
47 47
 
48
-		if ( isset( $user_meta[ $id_base ] ) ) {
48
+		if ( isset( $user_meta[$id_base] ) ) {
49 49
 			return $single_meta;
50 50
 		}
51 51
 		return $default;
Please login to merge, or discard this patch.
core/class-kirki-settings.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -68,12 +68,12 @@  discard block
 block discarded – undo
68 68
 		// Get the classname we'll be using to create our setting(s).
69 69
 		$classname = false;
70 70
 		if ( isset( $args['option_type'] ) && array_key_exists( $args['option_type'], $this->setting_types ) ) {
71
-			$classname = $this->setting_types[ $args['option_type'] ];
71
+			$classname = $this->setting_types[$args['option_type']];
72 72
 		}
73 73
 		if ( ! isset( $args['type'] ) || ! array_key_exists( $args['type'], $this->setting_types ) ) {
74 74
 			$args['type'] = 'default';
75 75
 		}
76
-		$classname = ! $classname ? $this->setting_types[ $args['type'] ] : $classname;
76
+		$classname = ! $classname ? $this->setting_types[$args['type']] : $classname;
77 77
 
78 78
 		// If settings are defined as an array, then we need to go through them
79 79
 		// and call add_setting for each one of them separately.
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 				$args['default'] = array();
85 85
 			}
86 86
 			foreach ( $args['settings'] as $key => $value ) {
87
-				$default   = ( isset( $defaults[ $key ] ) ) ? $defaults[ $key ] : '';
87
+				$default = ( isset( $defaults[$key] ) ) ? $defaults[$key] : '';
88 88
 				$this->add_setting( $classname, $value, $default, $args['option_type'], $args['capability'], $args['transport'], $args['sanitize_callback'] );
89 89
 			}
90 90
 		}
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 		foreach ( $this->setting_types as $key => $classname ) {
137 137
 
138 138
 			if ( ! class_exists( $classname ) ) {
139
-				unset( $this->setting_types[ $key ] );
139
+				unset( $this->setting_types[$key] );
140 140
 			}
141 141
 		}
142 142
 	}
Please login to merge, or discard this patch.
modules/customizer-styling/class-kirki-modules-customizer-styling.php 1 patch
Spacing   +13 added lines, -26 removed lines patch added patch discarded remove patch
@@ -49,50 +49,37 @@
 block discarded – undo
49 49
 		$back_obj = ( $back ) ? ariColor::newColor( $back ) : false;
50 50
 		if ( $back ) {
51 51
 			$text_on_back = ( 60 > $back_obj->lightness ) ?
52
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 60 )->toCSS( $back_obj->mode ) :
53
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 60 )->toCSS( $back_obj->mode );
52
+				$back_obj->getNew( 'lightness', $back_obj->lightness + 60 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness - 60 )->toCSS( $back_obj->mode );
54 53
 			$border_on_back = ( 80 < $back_obj->lightness ) ?
55
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 13 )->toCSS( $back_obj->mode ) :
56
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 13 )->toCSS( $back_obj->mode );
54
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 13 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 13 )->toCSS( $back_obj->mode );
57 55
 			$back_on_back = ( 90 < $back_obj->lightness ) ?
58
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 6 )->toCSS( $back_obj->mode ) :
59
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 11 )->toCSS( $back_obj->mode );
56
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 6 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 11 )->toCSS( $back_obj->mode );
60 57
 			$hover_on_back = ( 90 < $back_obj->lightness ) ?
61
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 3 )->toCSS( $back_obj->mode ) :
62
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 3 )->toCSS( $back_obj->mode );
58
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 3 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 3 )->toCSS( $back_obj->mode );
63 59
 			$arrows_on_back = ( 50 > $back_obj->lightness ) ?
64
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 30 )->toCSS( $back_obj->mode ) :
65
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 30 )->toCSS( $back_obj->mode );
60
+				$back_obj->getNew( 'lightness', $back_obj->lightness + 30 )->toCSS( $back_obj->mode ) : $back_obj->getNew( 'lightness', $back_obj->lightness - 30 )->toCSS( $back_obj->mode );
66 61
 			$back_disabled_obj = ( 35 < $back_obj->lightness ) ?
67
-				$back_obj->getNew( 'lightness', $back_obj->lightness - 30 ) :
68
-				$back_obj->getNew( 'lightness', $back_obj->lightness + 30 );
62
+				$back_obj->getNew( 'lightness', $back_obj->lightness - 30 ) : $back_obj->getNew( 'lightness', $back_obj->lightness + 30 );
69 63
 			$back_disabled = $back_disabled_obj->toCSS( $back_disabled_obj->mode );
70 64
 			$text_on_back_disabled = ( 60 > $back_disabled_obj->lightness ) ?
71
-				$back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness + 60 )->toCSS( $back_disabled_obj->mode ) :
72
-				$back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness - 60 )->toCSS( $back_disabled_obj->mode );
65
+				$back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness + 60 )->toCSS( $back_disabled_obj->mode ) : $back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness - 60 )->toCSS( $back_disabled_obj->mode );
73 66
 			$border_on_back_disabled = ( 50 < $back_disabled_obj->lightness ) ?
74
-				$back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness - 4 )->toCSS( $back_disabled_obj->mode ) :
75
-				$back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness + 4 )->toCSS( $back_disabled_obj->mode );
67
+				$back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness - 4 )->toCSS( $back_disabled_obj->mode ) : $back_disabled_obj->getNew( 'lightness', $back_disabled_obj->lightness + 4 )->toCSS( $back_disabled_obj->mode );
76 68
 		}
77 69
 		$accent     = ( isset( $config['color_accent'] ) ) ? $config['color_accent'] : false;
78 70
 		$accent_obj = ( $accent ) ? ariColor::newColor( $accent ) : false;
79 71
 		if ( $accent ) {
80 72
 			$text_on_accent = ( 60 > $accent_obj->lightness ) ?
81
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 60 )->toCSS( $accent_obj->mode ) :
82
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 60 )->toCSS( $accent_obj->mode );
73
+				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 60 )->toCSS( $accent_obj->mode ) : $accent_obj->getNew( 'lightness', $accent_obj->lightness - 60 )->toCSS( $accent_obj->mode );
83 74
 			$border_on_accent = ( 50 < $accent_obj->lightness ) ?
84
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 4 )->toCSS( $accent_obj->mode ) :
85
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 4 )->toCSS( $accent_obj->mode );
75
+				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 4 )->toCSS( $accent_obj->mode ) : $accent_obj->getNew( 'lightness', $accent_obj->lightness + 4 )->toCSS( $accent_obj->mode );
86 76
 			$accent_disabled_obj = ( 35 < $accent_obj->lightness ) ?
87
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 30 ) :
88
-				$accent_obj->getNew( 'lightness', $accent_obj->lightness + 30 );
77
+				$accent_obj->getNew( 'lightness', $accent_obj->lightness - 30 ) : $accent_obj->getNew( 'lightness', $accent_obj->lightness + 30 );
89 78
 			$accent_disabled = $accent_disabled_obj->toCSS( $accent_disabled_obj->mode );
90 79
 			$text_on_accent_disabled = ( 60 > $accent_disabled_obj->lightness ) ?
91
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 60 )->toCSS( $accent_disabled_obj->mode ) :
92
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 60 )->toCSS( $accent_disabled_obj->mode );
80
+				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 60 )->toCSS( $accent_disabled_obj->mode ) : $accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 60 )->toCSS( $accent_disabled_obj->mode );
93 81
 			$border_on_accent_disabled = ( 50 < $accent_disabled_obj->lightness ) ?
94
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 4 )->toCSS( $accent_disabled_obj->mode ) :
95
-				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 4 )->toCSS( $accent_disabled_obj->mode );
82
+				$accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness - 4 )->toCSS( $accent_disabled_obj->mode ) : $accent_disabled_obj->getNew( 'lightness', $accent_disabled_obj->lightness + 4 )->toCSS( $accent_disabled_obj->mode );
96 83
 		}
97 84
 
98 85
 		if ( $back ) {
Please login to merge, or discard this patch.
modules/webfonts/class-kirki-modules-webfonts-async.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,9 +80,9 @@
 block discarded – undo
80 80
 		$fonts_to_load = array();
81 81
 		foreach ( $this->googlefonts->fonts as $font => $weights ) {
82 82
 			foreach ( $weights as $key => $value ) {
83
-				$weights[ $key ] = str_replace( array( 'regular', 'bold', 'italic' ), array( '400', '', 'i' ), $value );
83
+				$weights[$key] = str_replace( array( 'regular', 'bold', 'italic' ), array( '400', '', 'i' ), $value );
84 84
 				if ( 'i' === $value ) {
85
-					$weights[ $key ] = '400i';
85
+					$weights[$key] = '400i';
86 86
 				}
87 87
 			}
88 88
 			$fonts_to_load[] = $font . ':' . join( ',', $weights );
Please login to merge, or discard this patch.
modules/css/class-kirki-modules-css.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -243,8 +243,8 @@
 block discarded – undo
243 243
 				$css = Kirki_Helper::array_replace_recursive( $css, Kirki_Modules_CSS_Generator::css( $field ) );
244 244
 
245 245
 				// Add the globals.
246
-				if ( isset( self::$css_array[ $config_id ] ) && ! empty( self::$css_array[ $config_id ] ) ) {
247
-					Kirki_Helper::array_replace_recursive( $css, self::$css_array[ $config_id ] );
246
+				if ( isset( self::$css_array[$config_id] ) && ! empty( self::$css_array[$config_id] ) ) {
247
+					Kirki_Helper::array_replace_recursive( $css, self::$css_array[$config_id] );
248 248
 				}
249 249
 			}
250 250
 		}
Please login to merge, or discard this patch.
modules/css/class-kirki-output.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 				if ( isset( $output['pattern_replace'] ) && is_array( $output['pattern_replace'] ) ) {
103 103
 					$option_type = 'theme_mod';
104 104
 					$option_name = false;
105
-					if ( isset( Kirki::$config[ $this->config_id ] ) ) {
106
-						$config = Kirki::$config[ $this->config_id ];
105
+					if ( isset( Kirki::$config[$this->config_id] ) ) {
106
+						$config = Kirki::$config[$this->config_id];
107 107
 						$option_type = ( isset( $config['option_type'] ) ) ? $config['option_type'] : 'theme_mod';
108 108
 						if ( 'option' === $option_type || 'site_option' === $option_type ) {
109 109
 							$option_name = ( isset( $config['option_name'] ) ) ? $config['option_name'] : false;
@@ -119,16 +119,16 @@  discard block
 block discarded – undo
119 119
 								if ( is_array( $options ) ) {
120 120
 									if ( $option_name ) {
121 121
 										$subkey = str_replace( array( $option_name, '[', ']' ), '', $replace );
122
-										$replacement = ( isset( $options[ $subkey ] ) ) ? $options[ $subkey ] : '';
122
+										$replacement = ( isset( $options[$subkey] ) ) ? $options[$subkey] : '';
123 123
 										break;
124 124
 									}
125
-									$replacement = ( isset( $options[ $replace ] ) ) ? $options[ $replace ] : '';
125
+									$replacement = ( isset( $options[$replace] ) ) ? $options[$replace] : '';
126 126
 									break;
127 127
 								}
128 128
 								$replacement = get_option( $replace );
129 129
 								break;
130 130
 							case 'site_option':
131
-								$replacement = ( is_array( $options ) && isset( $options[ $replace ] ) ) ? $options[ $replace ] : get_site_option( $replace );
131
+								$replacement = ( is_array( $options ) && isset( $options[$replace] ) ) ? $options[$replace] : get_site_option( $replace );
132 132
 								break;
133 133
 							case 'user_meta':
134 134
 								$user_id = get_current_user_id();
@@ -222,9 +222,9 @@  discard block
 block discarded – undo
222 222
 			return;
223 223
 		}
224 224
 		$output['media_query'] = ( isset( $output['media_query'] ) ) ? $output['media_query'] : 'global';
225
-		$output['prefix']      = ( isset( $output['prefix'] ) )      ? $output['prefix']      : '';
226
-		$output['units']       = ( isset( $output['units'] ) )       ? $output['units']       : '';
227
-		$output['suffix']      = ( isset( $output['suffix'] ) )      ? $output['suffix']      : '';
225
+		$output['prefix']      = ( isset( $output['prefix'] ) ) ? $output['prefix'] : '';
226
+		$output['units']       = ( isset( $output['units'] ) ) ? $output['units'] : '';
227
+		$output['suffix']      = ( isset( $output['suffix'] ) ) ? $output['suffix'] : '';
228 228
 
229 229
 		// Properties that can accept multiple values.
230 230
 		// Useful for example for gradients where all browsers use the "background-image" property
@@ -233,13 +233,13 @@  discard block
 block discarded – undo
233 233
 			'background-image',
234 234
 		);
235 235
 		if ( in_array( $output['property'], $accepts_multiple ) ) {
236
-			if ( isset( $this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] ) && ! is_array( $this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] ) ) {
237
-				$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = (array) $this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ];
236
+			if ( isset( $this->styles[$output['media_query']][$output['element']][$output['property']] ) && ! is_array( $this->styles[$output['media_query']][$output['element']][$output['property']] ) ) {
237
+				$this->styles[$output['media_query']][$output['element']][$output['property']] = (array) $this->styles[$output['media_query']][$output['element']][$output['property']];
238 238
 			}
239
-			$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ][] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
239
+			$this->styles[$output['media_query']][$output['element']][$output['property']][] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
240 240
 			return;
241 241
 		}
242
-		$this->styles[ $output['media_query'] ][ $output['element'] ][ $output['property'] ] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
242
+		$this->styles[$output['media_query']][$output['element']][$output['property']] = $output['prefix'] . $value . $output['units'] . $output['suffix'];
243 243
 	}
244 244
 
245 245
 	/**
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
 			'background-position' => 'Kirki_Output_Property_Background_Position',
260 260
 		) );
261 261
 		if ( array_key_exists( $property, $properties ) ) {
262
-			$classname = $properties[ $property ];
262
+			$classname = $properties[$property];
263 263
 			$obj = new $classname( $property, $value );
264 264
 			return $obj->get_value();
265 265
 		}
Please login to merge, or discard this patch.
modules/css/property/class-kirki-output-property-font-family.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@
 block discarded – undo
43 43
 		// Add backup font.
44 44
 		if ( Kirki_Fonts::is_google_font( $family ) ) {
45 45
 
46
-			if ( '' === $backup && isset( $google_fonts_array[ $family ] ) && isset( $backup_fonts[ $google_fonts_array[ $family ]['category'] ] ) ) {
47
-				$backup = $backup_fonts[ $google_fonts_array[ $family ]['category'] ];
46
+			if ( '' === $backup && isset( $google_fonts_array[$family] ) && isset( $backup_fonts[$google_fonts_array[$family]['category']] ) ) {
47
+				$backup = $backup_fonts[$google_fonts_array[$family]['category']];
48 48
 			}
49 49
 
50 50
 			// Add double quotes if needed.
Please login to merge, or discard this patch.