Issues in script.js - All Issues - Inspection of "add support for multiple css-vars. See #1561" - aristath/kirki - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 3892e2...b1663d )

by Aristeides

created 2018-05-14 20:54 UTC

modules/css-vars/script.js (4 issues)

Labels

Coding Style 4

Severity

/* global kirkiCssVarFields */
var kirkiCssVars = {
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

	/**
	 * Get styles.
	 *
	 * @since 3.0.28
	 * @returns {Object}
	 */
	getStyles: function() {
		var style     = jQuery( '#kirki-css-vars' ),
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
			styles    = style.html().replace( ':root{', '' ).replace( '}', '' ).split( ';' ),
			stylesObj = {};

		// Format styles as a object we can then tweak.
		_.each( styles, function( style ) {
			style = style.split( ':' );
			if ( style[0] && style[1] ) {
				stylesObj[ style[0] ] = style[1];
			}
		} );
		return stylesObj;
	},

	/**
	 * Builds the styles from an object.
	 *
	 * @since 3.0.28
	 * @param {Object} vars - The vars.
	 * @returns {string}
	 */
	buildStyle: function( vars ) {
		var style = '';
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console

		_.each( vars, function( val, name ) {
			style += name + ':' + val + ';';
		} );
		return ':root{' + style + '}';
	}
};

jQuery( document ).ready( function() {
	_.each( kirkiCssVarFields, function( field ) {
		wp.customize( field.settings, function( value ) {
			value.bind( function( newVal ) {
				var val = newVal;
if (true)
 {
    var x = "Hello, Stonehenge!";
}

console.log(x); //prints Hello, Stonehenge! to the console
				styles = kirkiCssVars.getStyles();

				_.each( field.css_vars, function( cssVar ) {
					if ( cssVar[2] && _.isObject( value ) && value[ cssVar[2] ] ) {
						newVal = value[ cssVar[2] ];
					}
					styles[ cssVar[0] ] = cssVar[1].replace( '$', newVal );
				} );
				jQuery( '#kirki-css-vars' ).html( kirkiCssVars.buildStyle( styles ) )				;
			} );
		} );
	} );
} );


1			/* global kirkiCssVarFields */
2			var kirkiCssVars = {
			0 ignored issues – show Coding Style introduced 2018-05-13 14:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
3
4			/**
5			* Get styles.
6			*
7			* @since 3.0.28
8			* @returns {Object}
9			*/
10			getStyles: function() {
11			var style = jQuery( '#kirki-css-vars' ),
			0 ignored issues – show Coding Style introduced 2018-05-13 14:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
12			styles = style.html().replace( ':root{', '' ).replace( '}', '' ).split( ';' ),
13			stylesObj = {};
14
15			// Format styles as a object we can then tweak.
16			_.each( styles, function( style ) {
17			style = style.split( ':' );
18			if ( style[0] && style[1] ) {
19			stylesObj[ style[0] ] = style[1];
20			}
21			} );
22			return stylesObj;
23			},
24
25			/**
26			* Builds the styles from an object.
27			*
28			* @since 3.0.28
29			* @param {Object} vars - The vars.
30			* @returns {string}
31			*/
32			buildStyle: function( vars ) {
33			var style = '';
			0 ignored issues – show Coding Style introduced 2018-05-13 14:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
34
35			_.each( vars, function( val, name ) {
36			style += name + ':' + val + ';';
37			} );
38			return ':root{' + style + '}';
39			}
40			};
41
42			jQuery( document ).ready( function() {
43			_.each( kirkiCssVarFields, function( field ) {
44			wp.customize( field.settings, function( value ) {
45			value.bind( function( newVal ) {
46			var val = newVal;
			0 ignored issues – show Coding Style introduced 2018-05-13 14:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding-style, prefer block-scoped variables using `let` or `const` which have better semantics than `var`. Since ECMAScript 6, you can create block-scoped vars or constants with the keywords `let` or `const`. These variables/constants are only valid in the code block where they have been declared. Consider the following two pieces of code: if (true) { var x = "Hello, Stonehenge!"; } console.log(x); //prints Hello, Stonehenge! to the console and if (true) { let x = "Hello, Stonehenge!"; } console.log(x); //ReferenceError: x is not defined The variable is not defined otuside of its block. This limits bleeding of variables into other contexts. To know more about this ECMA6 feature, look at the MDN pages on let and const. Loading history...
47			styles = kirkiCssVars.getStyles();
48
49			_.each( field.css_vars, function( cssVar ) {
50			if ( cssVar[2] && _.isObject( value ) && value[ cssVar[2] ] ) {
51			newVal = value[ cssVar[2] ];
52			}
53			styles[ cssVar[0] ] = cssVar[1].replace( '$', newVal );
54			} );
55			jQuery( '#kirki-css-vars' ).html( kirkiCssVars.buildStyle( styles ) ) ;
56			} );
57			} );
58			} );
59			} );
60

aristath / kirki

Push — develop ( 3892e2...b1663d )

modules/css-vars/script.js (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like