AuthServiceProvider::boot() - Code Metrics - Inspection of "Do tests detect syntax errors?" - area17/twill - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#512)

by Viktor

created 2020-01-24 22:47 UTC

AuthServiceProvider::boot() B

↳ Parent: Project

Complexity

Conditions	7
Paths	1

Size

Total Lines	69
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	10.1359

Importance

Changes

Metric	Value
cc	7
eloc	35
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	69
ccs	21
cts	35
cp	0.6
crap	10.1359
rs	8.4266

How to fix Long Method

<?php

namespace A17\Twill;

use A17\Twill\Models\Enums\UserRole;
use A17\Twill\Models\User;
use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;
use Illuminate\Support\Facades\Gate;

class AuthServiceProvider extends ServiceProvider
{
    const SUPERADMIN = 'SUPERADMIN'

    protected function authorize($user, $callback)

    {
        if (!$user->isPublished()) {
            return false;
        }

        if ($user->isSuperAdmin()) {
            return true;
        }

        return $callback($user);
    }

    protected function userHasRole($user, $roles)
    {
        return in_array($user->role_value, $roles);
    }

    public function boot()
    {
        Gate::define('list', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::VIEWONLY, UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('edit', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('reorder', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('publish', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('feature', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('delete', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('upload', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
            });
        });

        Gate::define('manage-users', function ($user) {
            return $this->authorize($user, function ($user) {
                return $this->userHasRole($user, [UserRole::ADMIN]);
            });
        });

        // As an admin, I can edit users, except superadmins
        // As a non-admin, I can edit myself only
        Gate::define('edit-user', function ($user, $editedUser = null) {
            return $this->authorize($user, function ($user) use ($editedUser) {
                $editedUserObject = User::find($editedUser);
                return ($this->userHasRole($user, [UserRole::ADMIN]) || $user->id == $editedUser)
                    && ($editedUserObject ? $editedUserObject->role !== self::SUPERADMIN : true);
            });
        });

        Gate::define('publish-user', function ($user) {
            return $this->authorize($user, function ($user) {
                $editedUserObject = User::find(request('id'));
                return $this->userHasRole($user, [UserRole::ADMIN]) && ($editedUserObject ? $user->id !== $editedUserObject->id && $editedUserObject->role !== self::SUPERADMIN : false);
            });
        });

        Gate::define('impersonate', function ($user) {
            return $user->role === self::SUPERADMIN;
        });

    }
}


1		<?php
2
3		namespace A17\Twill;
4
5		use A17\Twill\Models\Enums\UserRole;
6		use A17\Twill\Models\User;
7		use Illuminate\Foundation\Support\Providers\AuthServiceProvider as ServiceProvider;
8		use Illuminate\Support\Facades\Gate;
9
10		class AuthServiceProvider extends ServiceProvider
11		{
12		const SUPERADMIN = 'SUPERADMIN'
13
14	46	protected function authorize($user, $callback)
		0 ignored issues – show Bug introduced 2020-01-24 22:52 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_PROTECTED, expecting ',' or ';' on line 14 at column 4 Loading history...
15		{
16	46	if (!$user->isPublished()) {
17	2	return false;
18		}
19
20	46	if ($user->isSuperAdmin()) {
21	46	return true;
22		}
23
24		return $callback($user);
25		}
26
27		protected function userHasRole($user, $roles)
28		{
29		return in_array($user->role_value, $roles);
30		}
31
32	59	public function boot()
33		{
34		Gate::define('list', function ($user) {
35		return $this->authorize($user, function ($user) {
36		return $this->userHasRole($user, [UserRole::VIEWONLY, UserRole::PUBLISHER, UserRole::ADMIN]);
37	46	});
38	59	});
39
40		Gate::define('edit', function ($user) {
41		return $this->authorize($user, function ($user) {
42		return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
43	31	});
44	59	});
45
46		Gate::define('reorder', function ($user) {
47		return $this->authorize($user, function ($user) {
48		return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
49	14	});
50	59	});
51
52		Gate::define('publish', function ($user) {
53		return $this->authorize($user, function ($user) {
54		return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
55	10	});
56	59	});
57
58		Gate::define('feature', function ($user) {
59		return $this->authorize($user, function ($user) {
60		return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
61	6	});
62	59	});
63
64		Gate::define('delete', function ($user) {
65		return $this->authorize($user, function ($user) {
66		return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
67	11	});
68	59	});
69
70		Gate::define('upload', function ($user) {
71		return $this->authorize($user, function ($user) {
72		return $this->userHasRole($user, [UserRole::PUBLISHER, UserRole::ADMIN]);
73	46	});
74	59	});
75
76		Gate::define('manage-users', function ($user) {
77		return $this->authorize($user, function ($user) {
78		return $this->userHasRole($user, [UserRole::ADMIN]);
79	46	});
80	59	});
81
82		// As an admin, I can edit users, except superadmins
83		// As a non-admin, I can edit myself only
84		Gate::define('edit-user', function ($user, $editedUser = null) {
85		return $this->authorize($user, function ($user) use ($editedUser) {
86		$editedUserObject = User::find($editedUser);
87		return ($this->userHasRole($user, [UserRole::ADMIN]) \|\| $user->id == $editedUser)
88		&& ($editedUserObject ? $editedUserObject->role !== self::SUPERADMIN : true);
89	5	});
90	59	});
91
92		Gate::define('publish-user', function ($user) {
93		return $this->authorize($user, function ($user) {
94		$editedUserObject = User::find(request('id'));
95		return $this->userHasRole($user, [UserRole::ADMIN]) && ($editedUserObject ? $user->id !== $editedUserObject->id && $editedUserObject->role !== self::SUPERADMIN : false);
96		});
97	59	});
98
99		Gate::define('impersonate', function ($user) {
100	2	return $user->role === self::SUPERADMIN;
101	59	});
102
103	59	}
104		}
105

area17 / twill

Pull Request — master (#512)

AuthServiceProvider::boot() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like