HandleRevisions::hydrateHandleRevisions() - Code Metrics - Inspection of "Automated Browser and Repeater Fields (#400)" - area17/twill - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — 1.2 ( 392f29...968e7d )

by Quentin
created 2019-11-19 21:29 UTC
HandleRevisions::hydrateHandleRevisions() C

↳ Parent: HandleRevisions
Complexity

Conditions	14
Paths	4
Size

Total Lines	29
Code Lines	19
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	14
eloc	19
nc	4
nop	2
dl	0
loc	29
rs	6.2666
c	0
b	0
f	0
How to fix Complexity

<?php

namespace A17\Twill\Repositories\Behaviors;

use Illuminate\Support\Arr;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Collection;

trait HandleRevisions
{
    public function hydrateHandleRevisions($object, $fields)
    {
        if (property_exists($this, 'browsers')) {
            foreach ($this->browsers as $module) {
                if (is_string($module)) {
                    $this->hydrateBrowser($object, $fields, $module);
                } elseif (is_array($module)) {
                    $relation = !empty($module['relation']) ? $module['relation'] : key($module);
                    $positionAttribute = !empty($module['positionAttribute']) ? $module['positionAttribute'] : 'position';
                    $model = isset($module['model']) ? $module['model'] : null;
                    $this->hydrateBrowser($object, $fields, $relation, $positionAttribute, $model);
                }
            }
        }

        if (property_exists($this, 'repeaters')) {
            foreach ($this->repeaters as $module) {
                if (is_string($module)) {
                    $model = Str::studly(Str::singular($module));
filter:
    dependency_paths: ["lib/*"]
                    $this->hydrateRepeater($object, $fields, $module, $model);
                } elseif (is_array($module)) {
                    $relation = !empty($module['relation']) ? $module['relation'] : key($module);
                    $model = isset($module['model']) ? $module['model'] : Str::studly(Str::singular(key($module)));
                    $this->hydrateRepeater($object, $fields, $relation, $model);
                }
            }
        }

        return $object;
    }

    public function beforeSaveHandleRevisions($object, $fields)
    {
        $lastRevisionPayload = json_decode($object->revisions->first()->payload ?? "{}", true);

        if ($fields != $lastRevisionPayload) {
            $object->revisions()->create([
                'payload' => json_encode($fields),
                'user_id' => Auth::guard('twill_users')->user()->id ?? null,
            ]);
        }

        return $fields;
    }

    public function preview($id, $fields)
    {
        $object = $this->model->findOrFail($id);

        return $this->hydrateObject($object, $fields);
    }

    protected function hydrateObject($object, $fields)
    {
        $fields = $this->prepareFieldsBeforeSave($object, $fields);
        $fields = $this->prepareFieldsBeforeSave($object, $fields);

        $object->fill(Arr::except($fields, $this->getReservedFields()));
        $object->fill(Arr::except($fields, $this->/** @scrutinizer ignore-call */ getReservedFields()));

        $object = $this->hydrate($object, $fields);
        $object = $this->hydrate($object, $fields);

        return $object;
    }

    public function previewForRevision($id, $revisionId)
    {
        $object = $this->model->findOrFail($id);

        $fields = json_decode($object->revisions->where('id', $revisionId)->first()->payload, true);

        $hydratedObject = $this->hydrateObject($this->model->newInstance(), $fields);
        $hydratedObject->id = $id;

        return $hydratedObject;
    }

    public function hydrateMultiSelect($object, $fields, $relationship, $model = null, $customHydratedRelationship = null)
    {
        $fieldsHasElements = isset($fields[$relationship]) && !empty($fields[$relationship]);
        $relatedElements = $fieldsHasElements ? $fields[$relationship] : [];

        $relationRepository = $this->getModelRepository($relationship, $model);
        $relationRepository = $this->getModelRepository($relationship, $model);
        $relatedElementsCollection = Collection::make();

        foreach ($relatedElements as $relatedElement) {
            $newRelatedElement = $relationRepository->getById($relatedElement);
            $relatedElementsCollection->push($newRelatedElement);
        }

        $object->setRelation($customHydratedRelationship ?? $relationship, $relatedElementsCollection);
    }

    public function hydrateBrowser($object, $fields, $relationship, $positionAttribute = 'position', $model = null)
    {
        return $this->hydrateOrderedBelongsTomany($object, $fields, $relationship, $positionAttribute, $model);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function hydrateOrderedBelongsTomany($object, $fields, $relationship, $positionAttribute = 'position', $model = null)
    {
        $fieldsHasElements = isset($fields['browsers'][$relationship]) && !empty($fields['browsers'][$relationship]);
        $relatedElements = $fieldsHasElements ? $fields['browsers'][$relationship] : [];

        $relationRepository = $this->getModelRepository($relationship, $model);
        $relatedElementsCollection = Collection::make();
        $position = 1;

        foreach ($relatedElements as $relatedElement) {
            $newRelatedElement = $relationRepository->getById($relatedElement['id']);
            $pivot = $newRelatedElement->newPivot($object, [$positionAttribute => $position++], $object->$relationship()->getTable(), true);
            $newRelatedElement->setRelation('pivot', $pivot);
            $relatedElementsCollection->push($newRelatedElement);
        }

        $object->setRelation($relationship, $relatedElementsCollection);
    }

    public function hydrateRepeater($object, $fields, $relationship, $model)
    {
        $relationFields = $fields['repeaters'][$relationship] ?? [];

        $relationRepository = $this->getModelRepository($relationship, $model);

        $repeaterCollection = Collection::make();

        foreach ($relationFields as $index => $relationField) {
            $relationField['position'] = $index + 1;
            $relationField[$this->model->getForeignKey()] = $object->id;
            unset($relationField['id']);

            $newRepeater = $relationRepository->createForPreview($relationField);

            $repeaterCollection->push($newRepeater);
        }

        $object->setRelation($relationship, $repeaterCollection);
    }

    public function getCountForMine()
    {
        $query = $this->model->newQuery();
        return $this->filter($query, $this->countScope)->mine()->count();
        return $this->/** @scrutinizer ignore-call */ filter($query, $this->countScope)->mine()->count();
    }

    public function getCountByStatusSlugHandleRevisions($slug)
    {
        if ($slug === 'mine') {
            return $this->getCountForMine();
        }

        return false;
    }
}

area17 / twill

Push — 1.2 ( 392f29...968e7d )

HandleRevisions::hydrateHandleRevisions() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like
