TwicPicsParamsProcessor::handleParamFit() - Code Metrics - Inspection of "Fix bad merge" - area17/twill - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/permissions-management ( 3c8a9f...1cc208 )

by Harings

created 2022-01-19 09:48 UTC

TwicPicsParamsProcessor::handleParamFit() A

↳ Parent: TwicPicsParamsProcessor

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	6
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	13
rs	10

<?php

namespace A17\Twill\Services\MediaLibrary;

class TwicPicsParamsProcessor extends AbstractParamsProcessor
{
    protected $cropFit;

    public function finalizeParams()
    {
        if ($this->format) {
            $this->params['output'] = $this->format;
        }

        if ($this->quality) {
            $this->params['quality'] = $this->quality;
        }

        if ($this->width || $this->height) {
            $this->width = $this->width ?: '-';
            $this->height = $this->height ?: '-';

            if ($this->cropFit) {
                $this->params['crop'] = "{$this->width}x{$this->height}";
            } else {
                $this->params['resize'] = "{$this->width}x{$this->height}";
            }
        }

        return $this->params;
    }

    protected function handleParamFit($key, $value)
    {
        if ($value !== 'crop') {
            return;
        }

        if (isset($this->params['crop'])) {
            return;
        }

        $this->cropFit = true;

        unset($this->params[$key]);
    }
}


1			<?php
2
3			namespace A17\Twill\Services\MediaLibrary;
4
5			class TwicPicsParamsProcessor extends AbstractParamsProcessor
6			{
7			protected $cropFit;
8
9			public function finalizeParams()
10			{
11			if ($this->format) {
12			$this->params['output'] = $this->format;
13			}
14
15			if ($this->quality) {
16			$this->params['quality'] = $this->quality;
17			}
18
19			if ($this->width \|\| $this->height) {
20			$this->width = $this->width ?: '-';
21			$this->height = $this->height ?: '-';
22
23			if ($this->cropFit) {
24			$this->params['crop'] = "{$this->width}x{$this->height}";
25			} else {
26			$this->params['resize'] = "{$this->width}x{$this->height}";
27			}
28			}
29
30			return $this->params;
31			}
32
33			protected function handleParamFit($key, $value)
34			{
35			if ($value !== 'crop') {
36			return;
37			}
38
39			if (isset($this->params['crop'])) {
40			return;
41			}
42
43			$this->cropFit = true;
44
45			unset($this->params[$key]);
46			}
47			}
48

area17 / twill

Push — feature/permissions-management ( 3c8a9f...1cc208 )

TwicPicsParamsProcessor::handleParamFit() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like