A17\Twill\Repositories\UserRepository

Complexity

Total Complexity

17

Size/Duplication

Total Lines	146
Duplicated Lines	0 %

Test Coverage

Coverage

66.67%

Importance

Changes	4
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	afterSave()	0	9	2
A	sendWelcomeEmail()	0	11	4
A	getCountForTrash()	0	3	1
A	filter()	0	8	1
A	prepareFieldsBeforeSave()	0	13	5
A	getCountForDraft()	0	3	1
A	__construct()	0	13	1
A	getCountForPublished()	0	3	1
A	afterUpdateBasic()	0	4	1

<?php

namespace A17\Twill\Repositories;

use App;
use A17\Twill\Models\User;
use A17\Twill\Repositories\Behaviors\HandleMedias;
use A17\Twill\Repositories\Behaviors\HandleOauth;
use Illuminate\Auth\Passwords\PasswordBrokerManager;
use Illuminate\Config\Repository as Config;
use Illuminate\Contracts\Auth\Factory as AuthFactory;
use Illuminate\Database\DatabaseManager as DB;

class UserRepository extends ModuleRepository
{
    use HandleMedias, HandleOauth;

The trait A17\Twill\Repositories\Behaviors\HandleOauth requires some properties which are not provided by A17\Twill\Repositories\UserRepository: $name, $email, $id

The trait A17\Twill\Repositories\Behaviors\HandleMedias requires some properties which are not provided by A17\Twill\Repositories\UserRepository: $medias, $crop_y, $pivot, $metadatas, $mediasParams, $crop_h, $ratio, $crop_x, $crop_w

    /**
     * @var Config
     */
    protected $config;

    /**
     * @var DB
     */
    protected $db;

    /**
     * @var PasswordBrokerManager
     */
    protected $passwordBrokerManager;

    /**
     * @var AuthFactory
     */
    protected $authFactory;

    /**
     * @param DB $db
     * @param Config $config
     * @param PasswordBrokerManager $passwordBrokerManager
     * @param AuthFactory $authFactory
     * @param User $model
     */
    public function __construct(
        DB $db,
        Config $config,
        PasswordBrokerManager $passwordBrokerManager,
        AuthFactory $authFactory,
        User $model
    ) {

        $this->model = $model;

It seems like $model of type A17\Twill\Models\User is incompatible with the declared type A17\Twill\Models\Model of property $model.

        $this->passwordBrokerManager = $passwordBrokerManager;
        $this->authFactory = $authFactory;
        $this->config = $config;
        $this->db = $db;
    }

    /**
     * @param \Illuminate\Database\Query\Builder $query
     * @param array $scopes
     * @return \Illuminate\Database\Query\Builder
     */
    public function filter($query, array $scopes = [])
    {
        $query->when(isset($scopes['role']), function ($query) use ($scopes) {
            $query->where('role', $scopes['role']);
        });
        $query->where('role', '<>', 'SUPERADMIN');
        $this->searchIn($query, $scopes, 'search', ['name', 'email', 'role']);
        return parent::filter($query, $scopes);
    }

    /**
     * @param \A17\Twill\Models\Model $user
     * @param array $fields
     */
    public function afterUpdateBasic($user, $fields)
    {
        $this->sendWelcomeEmail($user);

$user of type A17\Twill\Models\Model is incompatible with the type A17\Twill\Models\User expected by parameter $user of A17\Twill\Repositories\UserRepository::sendWelcomeEmail().

        parent::afterUpdateBasic($user, $fields);
    }

    /**
     * @return int
     */
    public function getCountForPublished()
    {
        return $this->model->where('role', '<>', 'SUPERADMIN')->published()->count();
    }

    /**
     * @return int
     */
    public function getCountForDraft()
    {
        return $this->model->where('role', '<>', 'SUPERADMIN')->draft()->count();
    }

    /**
     * @return int
     */
    public function getCountForTrash()
    {
        return $this->model->where('role', '<>', 'SUPERADMIN')->onlyTrashed()->count();
    }

    /**
     * @param \A17\Twill\Models\Model $user
     * @param array $fields
     * @return string[]
     */
    public function prepareFieldsBeforeSave($user, $fields)
    {
        $editor = $this->authFactory->guard('twill_users')->user();
        $with2faSettings = $this->config->get('twill.enabled.users-2fa', false) && $editor->id === $user->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($with2faSettings
            && $user->google_2fa_enabled

The property google_2fa_enabled does not seem to exist on A17\Twill\Models\Model. Are you sure there is no database migration missing?

            && !($fields['google_2fa_enabled'] ?? false)
        ) {
            $fields['google_2fa_secret'] = null;
        }

        return parent::prepareFieldsBeforeSave($user, $fields);
    }

    /**
     * @param \A17\Twill\Models\Model|User $user
     * @param array $fields
     * @return void
     */
    public function afterSave($user, $fields)
    {
        $this->sendWelcomeEmail($user);

It seems like $user can also be of type A17\Twill\Models\Model; however, parameter $user of A17\Twill\Repositories\UserRepository::sendWelcomeEmail() does only seem to accept A17\Twill\Models\User, maybe add an additional type check?

        $language = $fields['language'];
        if ($language !== App::getLocale()) {
            $user->language = $language;

The property language does not seem to exist on A17\Twill\Models\Model. Are you sure there is no database migration missing?

The property language does not exist on A17\Twill\Models\User. Since you implemented __set, consider adding a @property annotation.

            $user->save();
        }
        parent::afterSave($user, $fields);

It seems like $user can also be of type A17\Twill\Models\User; however, parameter $object of A17\Twill\Repositories\ModuleRepository::afterSave() does only seem to accept A17\Twill\Models\Model, maybe add an additional type check?

    }

    /**
     * @param User $user
     * @return void
     */
    private function sendWelcomeEmail($user)
    {
        if (empty($user->password)

The property password does not exist on A17\Twill\Models\User. Since you implemented __get, consider adding a @property annotation.

            && $user->published

The property published does not exist on A17\Twill\Models\User. Since you implemented __get, consider adding a @property annotation.

            && !$this->db
            ->table($this->config->get('twill.password_resets_table', 'twill_password_resets'))
            ->where('email', $user->email)

The property email does not exist on A17\Twill\Models\User. Since you implemented __get, consider adding a @property annotation.

            ->exists()
        ) {
            $user->sendWelcomeNotification(
                $this->passwordBrokerManager->broker('twill_users')->getRepository()->create($user)
            );
        }
    }

}