Passed
Pull Request — 2.x (#1360)
by Harings
14:11
created

Radios::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 41
Code Lines 19

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 19
c 1
b 0
f 0
nc 1
nop 18
dl 0
loc 41
rs 9.6333

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace A17\Twill\View\Components;
4
5
class Radios extends FieldWithOptions
6
{
7
    public $inline;
8
    public $border;
9
10
    public function __construct(
11
        $name,
12
        $label,
13
        $options = [],
14
        $unpack = false,
15
        $columns = 0,
16
        $searchable = false,
17
        $note = null,
18
        $placeholder = null,
19
        $disabled = false,
20
        $addNew = false,
21
        $moduleName = null,
22
        $default = false,
23
        $storeUrl = null,
24
        $fieldsInModal = false,
25
        $inline = false,
26
        $border = false,
27
        $renderForBlocks = false,
28
        $renderForModal = false
29
    ) {
30
        parent::__construct(
31
            $name,
32
            $label,
33
            $renderForBlocks,
34
            $renderForModal,
35
            $options,
36
            $unpack,
37
            $columns,
38
            $searchable,
39
            $note,
40
            $placeholder,
41
            $disabled,
42
            $addNew,
43
            $moduleName,
44
            $storeUrl,
45
            $default,
46
            $fieldsInModal,
47
        );
48
49
        $this->inline = $inline;
50
        $this->border = $border;
51
    }
52
53
    public function render()
54
    {
55
        return view('twill::partials.form._radios', [
56
            'options' => $this->options,
57
            'inModal' => $this->isInModal()
58
        ]);
59
    }
60
}
61