Passed
Pull Request — 2.x (#1360)
by Harings
14:11
created

MultiSelect::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 40
Code Lines 19

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 19
c 1
b 0
f 0
nc 1
nop 18
dl 0
loc 40
rs 9.6333

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace A17\Twill\View\Components;
4
5
class MultiSelect extends FieldWithOptions
6
{
7
    public $min;
8
    public $max;
9
10
    public function __construct(
11
        $name,
12
        $label,
13
        $renderForBlocks = false,
14
        $renderForModal = false,
15
        $options = [],
16
        $unpack = false,
17
        $columns = 0,
18
        $searchable = false,
19
        $note = null,
20
        $placeholder = null,
21
        $disabled = false,
22
        $addNew = false,
23
        $moduleName = null,
24
        $default = false,
25
        $storeUrl = null,
26
        $fieldsInModal = false,
27
        $min = null,
28
        $max = null
29
    ) {
30
        parent::__construct(
31
            $name,
32
            $label,
33
            $renderForBlocks,
34
            $renderForModal,
35
            $options,
36
            $unpack,
37
            $columns,
38
            $searchable,
39
            $note,
40
            $placeholder,
41
            $disabled,
42
            $addNew,
43
            $moduleName,
44
            $storeUrl,
45
            $default,
46
            $fieldsInModal
47
        );
48
        $this->min = $min;
49
        $this->max = $max;
50
    }
51
52
    public function render()
53
    {
54
        return view('twill::partials.form._multi_select', [
55
            'options' => $this->options,
56
            'inModal' => $this->isInModal()
57
        ]);
58
    }
59
}
60