A17\Twill\Models\Behaviors\HasRevisions

Complexity

Total Complexity

3

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	scopeMine()	0	4	1
A	revisionsArray()	0	9	1
A	revisions()	0	3	1

<?php

namespace A17\Twill\Models\Behaviors;

trait HasRevisions
{
    public function revisions()
    {
        return $this->hasMany(config('twill.namespace') . "\Models\Revisions\\" . class_basename($this) . "Revision")->orderBy('created_at', 'desc');

It seems like hasMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function scopeMine($query)
    {
        return $query->whereHas('revisions', function ($query) {
            $query->where('user_id', auth('twill_users')->user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        });
    }

    public function revisionsArray()
    {
        return $this->revisions->map(function ($revision) {
            return [
                'id' => $revision->id,
                'author' => $revision->user->name ?? 'Unknown',
                'datetime' => $revision->created_at->toIso8601String(),
            ];
        })->toArray();
    }
}