A17\Twill\Commands\ListIcons

Complexity

Total Complexity

7

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Test Coverage

Coverage

80.65%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isAllowed()	0	14	3
A	getIconList()	0	24	2
A	handle()	0	10	1
A	__construct()	0	6	1

<?php

namespace A17\Twill\Commands;

use Illuminate\Config\Repository as Config;
use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Symfony\Component\Finder\SplFileInfo;

class ListIcons extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'twill:list:icons {filter? : Filter icons by name}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'List available icons';

    /**
     * @var Filesystem
     */
    protected $files;

    /**
     * @var Config
     */
    protected $config;

    /**
     * @param Filesystem $files
     * @param Config $config
     */
    public function __construct(Filesystem $files, Config $config)
    {
        parent::__construct();

        $this->files = $files;
        $this->config = $config;
    }

    private function isAllowed($icon)
    {
        if (filled($filter = $this->argument('filter'))) {
            return Str::contains(
                Str::lower($icon['name']),
                Str::lower($filter)

It seems like $filter can also be of type string[]; however, parameter $value of Illuminate\Support\Str::lower() does only seem to accept string, maybe add an additional type check?

            );
        }

        if (in_array($icon['name'] . '.svg', config('twill.internal_icons'))) {
            return false;
        }

        return true;
    }

    /**
     * @return \Illuminate\Support\Collection
     */
    protected function getIconList()
    {
        return collect(
            config('twill.block_editor.directories.source.icons')
        )->reduce(function (Collection $keep, $path) {
            if (!$this->files->exists($path)) {
                $this->displayError("Directory not found: {$path}");

The method displayError() does not exist on A17\Twill\Commands\ListIcons. Since you implemented __call, consider adding a @method annotation.

                return $keep;
            }

            $files = collect($this->files->files($path))->map(function (
                SplFileInfo $file
            ) {
                return [
                    'name' => Str::before($file->getFilename(), '.svg'),
                    'url' => route('admin.icons.show', [
                        'file' => $file->getFilename(),
                    ]),
                ];
            });

            return $keep->merge($files);
        }, collect());
    }

    /**
     * Executes the console command.
     */
    public function handle()
    {
        $icons = $this->getIconList()->filter(function ($icon) {
            return $this->isAllowed($icon);
        });

        $this->table(['Icon', 'Preview URL'], $icons->toArray());
        $this->info("All icons viewable at: " . route('admin.icons.index'));

        return parent::handle();
    }
}