A17\Twill\Models\Behaviors\HasFiles

Complexity

Total Complexity

13

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Test Coverage

Coverage

18.18%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	files()	0	7	1
A	file()	0	12	3
A	fileObject()	0	3	1
A	findFile()	0	15	5
A	filesList()	0	15	3

<?php

namespace A17\Twill\Models\Behaviors;

use A17\Twill\Models\File;
use A17\Twill\Services\FileLibrary\FileService;

trait HasFiles
{
    public function files()
    {
        return $this->morphToMany(

It seems like morphToMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            File::class,
            'fileable',
            config('twill.fileables_table', 'twill_fileables')
        )->withPivot(['role', 'locale'])->withTimestamps();
    }

    private function findFile($role, $locale)
    {
        $locale = $locale ?? app()->getLocale();

The method getLocale() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

        $file = $this->files->first(function ($file) use ($role, $locale) {
            return $file->pivot->role === $role && $file->pivot->locale === $locale;
        });

        if (!$file && config('translatable.use_property_fallback', false)) {
            $file = $this->files->first(function ($file) use ($role) {
                return $file->pivot->role === $role && $file->pivot->locale === config('translatable.fallback_locale');
            });
        }

        return $file;
    }

    public function file($role, $locale = null, $file = null)
    {

        if (!$file) {
            $file = $this->findFile($role, $locale);
        }

        if ($file) {
            return FileService::getUrl($file->uuid);

The method getUrl() does not exist on A17\Twill\Services\FileLibrary\FileService. Since you implemented __callStatic, consider adding a @method annotation.

        }

        return null;
    }

    public function filesList($role, $locale = null)
    {
        $locale = $locale ?? app()->getLocale();

        $files = $this->files->filter(function ($file) use ($role, $locale) {
            return $file->pivot->role === $role && $file->pivot->locale === $locale;
        });

        $urls = [];

        foreach ($files as $file) {
            $urls[] = $this->file($role, $locale, $file);
        }

        return $urls;
    }

    public function fileObject($role, $locale = null)
    {
        return $this->findFile($role, $locale);
    }

}