A17\Twill\Models\Behaviors\HasBlocks

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Test Coverage

Coverage

84.21%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	blocks()	0	3	1
A	getBlockView()	0	9	2
A	renderBlocks()	0	18	2

<?php

namespace A17\Twill\Models\Behaviors;

use A17\Twill\Models\Block;

trait HasBlocks
{
    public function blocks()
    {
        return $this->morphMany(Block::class, 'blockable')->orderBy(config('twill.blocks_table', 'twill_blocks') . '.position', 'asc');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function renderBlocks($renderChilds = true, $blockViewMappings = [], $data = [])
    {
        return $this->blocks->where('parent_id', null)->map(function ($block) use ($blockViewMappings, $renderChilds, $data) {
            if ($renderChilds) {
                $childBlocks = $this->blocks->where('parent_id', $block->id);

                $renderedChildViews = $childBlocks->map(function ($childBlock) use ($blockViewMappings, $data) {
                    $view = $this->getBlockView($childBlock->type, $blockViewMappings);
                    return view($view, $data)->with('block', $childBlock)->render();
                })->implode('');
            }

            $block->childs = $this->blocks->where('parent_id', $block->id);

            $view = $this->getBlockView($block->type, $blockViewMappings);

            return view($view, $data)->with('block', $block)->render() . ($renderedChildViews ?? '');

Are you sure view($view, $data)->with('block', $block)->render() of type array|string can be used in concatenation?

        })->implode('');
    }

    private function getBlockView($blockType, $blockViewMappings = [])
    {
        $view = config('twill.block_editor.block_views_path') . '.' . $blockType;

        if (array_key_exists($blockType, $blockViewMappings)) {
            $view = $blockViewMappings[$blockType];
        }

        return $view;
    }
}