Revision::__construct() - Code Metrics - Inspection of "New localized fields" - area17/twill - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 2.x (#586)

by Bekzat

created 2020-03-13 18:24 UTC

Revision::__construct() A

↳ Parent: Revision

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	3
c	0
b	0
f	0
nc	2
nop	1
dl	0
loc	8
ccs	0
cts	4
cp	0
crap	6
rs	10

<?php

namespace A17\Twill\Models;

use Illuminate\Database\Eloquent\Model as BaseModel;

abstract class Revision extends BaseModel
{
    public $timestamps = true;

    protected $with = ['user'];

    protected $fillable = [
        'payload',
        'user_id',
    ];

    public function __construct(array $attributes = [])
    {
        parent::__construct($attributes);

        // Remember to update this if you had fields to the fillable array here
        // this is to allow child classes to provide a custom foreign key in fillable
        if (count($this->fillable) == 2) {
            $this->fillable[] = strtolower(str_replace('Revision', '', get_called_class())) . '_id';
        }
    }

    public function user()
    {
        return $this->belongsTo(User::class);
    }

    public function getByUserAttribute()
    {
        return isset($this->user) ? $this->user->name : 'System';

    }
}


1			<?php
2
3			namespace A17\Twill\Models;
4
5			use Illuminate\Database\Eloquent\Model as BaseModel;
6
7			abstract class Revision extends BaseModel
8			{
9			public $timestamps = true;
10
11			protected $with = ['user'];
12
13			protected $fillable = [
14			'payload',
15			'user_id',
16			];
17
18			public function __construct(array $attributes = [])
19			{
20			parent::__construct($attributes);
21
22			// Remember to update this if you had fields to the fillable array here
23			// this is to allow child classes to provide a custom foreign key in fillable
24			if (count($this->fillable) == 2) {
25			$this->fillable[] = strtolower(str_replace('Revision', '', get_called_class())) . '_id';
26			}
27			}
28
29			public function user()
30			{
31			return $this->belongsTo(User::class);
32			}
33
34			public function getByUserAttribute()
35			{
36			return isset($this->user) ? $this->user->name : 'System';
			0 ignored issues – show Bug Best Practice introduced 2018-07-17 03:43 UTC by Report Bug Copy Issue Report The property `name` does not exist on `A17\Twill\Models\User`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
37			}
38			}
39

area17 / twill

Pull Request — 2.x (#586)

Revision::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like