A17\Twill\Http\Middleware\Permission::handle()

Complexity

Conditions	7
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle(Request $request, Closure $next)
    {
        if (config('twill.enabled.permissions-management') && !Auth::user()->isSuperAdmin()) {

The method isSuperAdmin() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            if (config('twill.support_subdomain_admin_routing') && $activeSubdomain = config('twill.active_subdomain')) {
                foreach(Auth::user()->groups as $group) {

Accessing groups on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    if (in_array($activeSubdomain, $group->subdomains_access)) {
                        return $next($request);
                    }
                };
                abort(403);
            }
        }
        return $next($request);
    }