A17\Twill\Models\Role

Complexity

Total Complexity

9

Size/Duplication

Total Lines	113
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	scopeAccessible()	0	11	2
A	getUsersCountAttribute()	0	3	1
A	getCreatedAtAttribute()	0	3	1
A	users()	0	3	1
A	getAccessibleRolesAttribute()	0	3	1
A	scopeDraft()	0	3	1
A	scopeOnlyTrashed()	0	3	1
A	scopePublished()	0	3	1

<?php

namespace A17\Twill\Models;

use A17\Twill\Models\User;
use A17\Twill\Models\Behaviors\HasMedias;
use A17\Twill\Models\Behaviors\HasPermissions;
use A17\Twill\Models\Behaviors\IsTranslatable;
use A17\Twill\Models\Behaviors\HasPosition;
use A17\Twill\Models\Behaviors\Sortable;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Database\Eloquent\SoftDeletes;
use Illuminate\Database\Eloquent\Model as BaseModel;
use Illuminate\Database\Eloquent\Relations\BelongsToMany;

/**
 * Role model
 *
 * @property-read string $createdAt Date of creation
 * @property-read string $usersCount Formatted number of users in this role (ie. '123 users')
 * @method static Builder published() Get published roles
 * @method static Builder draft() Get draft roles
 * @method static Builder onlyTrashed() Get trashed roles
 */
class Role extends BaseModel implements Sortable
{
    use HasMedias, SoftDeletes, HasPermissions, IsTranslatable, HasPosition;

The trait A17\Twill\Models\Behaviors\IsTranslatable requires the property $translatedAttributes which is not provided by A17\Twill\Models\Role.

The trait A17\Twill\Models\Behaviors\HasPermissions requires the property $permissions which is not provided by A17\Twill\Models\Role.

The trait A17\Twill\Models\Behaviors\HasMedias requires some properties which are not provided by A17\Twill\Models\Role: $medias, $role, $pivot, $metadatas, $uuid, $height, $lqip_data, $crop_h, $locale, $video, $crop, $crop_w, $width

    public $timestamps = true;

    protected $fillable = [
        'name',
        'published',
        'in_everyone_group',
        'position',
    ];

    protected $dates = [
        'deleted_at',
    ];

    public $checkboxes = ['published'];

    protected $casts = [
        'in_everyone_group' => 'boolean',
    ];

    /**
     * Scope accessible roles for the current user.
     *
     * @param Builder $query
     * @return Builder
     */
    public function scopeAccessible($query)
    {
        $currentUser = auth('twill_users')->user();

        if ($currentUser->isSuperAdmin()) {

The method isSuperAdmin() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            return $query;
        }

        $accessibleRoleIds = $currentUser->role->accessibleRoles->pluck('id')->toArray();

Accessing role on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        return $query->whereIn('id', $accessibleRoleIds);
    }

    /**
     * Scope published roles.
     *
     * @param Builder $query
     * @return Builder
     */
    public function scopePublished($query)
    {
        return $query->wherePublished(true);
    }

    /**
     * Scope unpublished (draft) roles.
     *
     * @param Builder $query
     * @return Builder
     */
    public function scopeDraft($query)
    {
        return $query->wherePublished(false);
    }

    /**
     * Scope trashed roles.
     *
     * @param Builder $query
     * @return Builder
     */
    public function scopeOnlyTrashed($query)
    {
        return $query->whereNotNull('deleted_at');
    }

    /**
     * User model relationship
     *
     * @return BelongsToMany|Collection|User[]
     */
    public function users()
    {
        return $this->hasMany(User::class);
    }

    /**
     * Return the formatted created date
     *
     * @return string
     */
    public function getCreatedAtAttribute($value)
    {
        return \Carbon\Carbon::parse($value)->format('d M Y');
    }

    /**
     * Return the formatted number of users in this group
     *
     * @return string
     */
    public function getUsersCountAttribute($value)

The parameter $value is not used and could be removed.

    {
        return $this->users->count() . ' users';
    }

    /**
     * Return the roles that are considered accessible for this role
     *
     * @return \Illuminate\Database\Eloquent\Collection
     */
    public function getAccessibleRolesAttribute()
    {
        return static::where('position', '>=', $this->position)->get();
    }
}