A17\Twill\Http\Controllers\Admin\IconsController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	show()	0	10	2

<?php

namespace A17\Twill\Http\Controllers\Admin;

use Illuminate\Filesystem\Filesystem;
use Illuminate\Support\Facades\Storage;

class IconsController extends Controller
{
    public function __construct(Filesystem $files)
    {
        $this->files = $files;

The property files does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function show($file)
    {
        $file = __DIR__ . "/../../../../frontend/icons/{$file}";

        if (!$this->files->exists($file)) {
            abort(404);
        }

        return response()->stream(function () use ($file) {
            echo $this->files->get($file);
        });
    }
}