area17 /
twill
| Total Complexity | 43 |
| Total Lines | 320 |
| Duplicated Lines | 0 % |
| Coverage | 61.63% |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Complex classes like HandleBlocks often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HandleBlocks, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | trait HandleBlocks |
||
| 14 | { |
||
| 15 | /** |
||
| 16 | * @param \A17\Twill\Models\Model $object |
||
| 17 | * @param array $fields |
||
| 18 | 2 | * @param int $fakeBlockId |
|
| 19 | * @param int|null $parentId |
||
| 20 | 2 | * @param \Illuminate\Support\Collection|null $blocksFromFields |
|
| 21 | * @param \Illuminate\Support\Collection|null $mainCollection |
||
| 22 | * @param int|null $mainCollection|void |
||
| 23 | * @return \A17\Twill\Models\Model |
||
| 24 | 2 | */ |
|
| 25 | 2 | public function hydrateHandleBlocks($object, $fields, &$fakeBlockId = 0, $parentId = null, $blocksFromFields = null, $mainCollection = null) |
|
| 26 | 2 | { |
|
| 27 | 2 | if ($this->shouldIgnoreFieldBeforeSave('blocks')) { |
|
|
Bug
introduced
by
|
|||
| 28 | 2 | return; |
|
| 29 | } |
||
| 30 | 2 | ||
| 31 | 2 | $firstItem = false; |
|
| 32 | $blocksCollection = Collection::make(); |
||
| 33 | if ($mainCollection === null) { |
||
| 34 | 2 | $firstItem = true; |
|
| 35 | 2 | $mainCollection = Collection::make(); |
|
| 36 | 2 | } |
|
| 37 | 2 | if ($blocksFromFields === null) { |
|
| 38 | $blocksFromFields = $this->getBlocks($object, $fields); |
||
| 39 | } |
||
| 40 | 2 | ||
| 41 | $blockRepository = app(BlockRepository::class); |
||
| 42 | 2 | $blocksCollection = $this->getChildrenBlocks($blocksFromFields, $blockRepository, $parentId, $fakeBlockId, $mainCollection); |
|
| 43 | $object->setRelation('blocks', $firstItem ? $mainCollection : $blocksCollection); |
||
| 44 | 2 | return $object; |
|
| 45 | 1 | } |
|
| 46 | |||
| 47 | protected function getChildrenBlocks($blocks, $blockRepository, $parentId, &$fakeBlockId, $mainCollection) |
||
| 68 | 21 | } |
|
| 69 | |||
| 70 | 21 | /** |
|
| 71 | * @param \A17\Twill\Models\Model $object |
||
| 72 | * @param array $fields |
||
| 73 | * @return void |
||
| 74 | 21 | */ |
|
| 75 | public function afterSaveHandleBlocks($object, $fields) |
||
| 76 | 21 | { |
|
| 77 | 21 | if ($this->shouldIgnoreFieldBeforeSave('blocks')) { |
|
| 78 | 2 | return; |
|
| 79 | 21 | } |
|
| 80 | 21 | ||
| 81 | $blockRepository = app(BlockRepository::class); |
||
| 82 | |||
| 83 | $blockRepository->bulkDelete($object->blocks()->pluck('id')->toArray()); |
||
| 84 | $this->getBlocks($object, $fields)->each(function ($block) use ($object, $blockRepository) { |
||
| 85 | $this->createBlock($blockRepository, $block); |
||
| 86 | }); |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | 2 | * Create a block from formFields, and recursively create it's child blocks |
|
| 91 | * |
||
| 92 | 2 | * @param \A17\Twill\Repositories\BlockRepository $blockRepository |
|
| 93 | * @param array $blockFields |
||
| 94 | * @return \A17\Twill\Models\Block $blockCreated |
||
| 95 | 2 | */ |
|
| 96 | private function createBlock(BlockRepository $blockRepository, $blockFields) |
||
| 97 | { |
||
| 98 | 2 | $blockCreated = $blockRepository->create($blockFields); |
|
| 99 | |||
| 100 | 2 | // Handle child blocks |
|
| 101 | $blockFields['blocks']->each(function ($childBlock) use ($blockCreated, $blockRepository) { |
||
| 102 | $childBlock['parent_id'] = $blockCreated->id; |
||
| 103 | $this->createBlock($blockRepository, $childBlock); |
||
| 104 | }); |
||
| 105 | |||
| 106 | return $blockCreated; |
||
| 107 | } |
||
| 108 | 21 | ||
| 109 | /** |
||
| 110 | 21 | * @param \A17\Twill\Models\Model $object |
|
| 111 | 21 | * @param array $fields |
|
| 112 | * @return \Illuminate\Support\Collection |
||
| 113 | 2 | */ |
|
| 114 | 2 | private function getBlocks($object, $fields) |
|
| 115 | 2 | { |
|
| 116 | 2 | $blocks = Collection::make(); |
|
| 117 | if (isset($fields['blocks']) && is_array($fields['blocks'])) { |
||
| 118 | 2 | foreach ($fields['blocks'] as $index => $block) { |
|
| 119 | $block = $this->buildBlock($block, $object); |
||
| 120 | $block['position'] = $index + 1; |
||
| 121 | 21 | $block['blocks'] = $this->getChildBlocks($object, $block); |
|
| 122 | |||
| 123 | $blocks->push($block); |
||
| 124 | } |
||
| 125 | } |
||
| 126 | return $blocks; |
||
| 127 | } |
||
| 128 | |||
| 129 | /** |
||
| 130 | * Recursively generate child blocks from the fields of a block |
||
| 131 | * |
||
| 132 | 2 | * @param \A17\Twill\Models\Model $object |
|
| 133 | * @param array $parentBlockFields |
||
| 134 | 2 | * @return \Illuminate\Support\Collection |
|
| 135 | */ |
||
| 136 | 2 | private function getChildBlocks($object, $parentBlockFields) |
|
| 137 | { |
||
| 138 | $childBlocksList = Collection::make(); |
||
| 139 | |||
| 140 | foreach ($parentBlockFields['blocks'] as $childKey => $childBlocks) { |
||
| 141 | foreach ($childBlocks as $index => $childBlock) { |
||
| 142 | $childBlock = $this->buildBlock($childBlock, $object, true); |
||
| 143 | $childBlock['child_key'] = $childKey; |
||
| 144 | $childBlock['position'] = $index + 1; |
||
| 145 | $childBlock['editor_name'] = $parentBlockFields['editor_name'] ?? 'default'; |
||
| 146 | $childBlock['blocks'] = $this->getChildBlocks($object, $childBlock); |
||
| 147 | 2 | ||
| 148 | $childBlocksList->push($childBlock); |
||
| 149 | } |
||
| 150 | } |
||
| 151 | |||
| 152 | return $childBlocksList; |
||
| 153 | } |
||
| 154 | |||
| 155 | /** |
||
| 156 | 2 | * @param array $block |
|
| 157 | * @param \A17\Twill\Models\Model $object |
||
| 158 | 2 | * @param bool $repeater |
|
| 159 | 2 | * @return array |
|
| 160 | */ |
||
| 161 | 2 | private function buildBlock($block, $object, $repeater = false) |
|
| 167 | } |
||
| 168 | |||
| 169 | 5 | /** |
|
| 170 | * @param \A17\Twill\Models\Model $object |
||
| 171 | 5 | * @param array $fields |
|
| 172 | * @return array |
||
| 173 | 5 | */ |
|
| 174 | public function getFormFieldsHandleBlocks($object, $fields) |
||
| 278 | } |
||
| 279 | |||
| 280 | /** |
||
| 281 | * @param \A17\Twill\Models\Block $block |
||
| 282 | * @return array |
||
| 283 | */ |
||
| 284 | protected function getBlockBrowsers($block) |
||
| 335 |
Loading history...
