UploadController::errorResponse() - Code Metrics - Inspection of "Merge pull request #80 from RihardsZ/master" - arbory/arbory - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( da99d4...871ace )

by Roberts

created 2018-07-31 11:16 UTC

UploadController::errorResponse() A

↳ Parent: UploadController

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	0
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

namespace Arbory\Base\Http\Controllers\Admin;

use UniSharp\LaravelFilemanager\Controllers\UploadController as LfmUploadController;

/**
 * Class UploadController.
 */
class UploadController extends LfmUploadController
{
    /**
     * Upload files
     *
     * @param void
     * @return string
     */
    public function upload()
    {
        $response = parent::upload();

        return count($this->errors) > 0 ? $this->errorResponse() : $response;

    }

    /**
     * Laravel File Manager and CKEditor integration is broken. In cases of unsuccessful uploads,
     * LFM returns error responses of unexpected format. This fixes that broken behaviour.
     *
     * @return array
     */
    protected function errorResponse()
    {
        if (request('responseType') === 'json') {
            return [
                "uploaded" => 0,
                "error" => [
                    "message" => implode(",\n", $this->errors)
                ]
            ];
        } else {
            return $this->errors;
        }
    }
}

1			<?php
2
3			namespace Arbory\Base\Http\Controllers\Admin;
4
5			use UniSharp\LaravelFilemanager\Controllers\UploadController as LfmUploadController;
6
7			/**
8			* Class UploadController.
9			*/
10			class UploadController extends LfmUploadController
11			{
12			/**
13			* Upload files
14			*
15			* @param void
16			* @return string
17			*/
18			public function upload()
19			{
20			$response = parent::upload();
21
22			return count($this->errors) > 0 ? $this->errorResponse() : $response;
			0 ignored issues – show Bug Best Practice introduced 2018-07-30 07:20 UTC by Report Bug Copy Issue Report The expression `return count($this->erro...rResponse() : $response` also could return the type `array` which is incompatible with the documented return type `string`. Loading history...
23			}
24
25			/**
26			* Laravel File Manager and CKEditor integration is broken. In cases of unsuccessful uploads,
27			* LFM returns error responses of unexpected format. This fixes that broken behaviour.
28			*
29			* @return array
30			*/
31			protected function errorResponse()
32			{
33			if (request('responseType') === 'json') {
34			return [
35			"uploaded" => 0,
36			"error" => [
37			"message" => implode(",\n", $this->errors)
38			]
39			];
40			} else {
41			return $this->errors;
42			}
43			}
44			}

arbory / arbory

Push — master ( da99d4...871ace )

UploadController::errorResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like