weakcache.*WeakCache.Get - Code Metrics - Inspection of "havey refacoring added support for delete" - arazmj/gerdu - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 7774a3...638b76 )

by Amir

created 2020-08-16 21:27 UTC

weakcache.*WeakCache.Get A

↳ Parent: weakcache/weak_cache.go

Complexity

Conditions

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	11
nop	1
dl	0
loc	13
rs	9.85
c	0
b	0
f	0

// Package weakcache implements Weak Cache, eviction of entries are controlled by GC
package weakcache

import (
	"github.com/arazmj/gerdu/metrics"
	"github.com/ivanrad/go-weakref/weakref"
	"sync"
)

// WeakCache data structure
type WeakCache struct {
	sync.Map
}

// NewWeakCache constructor
func NewWeakCache() *WeakCache {
	return &WeakCache{}
}

// Put a new key value pair
func (c *WeakCache) Put(key string, value string) (created bool) {
	metrics.Adds.Inc()
	ref := weakref.NewWeakRef(value)
	c.Store(key, ref)
	return true
}

// Get value by key
func (c *WeakCache) Get(key string) (value string, ok bool) {
	v, ok := c.Load(key)
	if ok {
		ref := v.(*weakref.WeakRef)
		if ref.IsAlive() {
			metrics.Hits.Inc()
			return ref.GetTarget().(string), true
		}
		metrics.Deletes.Inc()
		c.Delete(key)
	}
	metrics.Miss.Inc()
	return "", false
}

//Delete deletes the key
func (c *WeakCache) Delete(key string) bool {
	metrics.Deletes.Inc()
	c.Map.Delete(key)
	return true
}


1			// Package weakcache implements Weak Cache, eviction of entries are controlled by GC
2			package weakcache
3
4			import (
5			"github.com/arazmj/gerdu/metrics"
6			"github.com/ivanrad/go-weakref/weakref"
7			"sync"
8			)
9
10			// WeakCache data structure
11			type WeakCache struct {
12			sync.Map
13			}
14
15			// NewWeakCache constructor
16			func NewWeakCache() *WeakCache {
17			return &WeakCache{}
18			}
19
20			// Put a new key value pair
21			func (c *WeakCache) Put(key string, value string) (created bool) {
22			metrics.Adds.Inc()
23			ref := weakref.NewWeakRef(value)
24			c.Store(key, ref)
25			return true
26			}
27
28			// Get value by key
29			func (c *WeakCache) Get(key string) (value string, ok bool) {
30			v, ok := c.Load(key)
31			if ok {
32			ref := v.(*weakref.WeakRef)
33			if ref.IsAlive() {
34			metrics.Hits.Inc()
35			return ref.GetTarget().(string), true
36			}
37			metrics.Deletes.Inc()
38			c.Delete(key)
39			}
40			metrics.Miss.Inc()
41			return "", false
42			}
43
44			//Delete deletes the key
45			func (c *WeakCache) Delete(key string) bool {
46			metrics.Deletes.Inc()
47			c.Map.Delete(key)
48			return true
49			}
50

arazmj / gerdu

GitHub Access Token became invalid

Push — master ( 7774a3...638b76 )

weakcache.*WeakCache.Get A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like