Issues in Emit.php (master) - Issues in master - aptarus/promClientPhp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Exposition/Emit.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Aptarus\PromClient\Exposition;

use PDO;
use Aptarus\PromClient\Utility as U;
use Aptarus\PromClient\Configuration as Configuration;

class Emit
{
    public function __construct()
    {
        $metrics_db = U\PromClientOpenDB(Configuration::$storage_dir);

        // Clean up the DB first.
        $julian_day = unixtojd();
        $sth = $metrics_db->
            prepare('DELETE FROM metrics
                            WHERE var IN (SELECT var FROM meta
                                          WHERE ? - JULIANDAY(changed) > 3)');
        $sth->execute(array($julian_day));
        $meta_deleted = $sth->fetchColumn();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $sth = $metrics_db->prepare('DELETE FROM metrics
                                            WHERE ? - JULIANDAY(changed) > 3');
        $sth->execute(array($julian_day));
        $metics_deleted = $sth->fetchColumn();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->meta = $metrics_db
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ->query('SELECT var, typ, help FROM meta ORDER BY var ASC')
            ->fetchAll(PDO::FETCH_UNIQUE);

        $sth = $metrics_db
            ->prepare('SELECT labels, value, label_values
                         FROM metrics where var = ? ORDER BY var ASC');

        foreach (array_keys($this->meta) as $var) {
            if ($sth->execute(array($var))) {
                $this->metrics[$var] = $sth->fetchAll(PDO::FETCH_UNIQUE);
class MyClass { }

$x = new MyClass();
$x->foo = true;
            }
        }
    }

    // @codingStandardsIgnoreStart
    public function Text()
    {
        // @codingStandardsIgnoreEnd
        // Spew metrics.
        header('Content-Type: text/plain; version=0.0.4');

        foreach ($this->meta as $var) {
            print("# HELP $var " + $this->meta[$var]['help'] + "\n");
            print("# TYPE $var " + $this->meta[$var]['typ'] + "\n");
            foreach ($this->metrics[$var] as $labels) {
                $labels_quoted = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $lnames = unserialize($labels);
                if ($lnames) {
                    $lvalues = unserialize(
                        $this->metrics[$var][$labels]['label_values']
                    );
                    $lnv = $array_combine($lnames, $lvalues);

                    $lnv_quoted = array();
                    foreach ($lnv as $l) {
                        $lnv_quoted[] = $l + '="' + $lvalues[$l] + '"';
                    }
                    $labels_quoted = '{' + join(',', $lnv_quoted) + '}';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                }
                print(
                    "$var$plabels_quoted "

                    + $this->metrics[$var][$labels]['value'] + "\n"
                );
            }
        }
    }
}

// vim:sw=4 ts=4 et


1			<?php
2
3			namespace Aptarus\PromClient\Exposition;
4
5			use PDO;
6			use Aptarus\PromClient\Utility as U;
7			use Aptarus\PromClient\Configuration as Configuration;
8
9			class Emit
10			{
11			public function __construct()
12			{
13			$metrics_db = U\PromClientOpenDB(Configuration::$storage_dir);
14
15			// Clean up the DB first.
16			$julian_day = unixtojd();
17			$sth = $metrics_db->
18			prepare('DELETE FROM metrics
19			WHERE var IN (SELECT var FROM meta
20			WHERE ? - JULIANDAY(changed) > 3)');
21			$sth->execute(array($julian_day));
22			$meta_deleted = $sth->fetchColumn();
			0 ignored issues – show Unused Code introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$meta_deleted` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23			$sth = $metrics_db->prepare('DELETE FROM metrics
24			WHERE ? - JULIANDAY(changed) > 3');
25			$sth->execute(array($julian_day));
26			$metics_deleted = $sth->fetchColumn();
			0 ignored issues – show Unused Code introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$metics_deleted` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
27
28			$this->meta = $metrics_db
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `meta` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29			->query('SELECT var, typ, help FROM meta ORDER BY var ASC')
30			->fetchAll(PDO::FETCH_UNIQUE);
31
32			$sth = $metrics_db
33			->prepare('SELECT labels, value, label_values
34			FROM metrics where var = ? ORDER BY var ASC');
35
36			foreach (array_keys($this->meta) as $var) {
37			if ($sth->execute(array($var))) {
38			$this->metrics[$var] = $sth->fetchAll(PDO::FETCH_UNIQUE);
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `metrics` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
39			}
40			}
41			}
42
43			// @codingStandardsIgnoreStart
44			public function Text()
45			{
46			// @codingStandardsIgnoreEnd
47			// Spew metrics.
48			header('Content-Type: text/plain; version=0.0.4');
49
50			foreach ($this->meta as $var) {
51			print("# HELP $var " + $this->meta[$var]['help'] + "\n");
52			print("# TYPE $var " + $this->meta[$var]['typ'] + "\n");
53			foreach ($this->metrics[$var] as $labels) {
54			$labels_quoted = '';
			0 ignored issues – show Unused Code introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$labels_quoted` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55			$lnames = unserialize($labels);
56			if ($lnames) {
57			$lvalues = unserialize(
58			$this->metrics[$var][$labels]['label_values']
59			);
60			$lnv = $array_combine($lnames, $lvalues);
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$array_combine` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
61			$lnv_quoted = array();
62			foreach ($lnv as $l) {
63			$lnv_quoted[] = $l + '="' + $lvalues[$l] + '"';
64			}
65			$labels_quoted = '{' + join(',', $lnv_quoted) + '}';
			0 ignored issues – show Unused Code introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$labels_quoted` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
66			}
67			print(
68			"$var$plabels_quoted "
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$plabels_quoted` does not exist. Did you mean `$labels`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
69			+ $this->metrics[$var][$labels]['value'] + "\n"
70			);
71			}
72			}
73			}
74			}
75
76			// vim:sw=4 ts=4 et
77

aptarus / promClientPhp

Issues (19)

Security Analysis no request data

src/Exposition/Emit.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like