Metric::_metric_inc() - Code Metrics - Inspection of "Changes to fix style errors." - aptarus/promClientPhp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 991e86...bf493b )

by Kevin

created 2016-09-19 15:22 UTC

Metric::_metric_inc() A

↳ Parent: Metric

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	1
eloc	10
c	4
b	0
f	0
nc	1
nop	1
dl	0
loc	16
rs	9.4285

<?php

namespace Aptarus\PromClient;

use PDO;
use Aptarus\PromClient\Utility as U;

class Metric
{
    static $metrics_db = null;
class A {
    var $property;
}

    public function __construct($typ, $var, $help, $labels, $label_values)
    {
        if (!preg_match('/^[a-zA-Z_:][a-zA-Z0-9_:]*$/', $var)) {
            throw new Exceptions\InvalidName(sprintf(
                "Metric name '%s' is invalid",
                $var
            ));
        }
        $this->typ = $typ;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->var = $var;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->help = $help;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->labels = $labels;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->label_values = $label_values;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        if (!self::$metrics_db) {
            self::$metrics_db = U\PromClientOpenDB(Configuration::$storage_dir);
        }
        $sth = self::$metrics_db->
            prepare('INSERT INTO meta (var, typ, help) VALUES (?, ?, ?)');
        $sth->execute(array($this->var, $this->typ, $this->help));
    }

    protected function metricInc($var_value)
    {
        $sth = self::$metrics_db->
            prepare('INSERT OR IGNORE INTO metrics
            (value,label_values,var,labels) VALUES (?, ?, ?, ?)');
        $sth->execute(array(0, serialize($this->label_values),
            $this->var, serialize($this->labels)));
        $sth = self::$metrics_db->
            prepare('UPDATE metrics
                        SET value = value + ?,
                            label_values = ?
                     WHERE var = ? AND labels = ?');
        $sth->execute(array($var_value, serialize($this->label_values),
                      $this->var, serialize($this->labels)));
        $this->label_values = [];
    }

    protected function metricSet($var_value)
    {
        $sth = self::$metrics_db->
            prepare(
                'INSERT INTO metrics (value, label_values, var, labels)
                        VALUES (?, ?, ?, ?)'
            );

        $sth->execute(array($var_value, serialize($this->label_values),
            $this->var, serialize($this->labels)));
        $this->label_values = [];
    }
}

// vim:sw=4 ts=4 et


1			<?php
2
3			namespace Aptarus\PromClient;
4
5			use PDO;
6			use Aptarus\PromClient\Utility as U;
7
8			class Metric
9			{
10			static $metrics_db = null;
			0 ignored issues – show Coding Style introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$metrics_db`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
11
12			public function __construct($typ, $var, $help, $labels, $label_values)
13			{
14			if (!preg_match('/^[a-zA-Z_:][a-zA-Z0-9_:]*$/', $var)) {
15			throw new Exceptions\InvalidName(sprintf(
16			"Metric name '%s' is invalid",
17			$var
18			));
19			}
20			$this->typ = $typ;
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report The property `typ` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21			$this->var = $var;
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report The property `var` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			$this->help = $help;
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report The property `help` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			$this->labels = $labels;
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report The property `labels` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->label_values = $label_values;
			0 ignored issues – show Bug introduced 2016-09-13 15:35 UTC by Report Bug Copy Issue Report The property `label_values` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			if (!self::$metrics_db) {
26			self::$metrics_db = U\PromClientOpenDB(Configuration::$storage_dir);
27			}
28			$sth = self::$metrics_db->
29			prepare('INSERT INTO meta (var, typ, help) VALUES (?, ?, ?)');
30			$sth->execute(array($this->var, $this->typ, $this->help));
31			}
32
33			protected function metricInc($var_value)
34			{
35			$sth = self::$metrics_db->
36			prepare('INSERT OR IGNORE INTO metrics
37			(value,label_values,var,labels) VALUES (?, ?, ?, ?)');
38			$sth->execute(array(0, serialize($this->label_values),
39			$this->var, serialize($this->labels)));
40			$sth = self::$metrics_db->
41			prepare('UPDATE metrics
42			SET value = value + ?,
43			label_values = ?
44			WHERE var = ? AND labels = ?');
45			$sth->execute(array($var_value, serialize($this->label_values),
46			$this->var, serialize($this->labels)));
47			$this->label_values = [];
48			}
49
50			protected function metricSet($var_value)
51			{
52			$sth = self::$metrics_db->
53			prepare(
54			'INSERT INTO metrics (value, label_values, var, labels)
55			VALUES (?, ?, ?, ?)'
56			);
57
58			$sth->execute(array($var_value, serialize($this->label_values),
59			$this->var, serialize($this->labels)));
60			$this->label_values = [];
61			}
62			}
63
64			// vim:sw=4 ts=4 et
65

aptarus / promClientPhp

Push — master ( 991e86...bf493b )

Metric::_metric_inc() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like