Orders::__construct() - Code Metrics - Inspection of "Фикс StyleCI" - appwilio/russianpost-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8428c1...16b454 )

by Jhao

created 2019-09-19 01:58 UTC

Orders::__construct() A

↳ Parent: Orders

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
dl	0
loc	3
ccs	0
cts	0
cp	0
crap	2
rs	10
c	1
b	0
f	0
eloc	1
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Appwilio\RussianPostSDK\Dispatching\Endpoints\Orders;

use Appwilio\RussianPostSDK\Dispatching\Http\ApiClient;
use Appwilio\RussianPostSDK\Dispatching\Contracts\Arrayable;
use Appwilio\RussianPostSDK\Dispatching\Endpoints\Orders\Requests\OrderRequest;
use Appwilio\RussianPostSDK\Dispatching\Endpoints\Orders\Exceptions\OrderException;

final class Orders
{
    /** @var ApiClient */
    private $client;

    public function __construct(ApiClient $client)
    {
        $this->client = $client;
    }

    /**
     * Создание заказа.
     *
     * @link https://otpravka.pochta.ru/specification#/orders-creating_order
     *
     * @param  OrderRequest  $request
     *
     * @throws OrderException
     *
     * @return string номер созданного заказа
     */
    public function create(OrderRequest $request): string
    {
        $response = $this->client->put('/1.0/user/backlog', $request);

        if (isset($response['result-ids'])) {
            return (string) $response['result-ids'][0];
        }

        return $response['errors'] ?? $response;
    }

    public function delete(array $ids)
    {
        $response = $this->client->delete('/1.0/user/backlog', new class($ids) implements Arrayable {
            private $ids;

            public function __construct(array $ids)
            {
                $this->ids = $ids;
            }

            public function toArray(): array
            {
                return $this->ids;
            }
        });

        return $response['result-ids'] ?? $response['errors'] ?? $response;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Appwilio\RussianPostSDK\Dispatching\Endpoints\Orders;
6
7			use Appwilio\RussianPostSDK\Dispatching\Http\ApiClient;
8			use Appwilio\RussianPostSDK\Dispatching\Contracts\Arrayable;
9			use Appwilio\RussianPostSDK\Dispatching\Endpoints\Orders\Requests\OrderRequest;
10			use Appwilio\RussianPostSDK\Dispatching\Endpoints\Orders\Exceptions\OrderException;
11
12			final class Orders
13			{
14			/** @var ApiClient */
15			private $client;
16
17			public function __construct(ApiClient $client)
18			{
19			$this->client = $client;
20			}
21
22			/**
23			* Создание заказа.
24			*
25			* @link https://otpravka.pochta.ru/specification#/orders-creating_order
26			*
27			* @param OrderRequest $request
28			*
29			* @throws OrderException
30			*
31			* @return string номер созданного заказа
32			*/
33			public function create(OrderRequest $request): string
34			{
35			$response = $this->client->put('/1.0/user/backlog', $request);
36
37			if (isset($response['result-ids'])) {
38			return (string) $response['result-ids'][0];
39			}
40
41			return $response['errors'] ?? $response;
42			}
43
44			public function delete(array $ids)
45			{
46			$response = $this->client->delete('/1.0/user/backlog', new class($ids) implements Arrayable {
47			private $ids;
48
49			public function __construct(array $ids)
50			{
51			$this->ids = $ids;
52			}
53
54			public function toArray(): array
55			{
56			return $this->ids;
57			}
58			});
59
60			return $response['result-ids'] ?? $response['errors'] ?? $response;
61			}
62			}
63

appwilio / russianpost-sdk

Push — master ( 8428c1...16b454 )

Orders::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like