AppserverIo\Routlt\Results\ServletDispatcherResult

Complexity

Total Complexity

5

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setServletContext()	0	4	1
A	getServletContext()	0	4	1
B	process()	0	31	3

<?php

/**
 * AppserverIo\Routlt\Results\ServletDispatcherResult
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author     Tim Wagner <tw@techdivision.com>
 * @copyright  2015 TechDivision GmbH <info@techdivision.com>
 * @license    http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link       http://github.com/appserver-io/routlt
 * @link       http://www.appserver.io
 */

namespace AppserverIo\Routlt\Results;

use AppserverIo\Routlt\Util\ServletContextAware;
use AppserverIo\Psr\Servlet\ServletContextInterface;
use AppserverIo\Psr\Servlet\ServletRequestInterface;
use AppserverIo\Psr\Servlet\ServletResponseInterface;

/**
 * Result implementation that dispatches another servlet.
 *
 * @author     Tim Wagner <tw@techdivision.com>
 * @copyright  2015 TechDivision GmbH <info@techdivision.com>
 * @license    http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link       http://github.com/appserver-io/routlt
 * @link       http://www.appserver.io
 */
class ServletDispatcherResult implements ResultInterface, ServletContextAware
{

    /**
     * Trait proving basic result functionality.
     *
     * @var \AppserverIo\Routlt\Results\ResultTrait
     */
    use ResultTrait;

    /**
     * The servlet context instance.
     *
     * @param \AppserverIo\Psr\Servlet\ServletContextInterface
     */
    protected $servletContext;

    /**
     * Sets the actual servlet context instance.
     *
     * @param \AppserverIo\Psr\Servlet\ServletContextInterface $servletContext The servlet context instance
     *
     * @return void
     */
    public function setServletContext(ServletContextInterface $servletContext)
    {
        $this->servletContext = $servletContext;
    }

    /**
     * Returns the servlet context instance.
     *
     * @return \AppserverIo\Psr\Servlet\ServletContextInterface The servlet context instance
    */
    public function getServletContext()
    {
        return $this->servletContext;
    }

    /**
     * Processes an action result by dispatching the configured servlet.
     *
     * @param \AppserverIo\Psr\Servlet\ServletRequestInterface  $servletRequest  The request instance
     * @param \AppserverIo\Psr\Servlet\ServletResponseInterface $servletResponse The response sent back to the client
     *
     * @return void
     */
    public function process(ServletRequestInterface $servletRequest, ServletResponseInterface $servletResponse)
    {

        // initialize the variables for the path and the query string
        $path = null;
        $query = null;

        // load result and session-ID
        extract(parse_url($this->getResult()));

parse_url($this->getResult()) cannot be passed to extract() as the parameter $var_array expects a reference.

        // initialize the request URI
        if (!empty($path)) {
            $servletRequest->setRequestUri($path);

The method setRequestUri() does not seem to exist on object<AppserverIo\Psr\Servlet\ServletRequestInterface>.

        }

        // initialize the query string
        if (!empty($query)) {
            $servletRequest->setQueryString($query);

The method setQueryString() does not seem to exist on object<AppserverIo\Psr\Servlet\ServletRequestInterface>.

        }

        // prepare the request with the new data
        $servletRequest->prepare();

The method prepare() does not seem to exist on object<AppserverIo\Psr\Servlet\ServletRequestInterface>.

        // load the servlet path and session-ID
        $servletPath = $servletRequest->getServletPath();
        $sessionId = $servletRequest->getProposedSessionId();

It seems like you code against a concrete implementation and not the interface AppserverIo\Psr\Servlet\ServletRequestInterface as the method getProposedSessionId() does only exist in the following implementations of said interface: AppserverIo\Psr\Servlet\Http\HttpServletRequestWrapper.

        // load and process the servlet
        $servlet = $this->getServletContext()->lookup($servletPath, $sessionId);

The method lookup() does not seem to exist on object<AppserverIo\Psr\Servlet\ServletContextInterface>.

        $servlet->service($servletRequest, $servletResponse);
    }
}