loadTasks - Code Metrics - Inspection of "Merge pull request #2 from wagnert/master" - appserver-io/robo-tasks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a7122d...c2f186 )

by Tim

created 2017-06-01 18:05 UTC

loadTasks A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	0
dl	0
loc	23
rs	10
c	0
b	0
f	0
ccs	0
cts	8
cp	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	taskWatch()	0	4	1
A	taskSync()	0	4	1

<?php

/**
 * AppserverIo\RoboTasks\Base\loadTasks
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/robo-tasks
 * @link      http://www.appserver.io
 */

namespace AppserverIo\RoboTasks\Base;

/**
 * The task loader trait for the base tasks.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/robo-tasks
 * @link      http://www.appserver.io
 */
trait loadTasks
{

    /**
     * Returns the extended watch task.
     *
     * @return AppserverIo\RoboTasks\Base\Watch
     */
    protected function taskWatch()
    {
        return $this->task(Watch::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Returns the extended sync task.
     *
     * @return AppserverIo\RoboTasks\Base\Sync
     */
    protected function taskSync()
    {
        return $this->task(Sync::class);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			/**
4			* AppserverIo\RoboTasks\Base\loadTasks
5			*
6			* NOTICE OF LICENSE
7			*
8			* This source file is subject to the Open Software License (OSL 3.0)
9			* that is available through the world-wide-web at this URL:
10			* http://opensource.org/licenses/osl-3.0.php
11			*
12			* PHP version 5
13			*
14			* @author Tim Wagner <[email protected]>
15			* @copyright 2015 TechDivision GmbH <[email protected]>
16			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17			* @link https://github.com/appserver-io/robo-tasks
18			* @link http://www.appserver.io
19			*/
20
21			namespace AppserverIo\RoboTasks\Base;
22
23			/**
24			* The task loader trait for the base tasks.
25			*
26			* @author Tim Wagner <[email protected]>
27			* @copyright 2015 TechDivision GmbH <[email protected]>
28			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
29			* @link https://github.com/appserver-io/robo-tasks
30			* @link http://www.appserver.io
31			*/
32			trait loadTasks
33			{
34
35			/**
36			* Returns the extended watch task.
37			*
38			* @return AppserverIo\RoboTasks\Base\Watch
39			*/
40			protected function taskWatch()
41			{
42			return $this->task(Watch::class);
			0 ignored issues – show Bug introduced 2017-06-01 17:24 UTC by Report Bug Copy Issue Report It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
43			}
44
45			/**
46			* Returns the extended sync task.
47			*
48			* @return AppserverIo\RoboTasks\Base\Sync
49			*/
50			protected function taskSync()
51			{
52			return $this->task(Sync::class);
			0 ignored issues – show Bug introduced 2017-06-01 17:24 UTC by Report Bug Copy Issue Report It seems like `task()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
53			}
54			}
55

appserver-io / robo-tasks

Push — master ( a7122d...c2f186 )

loadTasks A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like